Skip to content

[Benchmarks] Migrate linux throughput tests #6765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
faydef merged 32 commits into from
Mar 17, 2025
Merged

[Benchmarks] Migrate linux throughput tests #6765

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
1e0d81c
add trigger from dotnet repo
faydef Feb 25, 2025
5677df2
szitch to fixed branch
faydef Feb 25, 2025
f61092b
fix windows stage
faydef Feb 25, 2025
b5a03b9
change artifact path
faydef Feb 25, 2025
96949d3
omit unnecessary artifact
faydef Feb 25, 2025
e3c00ae
change branch
faydef Feb 25, 2025
df818b2
change aws parameter
faydef Feb 25, 2025
0652145
pass artifacts first
faydef Feb 25, 2025
d9735f9
copy env file first
faydef Feb 25, 2025
85d557a
change ssm parameter
faydef Feb 25, 2025
da2b695
stick to earlier parameter
faydef Feb 25, 2025
5151d6a
use new image and get the DD_API_KEY externally
faydef Mar 11, 2025
1376c4a
only run manually for now
faydef Mar 11, 2025
458c87e
run simple test to spawn a windows instance
faydef Mar 11, 2025
0c0dec9
fix typo
faydef Mar 12, 2025
1f54bca
expidite runs of macroebenchmarks
faydef Mar 12, 2025
623b7e0
add a test stage
faydef Mar 12, 2025
2470e32
chnage image to earlier version of tooling
faydef Mar 12, 2025
78a3f86
switch to prod branch
faydef Mar 13, 2025
0979c38
only keep linux benchmarks
faydef Mar 13, 2025
6628900
update rules to only run on commit on master, manual trigger, schedul…
faydef Mar 13, 2025
bf19a69
allow failure of benchmark related jobs in order not to initially bre…
faydef Mar 13, 2025
0f6d8ae
allow manually triggering the jobs as well
faydef Mar 13, 2025
6fca030
change triggers for child pipeline
faydef Mar 13, 2025
13aa352
change triggers for jobs
faydef Mar 13, 2025
ba27771
only keep rules on child pipeline
faydef Mar 13, 2025
018bb97
temporarely override branch
faydef Mar 13, 2025
2c0d6cf
change the override mechanism
faydef Mar 13, 2025
169deb1
delete override variable
faydef Mar 13, 2025
1f41a57
CI: only run scheduled benchmarks on their dedicated schedule
faydef Mar 13, 2025
58597dc
seperate setup for arm runners
faydef Mar 17, 2025
05304e4
tweak: increase warm up rate
faydef Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .gitlab-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,4 +201,17 @@ benchmark-serverless-trigger:
UPSTREAM_PROJECT_NAME: $CI_PROJECT_NAME
UPSTREAM_GITLAB_USER_LOGIN: $GITLAB_USER_LOGIN
UPSTREAM_GITLAB_USER_EMAIL: $GITLAB_USER_EMAIL

macrobenchmarks:
stage: benchmarks
needs: [ ]
trigger:
include: .gitlab/benchmarks/macrobenchmarks.yml
allow_failure: true
rules:
- if: '$CI_PIPELINE_SOURCE == "push" && $CI_COMMIT_BRANCH == "master"'
when: always
- if: '$CI_PIPELINE_SOURCE == "schedule" && $BENCHMARK_RUN == "true"'
Copy link
Member

@andrewlock andrewlock Mar 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to clarify

  • AFAIK, we don't have a scheduled gitlab run currently (just azure devops)
  • Presumably, if we want to add one, we could add it to this file? I don't think it's necessary if we're testing against master, unless we want to also schedule tests against older branches for comparison🤔
  • If we do a manual run, this will always run?

Copy link
Contributor Author

@faydef faydef Mar 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't have a scheduled gitlab run currently (just azure devops)
Presumably, if we want to add one, we could add it to this file?

I will add the scheduled Gitlab pipeline run once the PR is merged, the other Gitlab schedules for the dd-trace-dotnet repo live here.

If we do a manual run, this will always run?
You'll need to manually trigger the child pipeline.

when: always
- when: manual

Loading
Loading