Skip to content

Fix download artifacts link in logs. Improve logging. #7870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
NachoEchevarria merged 2 commits into from
Nov 28, 2025
Merged

Fix download artifacts link in logs. Improve logging. #7870

NachoEchevarria merged 2 commits into from
Nov 28, 2025

Conversation

@NachoEchevarria
Copy link
Collaborator

@NachoEchevarria NachoEchevarria commented Nov 26, 2025 •
edited
Loading

Summary of changes

In jobs dd-gitlab/download-serverless-artifacts and dd-gitlab/download-single-step-artifacts
, when Azure DevOps artifacts couldn't be found, the log output wrapped the artifacts URL in single quotes for display:
echo "Checking for artifacts at '$artifactsUrl'..."

When users clicked or copied the URL from logs to debug issues, they inadvertently included the trailing ' character, which became %27 in the URL. This caused the Azure DevOps API to search for an artifact named ssi-artifacts' instead of ssi-artifacts, resulting in a 404 error.

Changes made in download-single-step-artifacts.sh and download-serverless-artifacts.sh:

  • Removed quotes around ${artifactsUrl} in echo statement
  • Added proper quoting to curl command for safety
  • Added status reporting during polling to show elapsed time and API error messages
  • Enhanced error output to display full API response and direct build link when timeout occurs

After the changes:

image

Reason for change

The urls and links shown in the logs were not correct. Added more log info to debug failures.

Implementation details

Test coverage

Other details

@dd-trace-dotnet-ci-bot
Copy link

dd-trace-dotnet-ci-bot bot commented Nov 26, 2025 •
edited
Loading

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (7870) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration75.54 ± (75.66 - 76.57) ms75.58 ± (75.74 - 76.37) ms+0.1%✅⬆️
.NET Framework 4.8 - Bailout
duration78.44 ± (78.48 - 79.27) ms80.48 ± (80.43 - 81.37) ms+2.6%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1056.60 ± (1061.10 - 1072.97) ms1070.61 ± (1072.18 - 1084.04) ms+1.3%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms22.97 ± (22.88 - 23.06) ms23.21 ± (23.12 - 23.31) ms+1.1%✅⬆️
process.time_to_main_ms87.39 ± (86.98 - 87.79) ms89.02 ± (88.65 - 89.39) ms+1.9%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.93 ± (10.93 - 10.94) MB10.93 ± (10.93 - 10.93) MB-0.0%✅
runtime.dotnet.threads.count12 ± (12 - 12)12 ± (12 - 12)+0.0%✅
.NET Core 3.1 - Bailout
process.internal_duration_ms22.71 ± (22.65 - 22.77) ms22.96 ± (22.89 - 23.03) ms+1.1%✅⬆️
process.time_to_main_ms87.50 ± (87.17 - 87.84) ms89.56 ± (89.22 - 89.90) ms+2.3%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.97 ± (10.97 - 10.97) MB10.97 ± (10.97 - 10.97) MB-0.0%✅
runtime.dotnet.threads.count13 ± (13 - 13)13 ± (13 - 13)+0.0%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms219.96 ± (218.38 - 221.54) ms223.63 ± (222.20 - 225.06) ms+1.7%✅⬆️
process.time_to_main_ms496.03 ± (494.81 - 497.24) ms503.99 ± (502.76 - 505.23) ms+1.6%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed47.77 ± (47.75 - 47.79) MB47.77 ± (47.75 - 47.79) MB-0.0%✅
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.5%✅⬆️
.NET 6 - Baseline
process.internal_duration_ms21.76 ± (21.68 - 21.83) ms21.86 ± (21.80 - 21.93) ms+0.5%✅⬆️
process.time_to_main_ms75.80 ± (75.44 - 76.15) ms76.79 ± (76.48 - 77.11) ms+1.3%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.63 ± (10.62 - 10.63) MB10.65 ± (10.64 - 10.65) MB+0.2%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 6 - Bailout
process.internal_duration_ms21.81 ± (21.74 - 21.88) ms21.73 ± (21.68 - 21.79) ms-0.3%✅
process.time_to_main_ms77.97 ± (77.66 - 78.28) ms78.30 ± (78.08 - 78.52) ms+0.4%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.70 ± (10.70 - 10.71) MB10.74 ± (10.74 - 10.74) MB+0.4%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms211.50 ± (210.08 - 212.92) ms212.84 ± (211.41 - 214.27) ms+0.6%✅⬆️
process.time_to_main_ms467.65 ± (466.65 - 468.65) ms471.07 ± (470.14 - 472.00) ms+0.7%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed47.99 ± (47.97 - 48.02) MB48.03 ± (48.01 - 48.06) MB+0.1%✅⬆️
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.0%✅⬆️
.NET 8 - Baseline
process.internal_duration_ms20.16 ± (20.08 - 20.23) ms19.99 ± (19.93 - 20.04) ms-0.8%✅
process.time_to_main_ms76.89 ± (76.50 - 77.28) ms75.80 ± (75.52 - 76.08) ms-1.4%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.67 ± (7.67 - 7.68) MB7.66 ± (7.65 - 7.67) MB-0.2%✅
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 8 - Bailout
process.internal_duration_ms19.83 ± (19.77 - 19.88) ms20.05 ± (20.00 - 20.11) ms+1.1%✅⬆️
process.time_to_main_ms76.76 ± (76.39 - 77.13) ms77.34 ± (77.05 - 77.63) ms+0.8%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.73 ± (7.72 - 7.73) MB7.71 ± (7.71 - 7.72) MB-0.2%✅
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms191.97 ± (191.08 - 192.85) ms194.86 ± (193.95 - 195.77) ms+1.5%✅⬆️
process.time_to_main_ms454.27 ± (453.29 - 455.25) ms460.79 ± (459.96 - 461.62) ms+1.4%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed36.49 ± (36.45 - 36.53) MB36.53 ± (36.48 - 36.57) MB+0.1%✅⬆️
runtime.dotnet.threads.count27 ± (27 - 27)27 ± (27 - 27)+0.0%✅⬆️

HttpMessageHandler

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration194.92 ± (194.70 - 195.36) ms196.43 ± (196.48 - 197.43) ms+0.8%✅⬆️
.NET Framework 4.8 - Bailout
duration198.30 ± (198.03 - 198.51) ms200.66 ± (200.59 - 201.52) ms+1.2%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1123.56 ± (1125.23 - 1133.30) ms1165.14 ± (1163.37 - 1172.63) ms+3.7%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms190.14 ± (189.82 - 190.46) ms192.66 ± (192.21 - 193.11) ms+1.3%✅⬆️
process.time_to_main_ms81.84 ± (81.64 - 82.03) ms85.55 ± (85.30 - 85.81) ms+4.5%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.07 ± (16.04 - 16.09) MB16.18 ± (16.17 - 16.20) MB+0.7%✅⬆️
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (20 - 20)+0.3%✅⬆️
.NET Core 3.1 - Bailout
process.internal_duration_ms190.16 ± (189.76 - 190.57) ms192.03 ± (191.57 - 192.49) ms+1.0%✅⬆️
process.time_to_main_ms83.18 ± (82.97 - 83.39) ms86.52 ± (86.27 - 86.76) ms+4.0%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.14 ± (16.12 - 16.16) MB16.24 ± (16.22 - 16.26) MB+0.6%✅⬆️
runtime.dotnet.threads.count21 ± (20 - 21)21 ± (20 - 21)-0.0%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms407.30 ± (404.37 - 410.23) ms411.29 ± (408.65 - 413.92) ms+1.0%✅⬆️
process.time_to_main_ms478.02 ± (477.48 - 478.57) ms490.44 ± (489.25 - 491.62) ms+2.6%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed58.85 ± (58.75 - 58.95) MB59.08 ± (59.01 - 59.15) MB+0.4%✅⬆️
runtime.dotnet.threads.count29 ± (29 - 30)29 ± (29 - 29)-0.2%✅
.NET 6 - Baseline
process.internal_duration_ms193.89 ± (193.56 - 194.22) ms198.21 ± (197.73 - 198.69) ms+2.2%✅⬆️
process.time_to_main_ms70.73 ± (70.57 - 70.89) ms74.07 ± (73.87 - 74.27) ms+4.7%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.40 ± (16.37 - 16.43) MB16.44 ± (16.42 - 16.46) MB+0.2%✅⬆️
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)+1.0%✅⬆️
.NET 6 - Bailout
process.internal_duration_ms194.00 ± (193.71 - 194.28) ms196.33 ± (195.85 - 196.81) ms+1.2%✅⬆️
process.time_to_main_ms72.27 ± (72.11 - 72.42) ms74.64 ± (74.43 - 74.84) ms+3.3%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.33 ± (16.23 - 16.44) MB16.45 ± (16.43 - 16.47) MB+0.7%✅⬆️
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (20 - 20)+1.8%✅⬆️
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms418.71 ± (416.09 - 421.34) ms423.44 ± (421.07 - 425.81) ms+1.1%✅⬆️
process.time_to_main_ms447.45 ± (446.80 - 448.09) ms458.85 ± (457.82 - 459.87) ms+2.5%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed59.26 ± (59.16 - 59.36) MB59.47 ± (59.39 - 59.55) MB+0.3%✅⬆️
runtime.dotnet.threads.count30 ± (29 - 30)29 ± (29 - 29)-0.4%✅
.NET 8 - Baseline
process.internal_duration_ms192.07 ± (191.81 - 192.34) ms194.84 ± (194.41 - 195.27) ms+1.4%✅⬆️
process.time_to_main_ms70.67 ± (70.47 - 70.87) ms72.94 ± (72.74 - 73.13) ms+3.2%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.76 ± (11.74 - 11.78) MB11.86 ± (11.84 - 11.88) MB+0.9%✅⬆️
runtime.dotnet.threads.count18 ± (18 - 18)18 ± (18 - 18)+0.4%✅⬆️
.NET 8 - Bailout
process.internal_duration_ms191.55 ± (191.29 - 191.80) ms194.37 ± (193.93 - 194.80) ms+1.5%✅⬆️
process.time_to_main_ms71.50 ± (71.40 - 71.60) ms74.47 ± (74.24 - 74.69) ms+4.2%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.83 ± (11.80 - 11.85) MB11.91 ± (11.89 - 11.93) MB+0.7%✅⬆️
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)-0.2%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms370.49 ± (369.13 - 371.86) ms372.51 ± (371.02 - 374.01) ms+0.5%✅⬆️
process.time_to_main_ms438.32 ± (437.58 - 439.07) ms442.24 ± (441.19 - 443.29) ms+0.9%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed47.88 ± (47.84 - 47.91) MB47.94 ± (47.91 - 47.97) MB+0.1%✅⬆️
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 29)+0.1%✅⬆️
Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts
FakeDbCommand (.NET Framework 4.8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7870) - mean (76ms)  : 71, 81
    master - mean (76ms)  : 70, 83

    section Bailout
    This PR (7870) - mean (81ms)  : 74, 88
    master - mean (79ms)  : 73, 85

    section CallTarget+Inlining+NGEN
    This PR (7870) - mean (1,078ms)  : 988, 1168
    master - mean (1,067ms)  : 976, 1158
Loading
FakeDbCommand (.NET Core 3.1) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7870) - mean (120ms)  : 113, 127
    master - mean (118ms)  : 111, 125

    section Bailout
    This PR (7870) - mean (120ms)  : 113, 127
    master - mean (118ms)  : 111, 125

    section CallTarget+Inlining+NGEN
    This PR (7870) - mean (769ms)  : 735, 802
    master - mean (758ms)  : 720, 796
Loading
FakeDbCommand (.NET 6) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7870) - mean (106ms)  : 99, 113
    master - mean (105ms)  : 98, 111

    section Bailout
    This PR (7870) - mean (107ms)  : 103, 111
    master - mean (107ms)  : 100, 114

    section CallTarget+Inlining+NGEN
    This PR (7870) - mean (716ms)  : 676, 757
    master - mean (719ms)  : 677, 762
Loading
FakeDbCommand (.NET 8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7870) - mean (105ms)  : 98, 111
    master - mean (106ms)  : 98, 114

    section Bailout
    This PR (7870) - mean (106ms)  : 101, 112
    master - mean (105ms)  : 98, 112

    section CallTarget+Inlining+NGEN
    This PR (7870) - mean (697ms)  : 665, 729
    master - mean (690ms)  : 661, 720
Loading
HttpMessageHandler (.NET Framework 4.8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7870) - mean (197ms)  : 190, 204
    master - mean (195ms)  : 192, 198

    section Bailout
    This PR (7870) - mean (201ms)  : 195, 207
    master - mean (198ms)  : 196, 201

    section CallTarget+Inlining+NGEN
    This PR (7870) - mean (1,168ms)  : 1098, 1238
    master - mean (1,129ms)  : 1071, 1188
Loading
HttpMessageHandler (.NET Core 3.1) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7870) - mean (289ms)  : 276, 302
    master - mean (280ms)  : 276, 285

    section Bailout
    This PR (7870) - mean (288ms)  : 281, 296
    master - mean (281ms)  : 276, 287

    section CallTarget+Inlining+NGEN
    This PR (7870) - mean (950ms)  : 902, 998
    master - mean (924ms)  : 880, 969
Loading
HttpMessageHandler (.NET 6) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7870) - mean (281ms)  : 272, 291
    master - mean (274ms)  : 267, 280

    section Bailout
    This PR (7870) - mean (280ms)  : 269, 291
    master - mean (275ms)  : 270, 279

    section CallTarget+Inlining+NGEN
    This PR (7870) - mean (932ms)  : 887, 976
    master - mean (902ms)  : 860, 944
Loading
HttpMessageHandler (.NET 8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7870) - mean (278ms)  : 268, 288
    master - mean (273ms)  : 267, 278

    section Bailout
    This PR (7870) - mean (280ms)  : 271, 288
    master - mean (273ms)  : 269, 276

    section CallTarget+Inlining+NGEN
    This PR (7870) - mean (864ms)  : 828, 900
    master - mean (839ms)  : 813, 865
Loading

@pr-commenter
Copy link

pr-commenter bot commented Nov 26, 2025

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmarks for #7870 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.653
  • 3 benchmarks are slower, with geometric mean 1.222
  • 4 benchmarks have fewer allocations
  • 6 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7870

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑netcoreapp3.1 5.71 KB 5.74 KB 30 B 0.53%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 9.99μs 54.5ns 332ns 0 0 0 5.5 KB
master StartStopWithChild netcoreapp3.1 13.6μs 70.4ns 330ns 0 0 0 5.71 KB
master StartStopWithChild net472 21.8μs 120ns 741ns 0.978 0.435 0.109 6.01 KB
#7870 StartStopWithChild net6.0 10.8μs 58.6ns 352ns 0 0 0 5.51 KB
#7870 StartStopWithChild netcoreapp3.1 14.1μs 69.4ns 302ns 0 0 0 5.74 KB
#7870 StartStopWithChild net472 22.3μs 118ns 588ns 0.985 0.328 0.109 6.02 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 939μs 45.8ns 177ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 1.02ms 623ns 2.41μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 1.22ms 61.8ns 231ns 0 0 0 3.31 KB
#7870 WriteAndFlushEnrichedTraces net6.0 961μs 3.35μs 13μs 0 0 0 2.71 KB
#7870 WriteAndFlushEnrichedTraces netcoreapp3.1 1.02ms 46.7ns 175ns 0 0 0 2.7 KB
#7870 WriteAndFlushEnrichedTraces net472 1.21ms 49.7ns 186ns 0 0 0 3.31 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 1.09μs 1.29ns 5.01ns 0 0 0 1.22 KB
master AllCycleSimpleBody netcoreapp3.1 1.39μs 7.67ns 46.6ns 0 0 0 1.2 KB
master AllCycleSimpleBody net472 1.03μs 0.897ns 3.47ns 0.194 0 0 1.23 KB
master AllCycleMoreComplexBody net6.0 7.28μs 33.8ns 131ns 0 0 0 4.72 KB
master AllCycleMoreComplexBody netcoreapp3.1 8.98μs 32ns 124ns 0 0 0 4.62 KB
master AllCycleMoreComplexBody net472 7.7μs 4.79ns 18.6ns 0.729 0 0 4.74 KB
master ObjectExtractorSimpleBody net6.0 331ns 1.68ns 7.52ns 0 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 401ns 2.2ns 12.2ns 0 0 0 272 B
master ObjectExtractorSimpleBody net472 298ns 0.167ns 0.648ns 0.0436 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 6.4μs 30.1ns 141ns 0 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 7.86μs 29.1ns 113ns 0 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 6.67μs 5.3ns 19.8ns 0.602 0 0 3.8 KB
#7870 AllCycleSimpleBody net6.0 1.09μs 1.02ns 3.94ns 0 0 0 1.22 KB
#7870 AllCycleSimpleBody netcoreapp3.1 1.39μs 7.93ns 61.4ns 0 0 0 1.2 KB
#7870 AllCycleSimpleBody net472 1.02μs 0.314ns 1.17ns 0.194 0 0 1.23 KB
#7870 AllCycleMoreComplexBody net6.0 7.32μs 34.4ns 133ns 0 0 0 4.72 KB
#7870 AllCycleMoreComplexBody netcoreapp3.1 9.06μs 46.5ns 213ns 0 0 0 4.62 KB
#7870 AllCycleMoreComplexBody net472 7.7μs 10.1ns 39.2ns 0.728 0 0 4.74 KB
#7870 ObjectExtractorSimpleBody net6.0 338ns 1.86ns 11.3ns 0 0 0 280 B
#7870 ObjectExtractorSimpleBody netcoreapp3.1 405ns 2.07ns 9.02ns 0 0 0 272 B
#7870 ObjectExtractorSimpleBody net472 301ns 0.0384ns 0.149ns 0.0439 0 0 281 B
#7870 ObjectExtractorMoreComplexBody net6.0 6.39μs 34.1ns 177ns 0 0 0 3.78 KB
#7870 ObjectExtractorMoreComplexBody netcoreapp3.1 7.82μs 34.4ns 129ns 0 0 0 3.69 KB
#7870 ObjectExtractorMoreComplexBody net472 6.67μs 2.68ns 10.4ns 0.6 0 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7870

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs‑net472 2.16 KB 2.17 KB 13 B 0.60%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 76.6μs 213ns 796ns 0 0 0 32.4 KB
master EncodeArgs netcoreapp3.1 96.3μs 207ns 774ns 0 0 0 32.4 KB
master EncodeArgs net472 112μs 7.66ns 26.5ns 5.03 0 0 32.51 KB
master EncodeLegacyArgs net6.0 145μs 25.7ns 99.6ns 0 0 0 2.15 KB
master EncodeLegacyArgs netcoreapp3.1 197μs 83.5ns 289ns 0 0 0 2.14 KB
master EncodeLegacyArgs net472 264μs 96ns 372ns 0 0 0 2.16 KB
#7870 EncodeArgs net6.0 76.6μs 249ns 931ns 0 0 0 32.4 KB
#7870 EncodeArgs netcoreapp3.1 95.5μs 343ns 1.33μs 0 0 0 32.4 KB
#7870 EncodeArgs net472 110μs 14ns 54.2ns 4.96 0 0 32.51 KB
#7870 EncodeLegacyArgs net6.0 147μs 58.1ns 225ns 0 0 0 2.15 KB
#7870 EncodeLegacyArgs netcoreapp3.1 199μs 212ns 821ns 0 0 0 2.14 KB
#7870 EncodeLegacyArgs net472 271μs 32.4ns 125ns 0 0 0 2.17 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7870

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack‑net6.0 3.5 KB 3.17 KB -336 B -9.59%
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark‑net6.0 5.48 KB 4.86 KB -624 B -11.39%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 457μs 3.08μs 30.6μs 0 0 0 5.48 KB
master RunWafRealisticBenchmark netcoreapp3.1 496μs 4.32μs 42.1μs 0 0 0 4.58 KB
master RunWafRealisticBenchmark net472 503μs 607ns 2.27μs 0 0 0 8.19 KB
master RunWafRealisticBenchmarkWithAttack net6.0 311μs 778ns 2.81μs 0 0 0 3.5 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 352μs 3.19μs 31μs 0 0 0 2.32 KB
master RunWafRealisticBenchmarkWithAttack net472 371μs 373ns 1.29μs 0 0 0 8.19 KB
#7870 RunWafRealisticBenchmark net6.0 426μs 979ns 3.53μs 0 0 0 4.86 KB
#7870 RunWafRealisticBenchmark netcoreapp3.1 479μs 3.72μs 35.7μs 0 0 0 4.58 KB
#7870 RunWafRealisticBenchmark net472 499μs 233ns 840ns 0 0 0 8.19 KB
#7870 RunWafRealisticBenchmarkWithAttack net6.0 311μs 1.2μs 4.34μs 0 0 0 3.17 KB
#7870 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 331μs 1.12μs 3.86μs 0 0 0 2.32 KB
#7870 RunWafRealisticBenchmarkWithAttack net472 371μs 322ns 1.2μs 0 0 0 8.19 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 61.4μs 113ns 422ns 0 0 0 14.52 KB
master SendRequest netcoreapp3.1 71.1μs 70.2ns 253ns 0 0 0 17.42 KB
master SendRequest net472 0.00553ns 0.00212ns 0.00822ns 0 0 0 0 b
#7870 SendRequest net6.0 61.2μs 48.6ns 182ns 0 0 0 14.52 KB
#7870 SendRequest netcoreapp3.1 72.2μs 59.9ns 224ns 0 0 0 17.42 KB
#7870 SendRequest net472 0.000438ns 0.000317ns 0.00119ns 0 0 0 0 b
Benchmarks.Trace.CharSliceBenchmark - Slower ⚠️ More allocations ⚠️

Slower ⚠️ in #7870

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice‑net472 1.257 1,988,650.00 2,498,850.00

Faster 🎉 in #7870

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice‑netcoreapp3.1 1.653 2,817,700.00 1,705,100.00

More allocations ⚠️ in #7870

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net6.0 304 B 976 B 672 B 221.05%

Fewer allocations 🎉 in #7870

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice‑net6.0 976 B 640 B -336 B -34.43%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master OriginalCharSlice net6.0 1.89ms 907ns 3.51μs 0 0 0 640.3 KB
master OriginalCharSlice netcoreapp3.1 3.97ms 1.68μs 6.27μs 0 0 0 640.1 KB
master OriginalCharSlice net472 2.64ms 648ns 2.42μs 0 0 0 647.17 KB
master OptimizedCharSlice net6.0 1.4ms 554ns 2.07μs 0 0 0 976 B
master OptimizedCharSlice netcoreapp3.1 2.82ms 905ns 3.39μs 0 0 0 104 B
master OptimizedCharSlice net472 1.99ms 996ns 3.59μs 0 0 0 8.19 KB
master OptimizedCharSliceWithPool net6.0 1.01ms 347ns 1.3μs 0 0 0 304 B
master OptimizedCharSliceWithPool netcoreapp3.1 2ms 2.03μs 7.88μs 0 0 0 104 B
master OptimizedCharSliceWithPool net472 1.15ms 639ns 2.39μs 0 0 0 8.19 KB
#7870 OriginalCharSlice net6.0 1.9ms 1.2μs 4.64μs 0 0 0 640.64 KB
#7870 OriginalCharSlice netcoreapp3.1 3.95ms 2.16μs 7.49μs 0 0 0 640.1 KB
#7870 OriginalCharSlice net472 2.73ms 1.16μs 4.51μs 0 0 0 647.17 KB
#7870 OptimizedCharSlice net6.0 1.36ms 471ns 1.7μs 0 0 0 640 B
#7870 OptimizedCharSlice netcoreapp3.1 1.71ms 6μs 39.3μs 0 0 0 104 B
#7870 OptimizedCharSlice net472 2.49ms 3.2μs 12.4μs 0 0 0 8.19 KB
#7870 OptimizedCharSliceWithPool net6.0 1ms 452ns 1.69μs 0 0 0 976 B
#7870 OptimizedCharSliceWithPool netcoreapp3.1 1.88ms 1.27μs 4.9μs 0 0 0 104 B
#7870 OptimizedCharSliceWithPool net472 1.14ms 1.33μs 5.14μs 0 0 0 8.19 KB
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #7870

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 1.283 830,691.25 1,065,744.17
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 1.131 625,569.95 707,377.92

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 685μs 1.86μs 7.21μs 0 0 0 41.71 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 627μs 903ns 3.5μs 0 0 0 41.98 KB
master WriteAndFlushEnrichedTraces net472 832μs 1.3μs 4.88μs 8.33 0 0 56.18 KB
#7870 WriteAndFlushEnrichedTraces net6.0 738μs 4.22μs 32.7μs 0 0 0 41.62 KB
#7870 WriteAndFlushEnrichedTraces netcoreapp3.1 708μs 3.57μs 21.1μs 0 0 0 41.93 KB
#7870 WriteAndFlushEnrichedTraces net472 1.06ms 4.62μs 17.9μs 8.33 0 0 56.25 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.93μs 9.98ns 47.9ns 0 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 2.47μs 11.2ns 40.5ns 0 0 0 1.02 KB
master ExecuteNonQuery net472 2.71μs 1.89ns 7.31ns 0.15 0 0 987 B
#7870 ExecuteNonQuery net6.0 1.99μs 2.82ns 10.9ns 0 0 0 1.02 KB
#7870 ExecuteNonQuery netcoreapp3.1 2.74μs 13.3ns 51.3ns 0 0 0 1.02 KB
#7870 ExecuteNonQuery net472 2.71μs 3.04ns 11.4ns 0.148 0 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.76μs 8.03ns 30ns 0 0 0 1.03 KB
master CallElasticsearch netcoreapp3.1 2.23μs 11.7ns 56.2ns 0 0 0 1.03 KB
master CallElasticsearch net472 3.57μs 3.38ns 13.1ns 0.16 0 0 1.04 KB
master CallElasticsearchAsync net6.0 1.79μs 8.33ns 32.3ns 0 0 0 1.01 KB
master CallElasticsearchAsync netcoreapp3.1 2.44μs 8.58ns 33.2ns 0 0 0 1.08 KB
master CallElasticsearchAsync net472 3.71μs 1.19ns 4.6ns 0.165 0 0 1.1 KB
#7870 CallElasticsearch net6.0 1.72μs 8.26ns 32ns 0 0 0 1.03 KB
#7870 CallElasticsearch netcoreapp3.1 2.29μs 8.84ns 34.3ns 0 0 0 1.03 KB
#7870 CallElasticsearch net472 3.54μs 2.13ns 8.24ns 0.157 0 0 1.04 KB
#7870 CallElasticsearchAsync net6.0 1.79μs 8.79ns 35.1ns 0 0 0 1.01 KB
#7870 CallElasticsearchAsync netcoreapp3.1 2.38μs 8.58ns 32.1ns 0 0 0 1.08 KB
#7870 CallElasticsearchAsync net472 3.79μs 3.49ns 13.5ns 0.169 0 0 1.1 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.82μs 5.61ns 21.7ns 0 0 0 952 B
master ExecuteAsync netcoreapp3.1 2.35μs 10.9ns 43.4ns 0 0 0 952 B
master ExecuteAsync net472 2.67μs 3.16ns 12.2ns 0.133 0 0 915 B
#7870 ExecuteAsync net6.0 1.81μs 7.16ns 27.7ns 0 0 0 952 B
#7870 ExecuteAsync netcoreapp3.1 2.36μs 9.4ns 35.2ns 0 0 0 952 B
#7870 ExecuteAsync net472 2.65μs 1.32ns 4.93ns 0.133 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 6.79μs 10ns 38.9ns 0 0 0 2.36 KB
master SendAsync netcoreapp3.1 8.96μs 35ns 135ns 0 0 0 2.9 KB
master SendAsync net472 12.2μs 10.5ns 40.6ns 0.488 0 0 3.18 KB
#7870 SendAsync net6.0 6.8μs 17.6ns 63.5ns 0 0 0 2.36 KB
#7870 SendAsync netcoreapp3.1 8.81μs 38ns 147ns 0 0 0 2.9 KB
#7870 SendAsync net472 12μs 15.1ns 58.6ns 0.481 0 0 3.18 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7870

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 250.62 KB 257.38 KB 6.76 KB 2.70%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net6.0 43.36 KB 43.81 KB 448 B 1.03%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net472 278.53 KB 280.52 KB 1.99 KB 0.72%

Fewer allocations 🎉 in #7870

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1 44.04 KB 42.74 KB -1.3 KB -2.96%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 45μs 249ns 1.41μs 0 0 0 43.36 KB
master StringConcatBenchmark netcoreapp3.1 48.4μs 200ns 720ns 0 0 0 44.04 KB
master StringConcatBenchmark net472 57.5μs 127ns 459ns 0 0 0 57.34 KB
master StringConcatAspectBenchmark net6.0 445μs 2.37μs 12.1μs 0 0 0 250.62 KB
master StringConcatAspectBenchmark netcoreapp3.1 528μs 2.53μs 10.1μs 0 0 0 272.86 KB
master StringConcatAspectBenchmark net472 411μs 2.21μs 12.5μs 0 0 0 278.53 KB
#7870 StringConcatBenchmark net6.0 44.9μs 254ns 1.66μs 0 0 0 43.81 KB
#7870 StringConcatBenchmark netcoreapp3.1 51μs 406ns 3.72μs 0 0 0 42.74 KB
#7870 StringConcatBenchmark net472 56.9μs 128ns 461ns 0 0 0 57.34 KB
#7870 StringConcatAspectBenchmark net6.0 462μs 1.95μs 7.05μs 0 0 0 257.38 KB
#7870 StringConcatAspectBenchmark netcoreapp3.1 528μs 1.91μs 10.7μs 0 0 0 272.75 KB
#7870 StringConcatAspectBenchmark net472 405μs 2.1μs 14.6μs 0 0 0 280.52 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.64μs 13.6ns 67.9ns 0 0 0 1.7 KB
master EnrichedLog netcoreapp3.1 3.56μs 15.7ns 60.6ns 0 0 0 1.7 KB
master EnrichedLog net472 3.82μs 2.9ns 11.2ns 0.245 0 0 1.64 KB
#7870 EnrichedLog net6.0 2.59μs 11.9ns 47.4ns 0 0 0 1.7 KB
#7870 EnrichedLog netcoreapp3.1 3.55μs 18.1ns 81.1ns 0 0 0 1.7 KB
#7870 EnrichedLog net472 3.8μs 3.11ns 12ns 0.246 0 0 1.64 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 124μs 129ns 483ns 0 0 0 4.31 KB
master EnrichedLog netcoreapp3.1 127μs 70.9ns 256ns 0 0 0 4.31 KB
master EnrichedLog net472 168μs 128ns 495ns 0 0 0 4.52 KB
#7870 EnrichedLog net6.0 124μs 62.3ns 216ns 0 0 0 4.31 KB
#7870 EnrichedLog netcoreapp3.1 128μs 166ns 574ns 0 0 0 4.31 KB
#7870 EnrichedLog net472 170μs 513ns 1.92μs 0 0 0 4.52 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.91μs 23.1ns 92.4ns 0 0 0 2.26 KB
master EnrichedLog netcoreapp3.1 6.93μs 26.5ns 103ns 0 0 0 2.26 KB
master EnrichedLog net472 7.38μs 5.92ns 22.9ns 0.297 0 0 2.08 KB
#7870 EnrichedLog net6.0 5.03μs 12.8ns 49.5ns 0 0 0 2.26 KB
#7870 EnrichedLog netcoreapp3.1 6.99μs 29.5ns 114ns 0 0 0 2.26 KB
#7870 EnrichedLog net472 7.84μs 10.6ns 41ns 0.312 0 0 2.08 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.94μs 8.91ns 34.5ns 0 0 0 1.2 KB
master SendReceive netcoreapp3.1 2.54μs 10.8ns 41.9ns 0 0 0 1.2 KB
master SendReceive net472 2.96μs 2.36ns 8.82ns 0.191 0 0 1.2 KB
#7870 SendReceive net6.0 1.93μs 9.19ns 35.6ns 0 0 0 1.2 KB
#7870 SendReceive netcoreapp3.1 2.51μs 12.4ns 52.6ns 0 0 0 1.2 KB
#7870 SendReceive net472 2.96μs 2.75ns 10.6ns 0.191 0 0 1.2 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.29μs 1.1ns 4.11ns 0 0 0 1.58 KB
master EnrichedLog netcoreapp3.1 5.94μs 15.6ns 60.6ns 0 0 0 1.63 KB
master EnrichedLog net472 6.55μs 5.18ns 20.1ns 0.293 0 0 2.03 KB
#7870 EnrichedLog net6.0 4.21μs 15.5ns 60.1ns 0 0 0 1.58 KB
#7870 EnrichedLog netcoreapp3.1 5.8μs 19ns 73.6ns 0 0 0 1.63 KB
#7870 EnrichedLog net472 6.46μs 6.13ns 23.8ns 0.291 0 0 2.03 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 790ns 3.61ns 14.4ns 0 0 0 576 B
master StartFinishSpan netcoreapp3.1 960ns 0.356ns 1.38ns 0 0 0 576 B
master StartFinishSpan net472 917ns 0.121ns 0.471ns 0.0916 0 0 578 B
master StartFinishScope net6.0 937ns 0.434ns 1.68ns 0 0 0 696 B
master StartFinishScope netcoreapp3.1 1.13μs 5.83ns 26.7ns 0 0 0 696 B
master StartFinishScope net472 1.1μs 0.186ns 0.721ns 0.0993 0 0 658 B
#7870 StartFinishSpan net6.0 784ns 1.75ns 6.78ns 0 0 0 576 B
#7870 StartFinishSpan netcoreapp3.1 958ns 5.17ns 27.9ns 0 0 0 576 B
#7870 StartFinishSpan net472 898ns 0.377ns 1.46ns 0.0899 0 0 578 B
#7870 StartFinishScope net6.0 953ns 1.26ns 4.87ns 0 0 0 696 B
#7870 StartFinishScope netcoreapp3.1 1.16μs 0.914ns 3.54ns 0 0 0 696 B
#7870 StartFinishScope net472 1.1μs 0.26ns 1.01ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 1.08μs 1.43ns 5.15ns 0 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 1.38μs 6.5ns 25.2ns 0 0 0 696 B
master RunOnMethodBegin net472 1.44μs 1.51ns 5.85ns 0.101 0 0 658 B
#7870 RunOnMethodBegin net6.0 1.08μs 5.07ns 20.3ns 0 0 0 696 B
#7870 RunOnMethodBegin netcoreapp3.1 1.4μs 6.42ns 25.7ns 0 0 0 696 B
#7870 RunOnMethodBegin net472 1.44μs 2.19ns 8.5ns 0.1 0 0 658 B

@NachoEchevarria NachoEchevarria marked this pull request as ready for review November 27, 2025 14:10
@NachoEchevarria NachoEchevarria requested review from a team as code owners November 27, 2025 14:11
andrewlock
andrewlock approved these changes Nov 27, 2025
View reviewed changes
Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@NachoEchevarria NachoEchevarria merged commit e4ff7f9 into master Nov 28, 2025
151 checks passed
@NachoEchevarria NachoEchevarria deleted the nacho/downloadStepArtifactsLogs branch November 28, 2025 11:24
@github-actions github-actions bot added this to the vNext-v3 milestone Nov 28, 2025
@bouwkast bouwkast added the area:tests unit tests, integration tests label Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewlock andrewlock andrewlock approved these changes

Assignees

No one assigned

Labels

area:tests unit tests, integration tests

Projects

None yet

Milestone

3.33.0

Development

Successfully merging this pull request may close these issues.

4 participants

@NachoEchevarria @andrewlock @bouwkast