-Ddd.integration.throwables.enabled=false not working since 1.19

[ghostdogpr]

We used this setting -Ddd.integration.throwables.enabled=false to disable exception profiling.
It worked well with the agent version 1.18 but from 1.19 exceptions are being profiled despite the setting.

1.18:

1.19:

[richardstartin]

Thanks for the report, we'll get this fixed ASAP.

[richardstartin]

Fixed in 1.21.0

[github-actions]

🤖 This issue has been addressed in the latest release. See full details in the Release Notes.

[richardstartin]

hi @ghostdogpr could you share some details about why you disable exception profiling?

[ghostdogpr]

@richardstartin I disabled it because it's recommended in Datadog docs 😆 https://docs.datadoghq.com/profiler/profiler_troubleshooting/java/#exceptions-overwhelming-the-profiler
We are using a library (ZIO) that relies on exceptions for control flow so it generates a LOT of exceptions (they have no stack trace so performance is good). I haven't observed problems in production with exception profiling but I did observe slowdowns locally with another profiler (YourKit), so I prefered to be safe and disable it with Datadog.

[richardstartin]

In 1.23.0 we will avoid instrumenting throwable types like ControlThrowable which should hopefully increase SNR of exception profiling for Scala applications.