Bump spotbugs gradle plugin to 6.4.2 #9748
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…internal-api Also this forces JDK 11 to be the minimum.
# Conflicts: # communication/src/main/java/datadog/communication/ddagent/SharedCommunicationObjects.java # utils/test-utils/src/main/groovy/datadog/trace/test/util/DDSpecification.groovy
bric3
added
tag: do not merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
This PR bumps spotbugs gradle plugin to the most recent version 6.4.2 to this day (from 5.0.14).
And require a JDK 11 minimum to run.
Important
This version of spotbugs has new rules, better detection engine that requires to change so of the warnings ignores, or fix some code.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]