Add option to JDBC instrumentation to always append DBM comment #9798

na-ji · 2025-10-17T15:53:26Z

What Does This Do

This PR adds a new option to the JDBC instrumentation. This option allows to always append the comment injected when DBM trace propagation is enabled.

Motivation

This is useful to add supports to GCP’s Query Insights on Cloud SQL. When query insights is enabled, it is prepending a comment to all the queries executed. If another comment exists, it can't recognize its own comment.

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any useful labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: DBMON-5791 APMS-17494

...ent/instrumentation/jdbc/src/main/java/datadog/trace/instrumentation/jdbc/JDBCDecorator.java

...src/main/java/datadog/trace/instrumentation/jdbc/DBMCompatibleConnectionInstrumentation.java

mhlidd

Changes look good to me, just a small comment about documentation.

internal-api/src/main/java/datadog/trace/api/Config.java

datadog-official · 2025-10-17T20:46:22Z

🎯 Code Coverage
• Patch Coverage: 0.00%
• Total Coverage: 59.67% (-0.03%)

View detailed report

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: cb11be8 | Docs | Was this helpful? Give us feedback!}

pr-commenter · 2025-10-17T21:02:05Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	naji.astier/DBMON-5791-dbm-append-comment-config
git_commit_date	1761659643	1761663440
git_commit_sha	`9fb4984`	`cb11be8`
release_version	1.55.0-SNAPSHOT~9fb4984267	1.55.0-SNAPSHOT~cb11be8e16

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1761665325	1761665325
ci_job_id	1202238816	1202238816
ci_pipeline_id	80503060	80503060
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-7azxisj3 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-7azxisj3 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 12 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~cb11be8e16, baseline=1.55.0-SNAPSHOT~9fb4984267

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.034 s) : 0, 1033636
Total [baseline] (10.845 s) : 0, 10845287
Agent [candidate] (1.033 s) : 0, 1032986
Total [candidate] (10.872 s) : 0, 10872238
section appsec
Agent [baseline] (1.206 s) : 0, 1206043
Total [baseline] (11.01 s) : 0, 11009833
Agent [candidate] (1.212 s) : 0, 1211736
Total [candidate] (10.944 s) : 0, 10943918
section iast
Agent [baseline] (1.187 s) : 0, 1187140
Total [baseline] (11.274 s) : 0, 11274076
Agent [candidate] (1.169 s) : 0, 1169392
Total [candidate] (11.232 s) : 0, 11232038
section profiling
Agent [baseline] (1.179 s) : 0, 1178581
Total [baseline] (10.988 s) : 0, 10987712
Agent [candidate] (1.181 s) : 0, 1180735
Total [candidate] (10.954 s) : 0, 10954245

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.034 s	-
Agent	appsec	1.206 s	172.407 ms (16.7%)
Agent	iast	1.187 s	153.504 ms (14.9%)
Agent	profiling	1.179 s	144.945 ms (14.0%)
Total	tracing	10.845 s	-
Total	appsec	11.01 s	164.545 ms (1.5%)
Total	iast	11.274 s	428.789 ms (4.0%)
Total	profiling	10.988 s	142.425 ms (1.3%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.033 s	-
Agent	appsec	1.212 s	178.75 ms (17.3%)
Agent	iast	1.169 s	136.406 ms (13.2%)
Agent	profiling	1.181 s	147.749 ms (14.3%)
Total	tracing	10.872 s	-
Total	appsec	10.944 s	71.681 ms (0.7%)
Total	iast	11.232 s	359.801 ms (3.3%)
Total	profiling	10.954 s	82.008 ms (0.8%)

gantt
    title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~cb11be8e16, baseline=1.55.0-SNAPSHOT~9fb4984267

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.472 ms) : 0, 1472
crashtracking [candidate] (1.456 ms) : 0, 1456
BytebuddyAgent [baseline] (704.918 ms) : 0, 704918
BytebuddyAgent [candidate] (702.991 ms) : 0, 702991
GlobalTracer [baseline] (245.653 ms) : 0, 245653
GlobalTracer [candidate] (246.282 ms) : 0, 246282
AppSec [baseline] (32.42 ms) : 0, 32420
AppSec [candidate] (32.557 ms) : 0, 32557
Debugger [baseline] (6.417 ms) : 0, 6417
Debugger [candidate] (6.454 ms) : 0, 6454
Remote Config [baseline] (679.893 µs) : 0, 680
Remote Config [candidate] (678.8 µs) : 0, 679
Telemetry [baseline] (15.187 ms) : 0, 15187
Telemetry [candidate] (14.655 ms) : 0, 14655
Flare Poller [baseline] (5.629 ms) : 0, 5629
Flare Poller [candidate] (6.583 ms) : 0, 6583
section appsec
crashtracking [baseline] (1.472 ms) : 0, 1472
crashtracking [candidate] (1.487 ms) : 0, 1487
BytebuddyAgent [baseline] (728.54 ms) : 0, 728540
BytebuddyAgent [candidate] (731.259 ms) : 0, 731259
GlobalTracer [baseline] (236.491 ms) : 0, 236491
GlobalTracer [candidate] (238.119 ms) : 0, 238119
IAST [baseline] (25.053 ms) : 0, 25053
IAST [candidate] (25.306 ms) : 0, 25306
AppSec [baseline] (174.472 ms) : 0, 174472
AppSec [candidate] (175.28 ms) : 0, 175280
Debugger [baseline] (5.909 ms) : 0, 5909
Debugger [candidate] (5.956 ms) : 0, 5956
Remote Config [baseline] (634.346 µs) : 0, 634
Remote Config [candidate] (628.451 µs) : 0, 628
Telemetry [baseline] (8.435 ms) : 0, 8435
Telemetry [candidate] (8.514 ms) : 0, 8514
Flare Poller [baseline] (3.848 ms) : 0, 3848
Flare Poller [candidate] (3.952 ms) : 0, 3952
section iast
crashtracking [baseline] (1.499 ms) : 0, 1499
crashtracking [candidate] (1.479 ms) : 0, 1479
BytebuddyAgent [baseline] (843.496 ms) : 0, 843496
BytebuddyAgent [candidate] (831.031 ms) : 0, 831031
GlobalTracer [baseline] (237.743 ms) : 0, 237743
GlobalTracer [candidate] (234.034 ms) : 0, 234034
IAST [baseline] (33.311 ms) : 0, 33311
IAST [candidate] (31.789 ms) : 0, 31789
AppSec [baseline] (29.429 ms) : 0, 29429
AppSec [candidate] (30.094 ms) : 0, 30094
Debugger [baseline] (6.21 ms) : 0, 6210
Debugger [candidate] (6.132 ms) : 0, 6132
Remote Config [baseline] (625.712 µs) : 0, 626
Remote Config [candidate] (594.676 µs) : 0, 595
Telemetry [baseline] (8.676 ms) : 0, 8676
Telemetry [candidate] (8.511 ms) : 0, 8511
Flare Poller [baseline] (4.158 ms) : 0, 4158
Flare Poller [candidate] (4.115 ms) : 0, 4115
section profiling
crashtracking [baseline] (1.479 ms) : 0, 1479
crashtracking [candidate] (1.452 ms) : 0, 1452
BytebuddyAgent [baseline] (729.52 ms) : 0, 729520
BytebuddyAgent [candidate] (732.124 ms) : 0, 732124
GlobalTracer [baseline] (221.978 ms) : 0, 221978
GlobalTracer [candidate] (221.083 ms) : 0, 221083
AppSec [baseline] (32.354 ms) : 0, 32354
AppSec [candidate] (32.531 ms) : 0, 32531
Debugger [baseline] (13.048 ms) : 0, 13048
Debugger [candidate] (11.466 ms) : 0, 11466
Remote Config [baseline] (717.789 µs) : 0, 718
Remote Config [candidate] (2.097 ms) : 0, 2097
Telemetry [baseline] (9.84 ms) : 0, 9840
Telemetry [candidate] (9.95 ms) : 0, 9950
Flare Poller [baseline] (4.147 ms) : 0, 4147
Flare Poller [candidate] (4.094 ms) : 0, 4094
ProfilingAgent [baseline] (109.996 ms) : 0, 109996
ProfilingAgent [candidate] (110.259 ms) : 0, 110259
Profiling [baseline] (110.643 ms) : 0, 110643
Profiling [candidate] (110.895 ms) : 0, 110895

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~cb11be8e16, baseline=1.55.0-SNAPSHOT~9fb4984267

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.034 s) : 0, 1034366
Total [baseline] (8.704 s) : 0, 8704218
Agent [candidate] (1.04 s) : 0, 1039546
Total [candidate] (8.718 s) : 0, 8717863
section iast
Agent [baseline] (1.165 s) : 0, 1164510
Total [baseline] (9.391 s) : 0, 9391293
Agent [candidate] (1.163 s) : 0, 1162579
Total [candidate] (9.353 s) : 0, 9352842

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.034 s	-
Agent	iast	1.165 s	130.144 ms (12.6%)
Total	tracing	8.704 s	-
Total	iast	9.391 s	687.074 ms (7.9%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.04 s	-
Agent	iast	1.163 s	123.034 ms (11.8%)
Total	tracing	8.718 s	-
Total	iast	9.353 s	634.978 ms (7.3%)

gantt
    title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~cb11be8e16, baseline=1.55.0-SNAPSHOT~9fb4984267

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.472 ms) : 0, 1472
crashtracking [candidate] (1.471 ms) : 0, 1471
BytebuddyAgent [baseline] (705.396 ms) : 0, 705396
BytebuddyAgent [candidate] (708.77 ms) : 0, 708770
GlobalTracer [baseline] (245.862 ms) : 0, 245862
GlobalTracer [candidate] (247.17 ms) : 0, 247170
AppSec [baseline] (32.245 ms) : 0, 32245
AppSec [candidate] (32.711 ms) : 0, 32711
Debugger [baseline] (6.414 ms) : 0, 6414
Debugger [candidate] (6.505 ms) : 0, 6505
Remote Config [baseline] (678.022 µs) : 0, 678
Remote Config [candidate] (686.799 µs) : 0, 687
Telemetry [baseline] (15.342 ms) : 0, 15342
Telemetry [candidate] (13.63 ms) : 0, 13630
Flare Poller [baseline] (5.741 ms) : 0, 5741
Flare Poller [candidate] (7.296 ms) : 0, 7296
section iast
crashtracking [baseline] (1.473 ms) : 0, 1473
crashtracking [candidate] (1.473 ms) : 0, 1473
BytebuddyAgent [baseline] (826.298 ms) : 0, 826298
BytebuddyAgent [candidate] (825.149 ms) : 0, 825149
GlobalTracer [baseline] (234.62 ms) : 0, 234620
GlobalTracer [candidate] (233.964 ms) : 0, 233964
IAST [baseline] (31.749 ms) : 0, 31749
IAST [candidate] (32.812 ms) : 0, 32812
AppSec [baseline] (29.758 ms) : 0, 29758
AppSec [candidate] (28.853 ms) : 0, 28853
Debugger [baseline] (6.039 ms) : 0, 6039
Debugger [candidate] (6.035 ms) : 0, 6035
Remote Config [baseline] (595.449 µs) : 0, 595
Remote Config [candidate] (594.522 µs) : 0, 595
Telemetry [baseline] (8.397 ms) : 0, 8397
Telemetry [candidate] (8.376 ms) : 0, 8376
Flare Poller [baseline] (4.146 ms) : 0, 4146
Flare Poller [candidate] (4.108 ms) : 0, 4108

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	naji.astier/DBMON-5791-dbm-append-comment-config
git_commit_date	1761659643	1761663440
git_commit_sha	`9fb4984`	`cb11be8`
release_version	1.55.0-SNAPSHOT~9fb4984267	1.55.0-SNAPSHOT~cb11be8e16

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1761665868	1761665868
ci_job_id	1202238817	1202238817
ci_pipeline_id	80503060	80503060
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-997zwml3 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-997zwml3 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 2 performance improvements and 2 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:insecure-bank:tracing:high_load	better [-92.534µs; -57.823µs] or [-4.954%; -3.096%]	unstable [-201.620op/s; +397.370op/s] or [-8.371%; +16.498%]	1.793ms	2506.500op/s	1.868ms	2408.625op/s
scenario:load:insecure-bank:iast_GLOBAL:high_load	worse [+110.436µs; +239.082µs] or [+3.155%; +6.831%]	unstable [-203.965op/s; +82.278op/s] or [-15.578%; +6.284%]	3.675ms	1248.469op/s	3.500ms	1309.312op/s
scenario:load:petclinic:no_agent:high_load	worse [+736.717µs; +1145.198µs] or [+4.074%; +6.333%]	unstable [-39.640op/s; +14.265op/s] or [-15.364%; +5.529%]	19.025ms	245.312op/s	18.084ms	258.000op/s
scenario:load:petclinic:appsec:high_load	better [-1.366ms; -0.950ms] or [-6.987%; -4.859%]	unstable [-10.174op/s; +39.924op/s] or [-4.261%; +16.722%]	18.396ms	253.625op/s	19.554ms	238.750op/s

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~cb11be8e16, baseline=1.55.0-SNAPSHOT~9fb4984267
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.216 ms) : 1204, 1228
.   : milestone, 1216,
iast (3.286 ms) : 3244, 3327
.   : milestone, 3286,
iast_FULL (5.694 ms) : 5638, 5750
.   : milestone, 5694,
iast_GLOBAL (3.5 ms) : 3450, 3551
.   : milestone, 3500,
profiling (2.028 ms) : 2010, 2046
.   : milestone, 2028,
tracing (1.868 ms) : 1851, 1885
.   : milestone, 1868,
section candidate
no_agent (1.217 ms) : 1205, 1229
.   : milestone, 1217,
iast (3.183 ms) : 3143, 3223
.   : milestone, 3183,
iast_FULL (5.684 ms) : 5628, 5739
.   : milestone, 5684,
iast_GLOBAL (3.675 ms) : 3607, 3743
.   : milestone, 3675,
profiling (2.085 ms) : 2067, 2104
.   : milestone, 2085,
tracing (1.793 ms) : 1777, 1808
.   : milestone, 1793,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.216 ms [1.204 ms, 1.228 ms]	-
iast	3.286 ms [3.244 ms, 3.327 ms]	2.07 ms (170.3%)
iast_FULL	5.694 ms [5.638 ms, 5.75 ms]	4.478 ms (368.4%)
iast_GLOBAL	3.5 ms [3.45 ms, 3.551 ms]	2.284 ms (187.9%)
profiling	2.028 ms [2.01 ms, 2.046 ms]	812.62 µs (66.8%)
tracing	1.868 ms [1.851 ms, 1.885 ms]	652.138 µs (53.6%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.217 ms [1.205 ms, 1.229 ms]	-
iast	3.183 ms [3.143 ms, 3.223 ms]	1.966 ms (161.5%)
iast_FULL	5.684 ms [5.628 ms, 5.739 ms]	4.467 ms (367.0%)
iast_GLOBAL	3.675 ms [3.607 ms, 3.743 ms]	2.458 ms (202.0%)
profiling	2.085 ms [2.067 ms, 2.104 ms]	868.148 µs (71.3%)
tracing	1.793 ms [1.777 ms, 1.808 ms]	575.635 µs (47.3%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~cb11be8e16, baseline=1.55.0-SNAPSHOT~9fb4984267
    dateFormat X
    axisFormat %s
section baseline
no_agent (18.084 ms) : 17899, 18270
.   : milestone, 18084,
appsec (19.554 ms) : 19351, 19757
.   : milestone, 19554,
code_origins (19.584 ms) : 19386, 19782
.   : milestone, 19584,
iast (18.857 ms) : 18664, 19049
.   : milestone, 18857,
profiling (19.083 ms) : 18890, 19275
.   : milestone, 19083,
tracing (19.422 ms) : 19230, 19615
.   : milestone, 19422,
section candidate
no_agent (19.025 ms) : 18831, 19220
.   : milestone, 19025,
appsec (18.396 ms) : 18212, 18579
.   : milestone, 18396,
code_origins (19.669 ms) : 19476, 19862
.   : milestone, 19669,
iast (18.597 ms) : 18408, 18787
.   : milestone, 18597,
profiling (19.481 ms) : 19284, 19678
.   : milestone, 19481,
tracing (19.53 ms) : 19336, 19723
.   : milestone, 19530,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	18.084 ms [17.899 ms, 18.27 ms]	-
appsec	19.554 ms [19.351 ms, 19.757 ms]	1.47 ms (8.1%)
code_origins	19.584 ms [19.386 ms, 19.782 ms]	1.5 ms (8.3%)
iast	18.857 ms [18.664 ms, 19.049 ms]	772.238 µs (4.3%)
profiling	19.083 ms [18.89 ms, 19.275 ms]	998.211 µs (5.5%)
tracing	19.422 ms [19.23 ms, 19.615 ms]	1.338 ms (7.4%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	19.025 ms [18.831 ms, 19.22 ms]	-
appsec	18.396 ms [18.212 ms, 18.579 ms]	-629.488 µs (-3.3%)
code_origins	19.669 ms [19.476 ms, 19.862 ms]	643.59 µs (3.4%)
iast	18.597 ms [18.408 ms, 18.787 ms]	-427.948 µs (-2.2%)
profiling	19.481 ms [19.284 ms, 19.678 ms]	455.508 µs (2.4%)
tracing	19.53 ms [19.336 ms, 19.723 ms]	504.382 µs (2.7%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	naji.astier/DBMON-5791-dbm-append-comment-config
git_commit_date	1761659643	1761663440
git_commit_sha	`9fb4984`	`cb11be8`
release_version	1.55.0-SNAPSHOT~9fb4984267	1.55.0-SNAPSHOT~cb11be8e16

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1761665479	1761665479
ci_job_id	1202238820	1202238820
ci_pipeline_id	80503060	80503060
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-1-jraqo0qr 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-1-jraqo0qr 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.

scenario	Δ mean execution_time	candidate mean execution_time	baseline mean execution_time
scenario:dacapo:tomcat:appsec	better [-1.320ms; -0.987ms] or [-36.168%; -27.056%]	2.495ms	3.649ms

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~cb11be8e16, baseline=1.55.0-SNAPSHOT~9fb4984267
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.013 s) : 15013000, 15013000
.   : milestone, 15013000,
appsec (14.871 s) : 14871000, 14871000
.   : milestone, 14871000,
iast (18.53 s) : 18530000, 18530000
.   : milestone, 18530000,
iast_GLOBAL (17.923 s) : 17923000, 17923000
.   : milestone, 17923000,
profiling (15.499 s) : 15499000, 15499000
.   : milestone, 15499000,
tracing (15.265 s) : 15265000, 15265000
.   : milestone, 15265000,
section candidate
no_agent (14.994 s) : 14994000, 14994000
.   : milestone, 14994000,
appsec (14.847 s) : 14847000, 14847000
.   : milestone, 14847000,
iast (18.523 s) : 18523000, 18523000
.   : milestone, 18523000,
iast_GLOBAL (18.043 s) : 18043000, 18043000
.   : milestone, 18043000,
profiling (15.143 s) : 15143000, 15143000
.   : milestone, 15143000,
tracing (15.133 s) : 15133000, 15133000
.   : milestone, 15133000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.013 s [15.013 s, 15.013 s]	-
appsec	14.871 s [14.871 s, 14.871 s]	-142.0 ms (-0.9%)
iast	18.53 s [18.53 s, 18.53 s]	3.517 s (23.4%)
iast_GLOBAL	17.923 s [17.923 s, 17.923 s]	2.91 s (19.4%)
profiling	15.499 s [15.499 s, 15.499 s]	486.0 ms (3.2%)
tracing	15.265 s [15.265 s, 15.265 s]	252.0 ms (1.7%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.994 s [14.994 s, 14.994 s]	-
appsec	14.847 s [14.847 s, 14.847 s]	-147.0 ms (-1.0%)
iast	18.523 s [18.523 s, 18.523 s]	3.529 s (23.5%)
iast_GLOBAL	18.043 s [18.043 s, 18.043 s]	3.049 s (20.3%)
profiling	15.143 s [15.143 s, 15.143 s]	149.0 ms (1.0%)
tracing	15.133 s [15.133 s, 15.133 s]	139.0 ms (0.9%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~cb11be8e16, baseline=1.55.0-SNAPSHOT~9fb4984267
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.473 ms) : 1462, 1485
.   : milestone, 1473,
appsec (3.649 ms) : 3437, 3861
.   : milestone, 3649,
iast (2.208 ms) : 2145, 2271
.   : milestone, 2208,
iast_GLOBAL (2.248 ms) : 2184, 2311
.   : milestone, 2248,
profiling (2.046 ms) : 1995, 2097
.   : milestone, 2046,
tracing (2.016 ms) : 1967, 2065
.   : milestone, 2016,
section candidate
no_agent (1.473 ms) : 1462, 1485
.   : milestone, 1473,
appsec (2.495 ms) : 2442, 2549
.   : milestone, 2495,
iast (2.206 ms) : 2142, 2269
.   : milestone, 2206,
iast_GLOBAL (2.247 ms) : 2183, 2311
.   : milestone, 2247,
profiling (2.057 ms) : 2005, 2109
.   : milestone, 2057,
tracing (2.023 ms) : 1973, 2072
.   : milestone, 2023,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.473 ms [1.462 ms, 1.485 ms]	-
appsec	3.649 ms [3.437 ms, 3.861 ms]	2.176 ms (147.7%)
iast	2.208 ms [2.145 ms, 2.271 ms]	734.649 µs (49.9%)
iast_GLOBAL	2.248 ms [2.184 ms, 2.311 ms]	774.393 µs (52.6%)
profiling	2.046 ms [1.995 ms, 2.097 ms]	572.991 µs (38.9%)
tracing	2.016 ms [1.967 ms, 2.065 ms]	542.677 µs (36.8%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.473 ms [1.462 ms, 1.485 ms]	-
appsec	2.495 ms [2.442 ms, 2.549 ms]	1.022 ms (69.4%)
iast	2.206 ms [2.142 ms, 2.269 ms]	732.396 µs (49.7%)
iast_GLOBAL	2.247 ms [2.183 ms, 2.311 ms]	773.692 µs (52.5%)
profiling	2.057 ms [2.005 ms, 2.109 ms]	583.939 µs (39.6%)
tracing	2.023 ms [1.973 ms, 2.072 ms]	549.389 µs (37.3%)

dougqh

Overall, I'm fine with the change as is. The optimizations would be nice, but I don't think they are essential.

na-ji · 2025-10-28T14:33:12Z

@dougqh @mhlidd the check-big-regressions check is currently broken, and it seems to not be related to my PR. Should I ignore it?
Also, should I be the one to add the new config to the config registry?

mhlidd · 2025-10-28T14:48:36Z

@dougqh @mhlidd the check-big-regressions check is currently broken, and it seems to not be related to my PR. Should I ignore it?

This has been flaky for a while :/, rebasing with master should fix it.

Also, should I be the one to add the new config to the config registry?

Yes! The goal is for devs to document new configs that are added as you have the most information regarding it.

DBMON-5791

na-ji self-assigned this Oct 17, 2025

PerfectSlayer changed the title ~~[DBMON-5791] Add option to JDBC instrumentation to always append DBM comment~~ Add option to JDBC instrumentation to always append DBM comment Oct 17, 2025

na-ji added comp: database Database Monitoring inst: jdbc JDBC instrumentation type: enhancement Enhancements and improvements labels Oct 17, 2025

na-ji marked this pull request as ready for review October 17, 2025 19:36

na-ji requested review from a team as code owners October 17, 2025 19:36

na-ji requested a review from manuel-alvarez-alvarez October 17, 2025 19:36

dougqh reviewed Oct 17, 2025

View reviewed changes

...ent/instrumentation/jdbc/src/main/java/datadog/trace/instrumentation/jdbc/JDBCDecorator.java Outdated Show resolved Hide resolved

dougqh reviewed Oct 17, 2025

View reviewed changes

...src/main/java/datadog/trace/instrumentation/jdbc/DBMCompatibleConnectionInstrumentation.java Outdated Show resolved Hide resolved

mhlidd reviewed Oct 17, 2025

View reviewed changes

internal-api/src/main/java/datadog/trace/api/Config.java Show resolved Hide resolved

na-ji requested a review from a team as a code owner October 17, 2025 20:26

na-ji requested review from dougqh and removed request for a team October 17, 2025 20:26

dougqh approved these changes Oct 21, 2025

View reviewed changes

na-ji force-pushed the naji.astier/DBMON-5791-dbm-append-comment-config branch from 1ef5195 to 4914d8a Compare October 28, 2025 10:30

na-ji requested a review from mhlidd October 28, 2025 10:42

na-ji force-pushed the naji.astier/DBMON-5791-dbm-append-comment-config branch from 39e9ee9 to 3b66f40 Compare October 28, 2025 10:54

mhlidd approved these changes Oct 28, 2025

View reviewed changes

na-ji added 6 commits October 28, 2025 15:57

Add option to JDBC instrumentation to always append DBM comment

39357e4

DBMON-5791

document the newly added DBM environment variable

3f92c00

flip order of comment append condition in JDBC instrumentation

0858e6a

use static final variable to decide if we should append SQL comment

2be41a7

reformat code to be spotless

085fd75

fix typo in the newly added environment variable

cb11be8

na-ji force-pushed the naji.astier/DBMON-5791-dbm-append-comment-config branch from 74eec2e to cb11be8 Compare October 28, 2025 14:57

na-ji merged commit 29ed9f5 into master Oct 28, 2025
539 checks passed

na-ji deleted the naji.astier/DBMON-5791-dbm-append-comment-config branch October 28, 2025 16:43

github-actions bot added this to the 1.55.0 milestone Oct 28, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Add option to JDBC instrumentation to always append DBM comment #9798

Add option to JDBC instrumentation to always append DBM comment #9798

Uh oh!

na-ji commented Oct 17, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

mhlidd left a comment

Uh oh!

Uh oh!

datadog-official bot commented Oct 17, 2025 •

edited by datadog-datadog-prod-us1 bot

Loading

Uh oh!

pr-commenter bot commented Oct 17, 2025 •

edited

Loading

Uh oh!

dougqh left a comment

Uh oh!

na-ji commented Oct 28, 2025

Uh oh!

mhlidd commented Oct 28, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Add option to JDBC instrumentation to always append DBM comment #9798

Add option to JDBC instrumentation to always append DBM comment #9798

Uh oh!

Conversation

na-ji commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

Uh oh!

Uh oh!

mhlidd left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

datadog-official bot commented Oct 17, 2025 • edited by datadog-datadog-prod-us1 bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pr-commenter bot commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

dougqh left a comment

Choose a reason for hiding this comment

Uh oh!

na-ji commented Oct 28, 2025

Uh oh!

mhlidd commented Oct 28, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

na-ji commented Oct 17, 2025 •

edited

Loading

datadog-official bot commented Oct 17, 2025 •

edited by datadog-datadog-prod-us1 bot

Loading

pr-commenter bot commented Oct 17, 2025 •

edited

Loading