-
Notifications
You must be signed in to change notification settings - Fork 316
Use dd-instrument-java's embedded copy of ASM #9916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🎯 Code Coverage 🔗 Commit SHA: 6171acd | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
1780419 to
5e35825
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 12 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.56.0-SNAPSHOT~6171acdd37, baseline=1.56.0-SNAPSHOT~4fb1b2e325
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.046 s) : 0, 1046323
Total [baseline] (10.694 s) : 0, 10693887
Agent [candidate] (1.053 s) : 0, 1053145
Total [candidate] (10.599 s) : 0, 10599367
section appsec
Agent [baseline] (1.222 s) : 0, 1222424
Total [baseline] (10.842 s) : 0, 10842461
Agent [candidate] (1.221 s) : 0, 1220504
Total [candidate] (10.898 s) : 0, 10897596
section iast
Agent [baseline] (1.198 s) : 0, 1197646
Total [baseline] (11.249 s) : 0, 11249409
Agent [candidate] (1.189 s) : 0, 1189408
Total [candidate] (11.191 s) : 0, 11190530
section profiling
Agent [baseline] (1.201 s) : 0, 1201268
Total [baseline] (10.973 s) : 0, 10972676
Agent [candidate] (1.194 s) : 0, 1193552
Total [candidate] (10.911 s) : 0, 10911252
gantt
title petclinic - break down per module: candidate=1.56.0-SNAPSHOT~6171acdd37, baseline=1.56.0-SNAPSHOT~4fb1b2e325
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.434 ms) : 0, 1434
crashtracking [candidate] (1.453 ms) : 0, 1453
BytebuddyAgent [baseline] (704.343 ms) : 0, 704343
BytebuddyAgent [candidate] (709.905 ms) : 0, 709905
GlobalTracer [baseline] (245.713 ms) : 0, 245713
GlobalTracer [candidate] (247.328 ms) : 0, 247328
AppSec [baseline] (32.358 ms) : 0, 32358
AppSec [candidate] (32.278 ms) : 0, 32278
Debugger [baseline] (6.353 ms) : 0, 6353
Debugger [candidate] (6.364 ms) : 0, 6364
Remote Config [baseline] (699.332 µs) : 0, 699
Remote Config [candidate] (712.814 µs) : 0, 713
Telemetry [baseline] (12.067 ms) : 0, 12067
Telemetry [candidate] (12.952 ms) : 0, 12952
Flare Poller [baseline] (8.733 ms) : 0, 8733
Flare Poller [candidate] (7.377 ms) : 0, 7377
section appsec
crashtracking [baseline] (1.45 ms) : 0, 1450
crashtracking [candidate] (1.448 ms) : 0, 1448
BytebuddyAgent [baseline] (729.534 ms) : 0, 729534
BytebuddyAgent [candidate] (728.543 ms) : 0, 728543
GlobalTracer [baseline] (237.652 ms) : 0, 237652
GlobalTracer [candidate] (237.587 ms) : 0, 237587
AppSec [baseline] (174.817 ms) : 0, 174817
AppSec [candidate] (174.286 ms) : 0, 174286
Debugger [baseline] (6.068 ms) : 0, 6068
Debugger [candidate] (5.975 ms) : 0, 5975
Remote Config [baseline] (647.3 µs) : 0, 647
Remote Config [candidate] (640.256 µs) : 0, 640
Telemetry [baseline] (8.555 ms) : 0, 8555
Telemetry [candidate] (8.521 ms) : 0, 8521
Flare Poller [baseline] (3.988 ms) : 0, 3988
Flare Poller [candidate] (3.95 ms) : 0, 3950
IAST [baseline] (24.864 ms) : 0, 24864
IAST [candidate] (24.784 ms) : 0, 24784
section iast
crashtracking [baseline] (1.481 ms) : 0, 1481
crashtracking [candidate] (1.459 ms) : 0, 1459
BytebuddyAgent [baseline] (842.321 ms) : 0, 842321
BytebuddyAgent [candidate] (836.002 ms) : 0, 836002
GlobalTracer [baseline] (237.22 ms) : 0, 237220
GlobalTracer [candidate] (236.091 ms) : 0, 236091
AppSec [baseline] (27.512 ms) : 0, 27512
AppSec [candidate] (29.87 ms) : 0, 29870
Debugger [baseline] (6.08 ms) : 0, 6080
Debugger [candidate] (6.116 ms) : 0, 6116
Remote Config [baseline] (603.961 µs) : 0, 604
Remote Config [candidate] (605.743 µs) : 0, 606
Telemetry [baseline] (8.539 ms) : 0, 8539
Telemetry [candidate] (8.599 ms) : 0, 8599
Flare Poller [baseline] (4.191 ms) : 0, 4191
Flare Poller [candidate] (4.18 ms) : 0, 4180
IAST [baseline] (34.652 ms) : 0, 34652
IAST [candidate] (31.639 ms) : 0, 31639
section profiling
ProfilingAgent [baseline] (110.833 ms) : 0, 110833
ProfilingAgent [candidate] (111.148 ms) : 0, 111148
crashtracking [baseline] (1.445 ms) : 0, 1445
crashtracking [candidate] (1.424 ms) : 0, 1424
BytebuddyAgent [baseline] (735.38 ms) : 0, 735380
BytebuddyAgent [candidate] (729.535 ms) : 0, 729535
GlobalTracer [baseline] (223.231 ms) : 0, 223231
GlobalTracer [candidate] (221.967 ms) : 0, 221967
AppSec [baseline] (33.194 ms) : 0, 33194
AppSec [candidate] (32.094 ms) : 0, 32094
Debugger [baseline] (9.851 ms) : 0, 9851
Debugger [candidate] (9.139 ms) : 0, 9139
Remote Config [baseline] (679.952 µs) : 0, 680
Remote Config [candidate] (659.966 µs) : 0, 660
Telemetry [baseline] (12.398 ms) : 0, 12398
Telemetry [candidate] (13.642 ms) : 0, 13642
Flare Poller [baseline] (4.123 ms) : 0, 4123
Flare Poller [candidate] (4.156 ms) : 0, 4156
Profiling [baseline] (111.491 ms) : 0, 111491
Profiling [candidate] (111.796 ms) : 0, 111796
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.56.0-SNAPSHOT~6171acdd37, baseline=1.56.0-SNAPSHOT~4fb1b2e325
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.048 s) : 0, 1047986
Total [baseline] (8.632 s) : 0, 8632083
Agent [candidate] (1.048 s) : 0, 1048416
Total [candidate] (8.65 s) : 0, 8649847
section iast
Agent [baseline] (1.181 s) : 0, 1181154
Total [baseline] (9.257 s) : 0, 9256814
Agent [candidate] (1.18 s) : 0, 1179855
Total [candidate] (9.224 s) : 0, 9223805
gantt
title insecure-bank - break down per module: candidate=1.56.0-SNAPSHOT~6171acdd37, baseline=1.56.0-SNAPSHOT~4fb1b2e325
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.456 ms) : 0, 1456
crashtracking [candidate] (1.448 ms) : 0, 1448
BytebuddyAgent [baseline] (704.43 ms) : 0, 704430
BytebuddyAgent [candidate] (705.531 ms) : 0, 705531
GlobalTracer [baseline] (246.783 ms) : 0, 246783
GlobalTracer [candidate] (246.306 ms) : 0, 246306
AppSec [baseline] (32.486 ms) : 0, 32486
AppSec [candidate] (32.388 ms) : 0, 32388
Debugger [baseline] (6.413 ms) : 0, 6413
Debugger [candidate] (6.408 ms) : 0, 6408
Remote Config [baseline] (723.645 µs) : 0, 724
Remote Config [candidate] (705.756 µs) : 0, 706
Telemetry [baseline] (13.706 ms) : 0, 13706
Telemetry [candidate] (13.0 ms) : 0, 13000
Flare Poller [baseline] (7.349 ms) : 0, 7349
Flare Poller [candidate] (8.037 ms) : 0, 8037
section iast
crashtracking [baseline] (1.455 ms) : 0, 1455
crashtracking [candidate] (1.453 ms) : 0, 1453
BytebuddyAgent [baseline] (829.406 ms) : 0, 829406
BytebuddyAgent [candidate] (828.55 ms) : 0, 828550
GlobalTracer [baseline] (235.069 ms) : 0, 235069
GlobalTracer [candidate] (234.844 ms) : 0, 234844
AppSec [baseline] (27.798 ms) : 0, 27798
AppSec [candidate] (26.96 ms) : 0, 26960
Debugger [baseline] (6.006 ms) : 0, 6006
Debugger [candidate] (5.983 ms) : 0, 5983
Remote Config [baseline] (601.676 µs) : 0, 602
Remote Config [candidate] (589.394 µs) : 0, 589
Telemetry [baseline] (8.447 ms) : 0, 8447
Telemetry [candidate] (8.36 ms) : 0, 8360
Flare Poller [baseline] (4.156 ms) : 0, 4156
Flare Poller [candidate] (4.105 ms) : 0, 4105
IAST [baseline] (33.503 ms) : 0, 33503
IAST [candidate] (34.284 ms) : 0, 34284
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 2 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~6171acdd37, baseline=1.56.0-SNAPSHOT~4fb1b2e325
dateFormat X
axisFormat %s
section baseline
no_agent (1.188 ms) : 1176, 1200
. : milestone, 1188,
iast (3.285 ms) : 3247, 3324
. : milestone, 3285,
iast_FULL (5.747 ms) : 5690, 5805
. : milestone, 5747,
iast_GLOBAL (3.457 ms) : 3403, 3511
. : milestone, 3457,
profiling (1.988 ms) : 1971, 2005
. : milestone, 1988,
tracing (1.824 ms) : 1806, 1841
. : milestone, 1824,
section candidate
no_agent (1.183 ms) : 1171, 1194
. : milestone, 1183,
iast (3.209 ms) : 3159, 3259
. : milestone, 3209,
iast_FULL (5.895 ms) : 5836, 5954
. : milestone, 5895,
iast_GLOBAL (3.624 ms) : 3572, 3676
. : milestone, 3624,
profiling (2.127 ms) : 2108, 2145
. : milestone, 2127,
tracing (1.8 ms) : 1784, 1816
. : milestone, 1800,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~6171acdd37, baseline=1.56.0-SNAPSHOT~4fb1b2e325
dateFormat X
axisFormat %s
section baseline
no_agent (17.927 ms) : 17744, 18110
. : milestone, 17927,
appsec (18.695 ms) : 18501, 18888
. : milestone, 18695,
code_origins (17.975 ms) : 17798, 18152
. : milestone, 17975,
iast (17.684 ms) : 17505, 17862
. : milestone, 17684,
profiling (18.455 ms) : 18271, 18640
. : milestone, 18455,
tracing (17.786 ms) : 17612, 17960
. : milestone, 17786,
section candidate
no_agent (17.229 ms) : 17053, 17405
. : milestone, 17229,
appsec (18.58 ms) : 18396, 18764
. : milestone, 18580,
code_origins (17.92 ms) : 17739, 18100
. : milestone, 17920,
iast (17.666 ms) : 17490, 17842
. : milestone, 17666,
profiling (18.498 ms) : 18314, 18683
. : milestone, 18498,
tracing (17.827 ms) : 17648, 18005
. : milestone, 17827,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~6171acdd37, baseline=1.56.0-SNAPSHOT~4fb1b2e325
dateFormat X
axisFormat %s
section baseline
no_agent (14.95 s) : 14950000, 14950000
. : milestone, 14950000,
appsec (15.341 s) : 15341000, 15341000
. : milestone, 15341000,
iast (18.558 s) : 18558000, 18558000
. : milestone, 18558000,
iast_GLOBAL (17.969 s) : 17969000, 17969000
. : milestone, 17969000,
profiling (15.688 s) : 15688000, 15688000
. : milestone, 15688000,
tracing (14.832 s) : 14832000, 14832000
. : milestone, 14832000,
section candidate
no_agent (15.505 s) : 15505000, 15505000
. : milestone, 15505000,
appsec (14.895 s) : 14895000, 14895000
. : milestone, 14895000,
iast (18.394 s) : 18394000, 18394000
. : milestone, 18394000,
iast_GLOBAL (17.771 s) : 17771000, 17771000
. : milestone, 17771000,
profiling (15.637 s) : 15637000, 15637000
. : milestone, 15637000,
tracing (14.815 s) : 14815000, 14815000
. : milestone, 14815000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~6171acdd37, baseline=1.56.0-SNAPSHOT~4fb1b2e325
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1462, 1485
. : milestone, 1474,
appsec (3.627 ms) : 3414, 3840
. : milestone, 3627,
iast (2.202 ms) : 2139, 2266
. : milestone, 2202,
iast_GLOBAL (2.246 ms) : 2183, 2310
. : milestone, 2246,
profiling (2.051 ms) : 1999, 2102
. : milestone, 2051,
tracing (2.015 ms) : 1966, 2065
. : milestone, 2015,
section candidate
no_agent (1.473 ms) : 1461, 1484
. : milestone, 1473,
appsec (3.644 ms) : 3429, 3859
. : milestone, 3644,
iast (2.205 ms) : 2142, 2269
. : milestone, 2205,
iast_GLOBAL (2.243 ms) : 2179, 2306
. : milestone, 2243,
profiling (2.064 ms) : 2011, 2117
. : milestone, 2064,
tracing (2.025 ms) : 1975, 2075
. : milestone, 2025,
|
5e35825 to
7973876
Compare
...otel/otel-tooling/src/main/java/datadog/opentelemetry/tooling/OtelInstrumentationMapper.java
Outdated
Show resolved
Hide resolved
7973876 to
6171acd
Compare
What Does This Do
Relocates all references to
org.objectweb.asmto use the same repackaged copy of ASM courtesy of thedd-instrument-javadependency, which reduces the number of copies of ASM included in the finaldd-java-agentjar.Motivation
Reduces the final jar size by 120k, as well as fewer classes loaded during startup.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]