-
Notifications
You must be signed in to change notification settings - Fork 318
Add the tags returned by the service to the ai_guard span #9931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 8 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.56.0-SNAPSHOT~3c243efa42, baseline=1.56.0-SNAPSHOT~8aa326fafe
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.101 s) : 0, 1101066
Total [baseline] (8.845 s) : 0, 8844656
Agent [candidate] (1.108 s) : 0, 1108101
Total [candidate] (8.883 s) : 0, 8882838
section iast
Agent [baseline] (1.236 s) : 0, 1236095
Total [baseline] (9.543 s) : 0, 9542513
Agent [candidate] (1.256 s) : 0, 1256055
Total [candidate] (9.552 s) : 0, 9552153
gantt
title insecure-bank - break down per module: candidate=1.56.0-SNAPSHOT~3c243efa42, baseline=1.56.0-SNAPSHOT~8aa326fafe
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.464 ms) : 0, 1464
crashtracking [candidate] (1.459 ms) : 0, 1459
BytebuddyAgent [baseline] (707.74 ms) : 0, 707740
BytebuddyAgent [candidate] (713.041 ms) : 0, 713041
GlobalTracer [baseline] (248.945 ms) : 0, 248945
GlobalTracer [candidate] (250.606 ms) : 0, 250606
AppSec [baseline] (32.043 ms) : 0, 32043
AppSec [candidate] (32.284 ms) : 0, 32284
Debugger [baseline] (63.441 ms) : 0, 63441
Debugger [candidate] (63.047 ms) : 0, 63047
Remote Config [baseline] (623.966 µs) : 0, 624
Remote Config [candidate] (626.995 µs) : 0, 627
Telemetry [baseline] (8.255 ms) : 0, 8255
Telemetry [candidate] (8.329 ms) : 0, 8329
Flare Poller [baseline] (3.695 ms) : 0, 3695
Flare Poller [candidate] (3.772 ms) : 0, 3772
section iast
crashtracking [baseline] (1.446 ms) : 0, 1446
crashtracking [candidate] (1.473 ms) : 0, 1473
BytebuddyAgent [baseline] (830.126 ms) : 0, 830126
BytebuddyAgent [candidate] (844.903 ms) : 0, 844903
GlobalTracer [baseline] (236.932 ms) : 0, 236932
GlobalTracer [candidate] (239.543 ms) : 0, 239543
AppSec [baseline] (32.035 ms) : 0, 32035
AppSec [candidate] (33.299 ms) : 0, 33299
Debugger [baseline] (60.184 ms) : 0, 60184
Debugger [candidate] (60.99 ms) : 0, 60990
Remote Config [baseline] (550.977 µs) : 0, 551
Remote Config [candidate] (557.973 µs) : 0, 558
Telemetry [baseline] (7.632 ms) : 0, 7632
Telemetry [candidate] (7.827 ms) : 0, 7827
Flare Poller [baseline] (3.494 ms) : 0, 3494
Flare Poller [candidate] (3.569 ms) : 0, 3569
IAST [baseline] (28.912 ms) : 0, 28912
IAST [candidate] (28.718 ms) : 0, 28718
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.56.0-SNAPSHOT~3c243efa42, baseline=1.56.0-SNAPSHOT~8aa326fafe
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.1 s) : 0, 1100497
Total [baseline] (10.761 s) : 0, 10761239
Agent [candidate] (1.101 s) : 0, 1100917
Total [candidate] (10.749 s) : 0, 10749058
section appsec
Agent [baseline] (1.281 s) : 0, 1281100
Total [baseline] (11.128 s) : 0, 11127683
Agent [candidate] (1.284 s) : 0, 1284045
Total [candidate] (11.14 s) : 0, 11140078
section iast
Agent [baseline] (1.239 s) : 0, 1238940
Total [baseline] (11.234 s) : 0, 11234468
Agent [candidate] (1.25 s) : 0, 1249759
Total [candidate] (11.295 s) : 0, 11295461
section profiling
Agent [baseline] (1.26 s) : 0, 1260127
Total [baseline] (11.173 s) : 0, 11172523
Agent [candidate] (1.234 s) : 0, 1234140
Total [candidate] (11.135 s) : 0, 11135242
gantt
title petclinic - break down per module: candidate=1.56.0-SNAPSHOT~3c243efa42, baseline=1.56.0-SNAPSHOT~8aa326fafe
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.46 ms) : 0, 1460
crashtracking [candidate] (1.453 ms) : 0, 1453
BytebuddyAgent [baseline] (706.65 ms) : 0, 706650
BytebuddyAgent [candidate] (707.059 ms) : 0, 707059
GlobalTracer [baseline] (248.982 ms) : 0, 248982
GlobalTracer [candidate] (248.905 ms) : 0, 248905
AppSec [baseline] (31.921 ms) : 0, 31921
AppSec [candidate] (32.08 ms) : 0, 32080
Debugger [baseline] (64.043 ms) : 0, 64043
Debugger [candidate] (63.702 ms) : 0, 63702
Remote Config [baseline] (638.582 µs) : 0, 639
Remote Config [candidate] (632.212 µs) : 0, 632
Telemetry [baseline] (8.255 ms) : 0, 8255
Telemetry [candidate] (8.455 ms) : 0, 8455
Flare Poller [baseline] (3.776 ms) : 0, 3776
Flare Poller [candidate] (3.821 ms) : 0, 3821
section appsec
crashtracking [baseline] (1.461 ms) : 0, 1461
crashtracking [candidate] (1.448 ms) : 0, 1448
BytebuddyAgent [baseline] (730.628 ms) : 0, 730628
BytebuddyAgent [candidate] (733.025 ms) : 0, 733025
GlobalTracer [baseline] (240.64 ms) : 0, 240640
GlobalTracer [candidate] (240.836 ms) : 0, 240836
AppSec [baseline] (174.143 ms) : 0, 174143
AppSec [candidate] (174.952 ms) : 0, 174952
Debugger [baseline] (61.724 ms) : 0, 61724
Debugger [candidate] (61.347 ms) : 0, 61347
Remote Config [baseline] (700.288 µs) : 0, 700
Remote Config [candidate] (663.68 µs) : 0, 664
Telemetry [baseline] (8.232 ms) : 0, 8232
Telemetry [candidate] (8.233 ms) : 0, 8233
Flare Poller [baseline] (3.905 ms) : 0, 3905
Flare Poller [candidate] (3.846 ms) : 0, 3846
IAST [baseline] (24.729 ms) : 0, 24729
IAST [candidate] (24.708 ms) : 0, 24708
section iast
crashtracking [baseline] (1.452 ms) : 0, 1452
crashtracking [candidate] (1.458 ms) : 0, 1458
BytebuddyAgent [baseline] (831.549 ms) : 0, 831549
BytebuddyAgent [candidate] (839.719 ms) : 0, 839719
GlobalTracer [baseline] (237.28 ms) : 0, 237280
GlobalTracer [candidate] (238.961 ms) : 0, 238961
AppSec [baseline] (34.866 ms) : 0, 34866
AppSec [candidate] (34.016 ms) : 0, 34016
Debugger [baseline] (60.707 ms) : 0, 60707
Debugger [candidate] (60.942 ms) : 0, 60942
Remote Config [baseline] (528.068 µs) : 0, 528
Remote Config [candidate] (546.336 µs) : 0, 546
Telemetry [baseline] (7.571 ms) : 0, 7571
Telemetry [candidate] (7.672 ms) : 0, 7672
Flare Poller [baseline] (3.456 ms) : 0, 3456
Flare Poller [candidate] (3.497 ms) : 0, 3497
IAST [baseline] (26.584 ms) : 0, 26584
IAST [candidate] (27.868 ms) : 0, 27868
section profiling
crashtracking [baseline] (1.479 ms) : 0, 1479
crashtracking [candidate] (1.435 ms) : 0, 1435
BytebuddyAgent [baseline] (753.541 ms) : 0, 753541
BytebuddyAgent [candidate] (734.72 ms) : 0, 734720
GlobalTracer [baseline] (225.82 ms) : 0, 225820
GlobalTracer [candidate] (223.294 ms) : 0, 223294
AppSec [baseline] (32.859 ms) : 0, 32859
AppSec [candidate] (32.196 ms) : 0, 32196
Debugger [baseline] (64.651 ms) : 0, 64651
Debugger [candidate] (62.913 ms) : 0, 62913
Remote Config [baseline] (672.772 µs) : 0, 673
Remote Config [candidate] (651.756 µs) : 0, 652
Telemetry [baseline] (8.187 ms) : 0, 8187
Telemetry [candidate] (8.001 ms) : 0, 8001
Flare Poller [baseline] (3.894 ms) : 0, 3894
Flare Poller [candidate] (3.783 ms) : 0, 3783
ProfilingAgent [baseline] (98.255 ms) : 0, 98255
ProfilingAgent [candidate] (97.583 ms) : 0, 97583
Profiling [baseline] (98.845 ms) : 0, 98845
Profiling [candidate] (98.17 ms) : 0, 98170
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 3 performance regressions! Performance is the same for 15 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~3c243efa42, baseline=1.56.0-SNAPSHOT~8aa326fafe
dateFormat X
axisFormat %s
section baseline
no_agent (1.205 ms) : 1192, 1217
. : milestone, 1205,
iast (3.095 ms) : 3054, 3137
. : milestone, 3095,
iast_FULL (5.898 ms) : 5839, 5957
. : milestone, 5898,
iast_GLOBAL (3.633 ms) : 3582, 3683
. : milestone, 3633,
profiling (1.998 ms) : 1981, 2015
. : milestone, 1998,
tracing (1.818 ms) : 1803, 1833
. : milestone, 1818,
section candidate
no_agent (1.184 ms) : 1173, 1196
. : milestone, 1184,
iast (3.353 ms) : 3315, 3391
. : milestone, 3353,
iast_FULL (6.098 ms) : 6037, 6159
. : milestone, 6098,
iast_GLOBAL (3.757 ms) : 3693, 3821
. : milestone, 3757,
profiling (2.161 ms) : 2142, 2180
. : milestone, 2161,
tracing (1.902 ms) : 1884, 1921
. : milestone, 1902,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~3c243efa42, baseline=1.56.0-SNAPSHOT~8aa326fafe
dateFormat X
axisFormat %s
section baseline
no_agent (18.37 ms) : 18182, 18558
. : milestone, 18370,
appsec (18.623 ms) : 18436, 18810
. : milestone, 18623,
code_origins (17.795 ms) : 17618, 17973
. : milestone, 17795,
iast (18.749 ms) : 18562, 18936
. : milestone, 18749,
profiling (18.464 ms) : 18281, 18647
. : milestone, 18464,
tracing (17.796 ms) : 17619, 17973
. : milestone, 17796,
section candidate
no_agent (19.301 ms) : 19101, 19501
. : milestone, 19301,
appsec (18.882 ms) : 18688, 19076
. : milestone, 18882,
code_origins (17.644 ms) : 17471, 17817
. : milestone, 17644,
iast (17.296 ms) : 17127, 17466
. : milestone, 17296,
profiling (18.643 ms) : 18454, 18833
. : milestone, 18643,
tracing (17.69 ms) : 17515, 17864
. : milestone, 17690,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~3c243efa42, baseline=1.56.0-SNAPSHOT~8aa326fafe
dateFormat X
axisFormat %s
section baseline
no_agent (1.482 ms) : 1470, 1494
. : milestone, 1482,
appsec (2.471 ms) : 2419, 2522
. : milestone, 2471,
iast (2.221 ms) : 2157, 2286
. : milestone, 2221,
iast_GLOBAL (2.271 ms) : 2206, 2336
. : milestone, 2271,
profiling (2.062 ms) : 2009, 2114
. : milestone, 2062,
tracing (2.058 ms) : 2007, 2110
. : milestone, 2058,
section candidate
no_agent (1.479 ms) : 1467, 1490
. : milestone, 1479,
appsec (2.461 ms) : 2409, 2513
. : milestone, 2461,
iast (2.224 ms) : 2159, 2289
. : milestone, 2224,
iast_GLOBAL (2.261 ms) : 2195, 2326
. : milestone, 2261,
profiling (2.108 ms) : 2054, 2163
. : milestone, 2108,
tracing (2.061 ms) : 2010, 2113
. : milestone, 2061,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~3c243efa42, baseline=1.56.0-SNAPSHOT~8aa326fafe
dateFormat X
axisFormat %s
section baseline
no_agent (15.449 s) : 15449000, 15449000
. : milestone, 15449000,
appsec (14.764 s) : 14764000, 14764000
. : milestone, 14764000,
iast (18.611 s) : 18611000, 18611000
. : milestone, 18611000,
iast_GLOBAL (17.715 s) : 17715000, 17715000
. : milestone, 17715000,
profiling (14.836 s) : 14836000, 14836000
. : milestone, 14836000,
tracing (14.878 s) : 14878000, 14878000
. : milestone, 14878000,
section candidate
no_agent (15.576 s) : 15576000, 15576000
. : milestone, 15576000,
appsec (14.689 s) : 14689000, 14689000
. : milestone, 14689000,
iast (18.484 s) : 18484000, 18484000
. : milestone, 18484000,
iast_GLOBAL (17.952 s) : 17952000, 17952000
. : milestone, 17952000,
profiling (14.836 s) : 14836000, 14836000
. : milestone, 14836000,
tracing (14.767 s) : 14767000, 14767000
. : milestone, 14767000,
|
1fa71e2 to
61aa2a4
Compare
jandro996
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT
|
Execution failed for task ':dd-java-agent:agent-aiguard:jacocoTestCoverageVerification'.
:D |
61aa2a4 to
3c243ef
Compare
Yep, fixed, thanks! |
Add the tags returned by the service to the ai_guard span
What Does This Do
Takes the evaluation tags receives from the AI Guard evaluation API and exposes them in the span tags.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]