-
Notifications
You must be signed in to change notification settings - Fork 317
Fixing Linting Errors Detected in config-inversion-linter
#9945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
|
🎯 Code Coverage 🔗 Commit SHA: 99a378e | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 5 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.56.0-SNAPSHOT~99a378ead6, baseline=1.56.0-SNAPSHOT~b99070a00c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.107 s) : 0, 1106940
Total [baseline] (8.887 s) : 0, 8886634
Agent [candidate] (1.103 s) : 0, 1103154
Total [candidate] (8.824 s) : 0, 8824468
section iast
Agent [baseline] (1.245 s) : 0, 1244603
Total [baseline] (9.576 s) : 0, 9575716
Agent [candidate] (1.243 s) : 0, 1243339
Total [candidate] (9.58 s) : 0, 9580123
gantt
title insecure-bank - break down per module: candidate=1.56.0-SNAPSHOT~99a378ead6, baseline=1.56.0-SNAPSHOT~b99070a00c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.459 ms) : 0, 1459
crashtracking [candidate] (1.456 ms) : 0, 1456
BytebuddyAgent [baseline] (708.118 ms) : 0, 708118
BytebuddyAgent [candidate] (705.653 ms) : 0, 705653
GlobalTracer [baseline] (248.767 ms) : 0, 248767
GlobalTracer [candidate] (248.564 ms) : 0, 248564
AppSec [baseline] (32.491 ms) : 0, 32491
AppSec [candidate] (32.285 ms) : 0, 32285
Debugger [baseline] (68.621 ms) : 0, 68621
Debugger [candidate] (68.053 ms) : 0, 68053
Remote Config [baseline] (633.001 µs) : 0, 633
Remote Config [candidate] (629.102 µs) : 0, 629
Telemetry [baseline] (8.285 ms) : 0, 8285
Telemetry [candidate] (8.099 ms) : 0, 8099
Flare Poller [baseline] (3.765 ms) : 0, 3765
Flare Poller [candidate] (3.681 ms) : 0, 3681
section iast
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.49 ms) : 0, 1490
BytebuddyAgent [baseline] (831.123 ms) : 0, 831123
BytebuddyAgent [candidate] (830.363 ms) : 0, 830363
GlobalTracer [baseline] (238.286 ms) : 0, 238286
GlobalTracer [candidate] (238.451 ms) : 0, 238451
IAST [baseline] (26.768 ms) : 0, 26768
IAST [candidate] (30.842 ms) : 0, 30842
AppSec [baseline] (35.203 ms) : 0, 35203
AppSec [candidate] (30.613 ms) : 0, 30613
Debugger [baseline] (65.136 ms) : 0, 65136
Debugger [candidate] (65.035 ms) : 0, 65035
Remote Config [baseline] (545.279 µs) : 0, 545
Remote Config [candidate] (546.987 µs) : 0, 547
Telemetry [baseline] (7.702 ms) : 0, 7702
Telemetry [candidate] (7.684 ms) : 0, 7684
Flare Poller [baseline] (3.565 ms) : 0, 3565
Flare Poller [candidate] (3.559 ms) : 0, 3559
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.56.0-SNAPSHOT~99a378ead6, baseline=1.56.0-SNAPSHOT~b99070a00c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.113 s) : 0, 1113372
Total [baseline] (10.933 s) : 0, 10933177
Agent [candidate] (1.107 s) : 0, 1106847
Total [candidate] (10.802 s) : 0, 10801776
section appsec
Agent [baseline] (1.284 s) : 0, 1283899
Total [baseline] (11.091 s) : 0, 11091010
Agent [candidate] (1.28 s) : 0, 1280246
Total [candidate] (11.161 s) : 0, 11161297
section iast
Agent [baseline] (1.242 s) : 0, 1241950
Total [baseline] (11.359 s) : 0, 11359456
Agent [candidate] (1.253 s) : 0, 1252804
Total [candidate] (11.396 s) : 0, 11395501
section profiling
Agent [baseline] (1.237 s) : 0, 1237335
Total [baseline] (11.095 s) : 0, 11095317
Agent [candidate] (1.239 s) : 0, 1238951
Total [candidate] (11.234 s) : 0, 11234036
gantt
title petclinic - break down per module: candidate=1.56.0-SNAPSHOT~99a378ead6, baseline=1.56.0-SNAPSHOT~b99070a00c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.46 ms) : 0, 1460
crashtracking [candidate] (1.463 ms) : 0, 1463
BytebuddyAgent [baseline] (710.132 ms) : 0, 710132
BytebuddyAgent [candidate] (707.802 ms) : 0, 707802
GlobalTracer [baseline] (251.426 ms) : 0, 251426
GlobalTracer [candidate] (249.276 ms) : 0, 249276
AppSec [baseline] (32.831 ms) : 0, 32831
AppSec [candidate] (32.399 ms) : 0, 32399
Debugger [baseline] (69.955 ms) : 0, 69955
Debugger [candidate] (68.789 ms) : 0, 68789
Remote Config [baseline] (646.874 µs) : 0, 647
Remote Config [candidate] (622.836 µs) : 0, 623
Telemetry [baseline] (8.35 ms) : 0, 8350
Telemetry [candidate] (8.04 ms) : 0, 8040
Flare Poller [baseline] (3.787 ms) : 0, 3787
Flare Poller [candidate] (3.691 ms) : 0, 3691
section appsec
crashtracking [baseline] (1.48 ms) : 0, 1480
crashtracking [candidate] (1.458 ms) : 0, 1458
BytebuddyAgent [baseline] (732.488 ms) : 0, 732488
BytebuddyAgent [candidate] (729.59 ms) : 0, 729590
GlobalTracer [baseline] (241.179 ms) : 0, 241179
GlobalTracer [candidate] (240.437 ms) : 0, 240437
IAST [baseline] (24.945 ms) : 0, 24945
IAST [candidate] (24.674 ms) : 0, 24674
AppSec [baseline] (174.478 ms) : 0, 174478
AppSec [candidate] (173.572 ms) : 0, 173572
Debugger [baseline] (61.26 ms) : 0, 61260
Debugger [candidate] (62.575 ms) : 0, 62575
Remote Config [baseline] (710.078 µs) : 0, 710
Remote Config [candidate] (649.556 µs) : 0, 650
Telemetry [baseline] (8.34 ms) : 0, 8340
Telemetry [candidate] (8.497 ms) : 0, 8497
Flare Poller [baseline] (3.994 ms) : 0, 3994
Flare Poller [candidate] (4.011 ms) : 0, 4011
section iast
crashtracking [baseline] (1.48 ms) : 0, 1480
crashtracking [candidate] (1.471 ms) : 0, 1471
BytebuddyAgent [baseline] (828.81 ms) : 0, 828810
BytebuddyAgent [candidate] (837.448 ms) : 0, 837448
GlobalTracer [baseline] (238.284 ms) : 0, 238284
GlobalTracer [candidate] (239.423 ms) : 0, 239423
IAST [baseline] (28.881 ms) : 0, 28881
IAST [candidate] (31.396 ms) : 0, 31396
AppSec [baseline] (32.374 ms) : 0, 32374
AppSec [candidate] (30.673 ms) : 0, 30673
Debugger [baseline] (65.793 ms) : 0, 65793
Debugger [candidate] (65.774 ms) : 0, 65774
Remote Config [baseline] (549.178 µs) : 0, 549
Remote Config [candidate] (553.399 µs) : 0, 553
Telemetry [baseline] (7.585 ms) : 0, 7585
Telemetry [candidate] (7.671 ms) : 0, 7671
Flare Poller [baseline] (3.499 ms) : 0, 3499
Flare Poller [candidate] (3.602 ms) : 0, 3602
section profiling
crashtracking [baseline] (1.439 ms) : 0, 1439
crashtracking [candidate] (1.464 ms) : 0, 1464
BytebuddyAgent [baseline] (732.482 ms) : 0, 732482
BytebuddyAgent [candidate] (732.384 ms) : 0, 732384
GlobalTracer [baseline] (223.07 ms) : 0, 223070
GlobalTracer [candidate] (223.393 ms) : 0, 223393
AppSec [baseline] (32.473 ms) : 0, 32473
AppSec [candidate] (32.483 ms) : 0, 32483
Debugger [baseline] (68.066 ms) : 0, 68066
Debugger [candidate] (68.589 ms) : 0, 68589
Remote Config [baseline] (651.738 µs) : 0, 652
Remote Config [candidate] (653.866 µs) : 0, 654
Telemetry [baseline] (8.091 ms) : 0, 8091
Telemetry [candidate] (8.037 ms) : 0, 8037
Flare Poller [baseline] (3.869 ms) : 0, 3869
Flare Poller [candidate] (3.902 ms) : 0, 3902
ProfilingAgent [baseline] (97.263 ms) : 0, 97263
ProfilingAgent [candidate] (98.323 ms) : 0, 98323
Profiling [baseline] (97.85 ms) : 0, 97850
Profiling [candidate] (98.928 ms) : 0, 98928
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 18 metrics, 17 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~99a378ead6, baseline=1.56.0-SNAPSHOT~b99070a00c
dateFormat X
axisFormat %s
section baseline
no_agent (1.187 ms) : 1176, 1199
. : milestone, 1187,
iast (3.3 ms) : 3256, 3344
. : milestone, 3300,
iast_FULL (5.724 ms) : 5667, 5781
. : milestone, 5724,
iast_GLOBAL (3.698 ms) : 3638, 3758
. : milestone, 3698,
profiling (2.039 ms) : 2021, 2057
. : milestone, 2039,
tracing (1.783 ms) : 1769, 1797
. : milestone, 1783,
section candidate
no_agent (1.175 ms) : 1163, 1187
. : milestone, 1175,
iast (3.247 ms) : 3202, 3291
. : milestone, 3247,
iast_FULL (5.835 ms) : 5757, 5913
. : milestone, 5835,
iast_GLOBAL (3.518 ms) : 3466, 3571
. : milestone, 3518,
profiling (2.016 ms) : 1998, 2035
. : milestone, 2016,
tracing (1.764 ms) : 1750, 1777
. : milestone, 1764,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~99a378ead6, baseline=1.56.0-SNAPSHOT~b99070a00c
dateFormat X
axisFormat %s
section baseline
no_agent (18.378 ms) : 18186, 18570
. : milestone, 18378,
appsec (18.688 ms) : 18501, 18874
. : milestone, 18688,
code_origins (17.591 ms) : 17417, 17766
. : milestone, 17591,
iast (17.713 ms) : 17536, 17891
. : milestone, 17713,
profiling (18.633 ms) : 18446, 18820
. : milestone, 18633,
tracing (17.853 ms) : 17676, 18031
. : milestone, 17853,
section candidate
no_agent (19.461 ms) : 19257, 19665
. : milestone, 19461,
appsec (18.321 ms) : 18137, 18505
. : milestone, 18321,
code_origins (17.939 ms) : 17762, 18117
. : milestone, 17939,
iast (17.578 ms) : 17402, 17753
. : milestone, 17578,
profiling (18.539 ms) : 18351, 18727
. : milestone, 18539,
tracing (17.42 ms) : 17249, 17592
. : milestone, 17420,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~99a378ead6, baseline=1.56.0-SNAPSHOT~b99070a00c
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1462, 1485
. : milestone, 1474,
appsec (3.704 ms) : 3487, 3922
. : milestone, 3704,
iast (2.205 ms) : 2142, 2269
. : milestone, 2205,
iast_GLOBAL (2.255 ms) : 2191, 2319
. : milestone, 2255,
profiling (2.084 ms) : 2030, 2137
. : milestone, 2084,
tracing (2.042 ms) : 1992, 2092
. : milestone, 2042,
section candidate
no_agent (1.475 ms) : 1464, 1487
. : milestone, 1475,
appsec (2.505 ms) : 2451, 2560
. : milestone, 2505,
iast (2.216 ms) : 2152, 2280
. : milestone, 2216,
iast_GLOBAL (2.254 ms) : 2190, 2318
. : milestone, 2254,
profiling (2.06 ms) : 2009, 2112
. : milestone, 2060,
tracing (2.036 ms) : 1986, 2086
. : milestone, 2036,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~99a378ead6, baseline=1.56.0-SNAPSHOT~b99070a00c
dateFormat X
axisFormat %s
section baseline
no_agent (14.77 s) : 14770000, 14770000
. : milestone, 14770000,
appsec (14.725 s) : 14725000, 14725000
. : milestone, 14725000,
iast (18.054 s) : 18054000, 18054000
. : milestone, 18054000,
iast_GLOBAL (17.869 s) : 17869000, 17869000
. : milestone, 17869000,
profiling (15.805 s) : 15805000, 15805000
. : milestone, 15805000,
tracing (14.817 s) : 14817000, 14817000
. : milestone, 14817000,
section candidate
no_agent (15.569 s) : 15569000, 15569000
. : milestone, 15569000,
appsec (14.986 s) : 14986000, 14986000
. : milestone, 14986000,
iast (18.304 s) : 18304000, 18304000
. : milestone, 18304000,
iast_GLOBAL (17.929 s) : 17929000, 17929000
. : milestone, 17929000,
profiling (15.083 s) : 15083000, 15083000
. : milestone, 15083000,
tracing (14.793 s) : 14793000, 14793000
. : milestone, 14793000,
|
What Does This Do
Linters for Config Inversion existed but were not enforced. #9944 aims to enforce the linter, and this PR fixes existing problems that bypassed the linter previously to give Green CI to #9944.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]