-
Notifications
You must be signed in to change notification settings - Fork 318
Fix DebuggerAgent tests #9951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DebuggerAgent tests #9951
Conversation
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
|
🎯 Code Coverage 🔗 Commit SHA: 3926cad | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
Inject a config instance to DebuggerAgent and stop rely on Config.get() to be able to provide clean config at any time. add some reset method for reseting static fields Fix readFromFile test that wasn't at all executed
7f254a3 to
3926cad
Compare
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 5 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (319.765 µs) : 296, 344
. : milestone, 320,
basic (291.152 µs) : 284, 299
. : milestone, 291,
loop (8.444 ms) : 8382, 8505
. : milestone, 8444,
section candidate
noprobe (334.245 µs) : 299, 369
. : milestone, 334,
basic (294.207 µs) : 287, 301
. : milestone, 294,
loop (8.454 ms) : 8383, 8525
. : milestone, 8454,
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 6 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.56.0-SNAPSHOT~3926cad009, baseline=1.56.0-SNAPSHOT~640a4bd02b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.096 s) : 0, 1096389
Total [baseline] (10.756 s) : 0, 10755913
Agent [candidate] (1.099 s) : 0, 1099084
Total [candidate] (10.723 s) : 0, 10723226
section appsec
Agent [baseline] (1.279 s) : 0, 1278634
Total [baseline] (11.021 s) : 0, 11021174
Agent [candidate] (1.277 s) : 0, 1277246
Total [candidate] (11.073 s) : 0, 11072633
section iast
Agent [baseline] (1.251 s) : 0, 1251367
Total [baseline] (11.3 s) : 0, 11300467
Agent [candidate] (1.237 s) : 0, 1237383
Total [candidate] (11.242 s) : 0, 11242415
section profiling
Agent [baseline] (1.226 s) : 0, 1226106
Total [baseline] (11.064 s) : 0, 11064139
Agent [candidate] (1.23 s) : 0, 1230439
Total [candidate] (11.085 s) : 0, 11084502
gantt
title petclinic - break down per module: candidate=1.56.0-SNAPSHOT~3926cad009, baseline=1.56.0-SNAPSHOT~640a4bd02b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.452 ms) : 0, 1452
crashtracking [candidate] (1.453 ms) : 0, 1453
BytebuddyAgent [baseline] (703.994 ms) : 0, 703994
BytebuddyAgent [candidate] (705.529 ms) : 0, 705529
GlobalTracer [baseline] (247.893 ms) : 0, 247893
GlobalTracer [candidate] (248.312 ms) : 0, 248312
AppSec [baseline] (32.176 ms) : 0, 32176
AppSec [candidate] (32.425 ms) : 0, 32425
Debugger [baseline] (63.828 ms) : 0, 63828
Debugger [candidate] (64.141 ms) : 0, 64141
Remote Config [baseline] (635.046 µs) : 0, 635
Remote Config [candidate] (626.021 µs) : 0, 626
Telemetry [baseline] (8.114 ms) : 0, 8114
Telemetry [candidate] (8.21 ms) : 0, 8210
Flare Poller [baseline] (3.697 ms) : 0, 3697
Flare Poller [candidate] (3.685 ms) : 0, 3685
section appsec
crashtracking [baseline] (1.45 ms) : 0, 1450
crashtracking [candidate] (1.444 ms) : 0, 1444
BytebuddyAgent [baseline] (728.986 ms) : 0, 728986
BytebuddyAgent [candidate] (728.493 ms) : 0, 728493
GlobalTracer [baseline] (240.88 ms) : 0, 240880
GlobalTracer [candidate] (240.488 ms) : 0, 240488
AppSec [baseline] (173.908 ms) : 0, 173908
AppSec [candidate] (173.945 ms) : 0, 173945
Debugger [baseline] (60.979 ms) : 0, 60979
Debugger [candidate] (60.589 ms) : 0, 60589
Remote Config [baseline] (672.773 µs) : 0, 673
Remote Config [candidate] (658.197 µs) : 0, 658
Telemetry [baseline] (8.426 ms) : 0, 8426
Telemetry [candidate] (8.308 ms) : 0, 8308
Flare Poller [baseline] (3.846 ms) : 0, 3846
Flare Poller [candidate] (3.87 ms) : 0, 3870
IAST [baseline] (24.694 ms) : 0, 24694
IAST [candidate] (24.781 ms) : 0, 24781
section iast
crashtracking [baseline] (1.477 ms) : 0, 1477
crashtracking [candidate] (1.466 ms) : 0, 1466
BytebuddyAgent [baseline] (840.874 ms) : 0, 840874
BytebuddyAgent [candidate] (829.449 ms) : 0, 829449
GlobalTracer [baseline] (239.275 ms) : 0, 239275
GlobalTracer [candidate] (237.675 ms) : 0, 237675
AppSec [baseline] (30.38 ms) : 0, 30380
AppSec [candidate] (28.729 ms) : 0, 28729
Debugger [baseline] (61.462 ms) : 0, 61462
Debugger [candidate] (60.882 ms) : 0, 60882
Remote Config [baseline] (566.71 µs) : 0, 567
Remote Config [candidate] (543.765 µs) : 0, 544
Telemetry [baseline] (7.875 ms) : 0, 7875
Telemetry [candidate] (7.708 ms) : 0, 7708
Flare Poller [baseline] (3.625 ms) : 0, 3625
Flare Poller [candidate] (3.541 ms) : 0, 3541
IAST [baseline] (30.93 ms) : 0, 30930
IAST [candidate] (32.772 ms) : 0, 32772
section profiling
crashtracking [baseline] (1.432 ms) : 0, 1432
crashtracking [candidate] (1.43 ms) : 0, 1430
BytebuddyAgent [baseline] (728.935 ms) : 0, 728935
BytebuddyAgent [candidate] (731.181 ms) : 0, 731181
GlobalTracer [baseline] (221.726 ms) : 0, 221726
GlobalTracer [candidate] (222.321 ms) : 0, 222321
AppSec [baseline] (32.178 ms) : 0, 32178
AppSec [candidate] (32.352 ms) : 0, 32352
Debugger [baseline] (62.797 ms) : 0, 62797
Debugger [candidate] (62.986 ms) : 0, 62986
Remote Config [baseline] (660.894 µs) : 0, 661
Remote Config [candidate] (648.067 µs) : 0, 648
Telemetry [baseline] (8.022 ms) : 0, 8022
Telemetry [candidate] (7.954 ms) : 0, 7954
Flare Poller [baseline] (3.699 ms) : 0, 3699
Flare Poller [candidate] (3.728 ms) : 0, 3728
ProfilingAgent [baseline] (97.109 ms) : 0, 97109
ProfilingAgent [candidate] (98.024 ms) : 0, 98024
Profiling [baseline] (97.688 ms) : 0, 97688
Profiling [candidate] (98.616 ms) : 0, 98616
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.56.0-SNAPSHOT~3926cad009, baseline=1.56.0-SNAPSHOT~640a4bd02b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.098 s) : 0, 1098423
Total [baseline] (8.862 s) : 0, 8861513
Agent [candidate] (1.096 s) : 0, 1096066
Total [candidate] (8.8 s) : 0, 8800328
section iast
Agent [baseline] (1.239 s) : 0, 1238732
Total [baseline] (9.531 s) : 0, 9531254
Agent [candidate] (1.237 s) : 0, 1236917
Total [candidate] (9.492 s) : 0, 9491766
gantt
title insecure-bank - break down per module: candidate=1.56.0-SNAPSHOT~3926cad009, baseline=1.56.0-SNAPSHOT~640a4bd02b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.465 ms) : 0, 1465
crashtracking [candidate] (1.451 ms) : 0, 1451
BytebuddyAgent [baseline] (705.561 ms) : 0, 705561
BytebuddyAgent [candidate] (703.407 ms) : 0, 703407
GlobalTracer [baseline] (248.102 ms) : 0, 248102
GlobalTracer [candidate] (247.869 ms) : 0, 247869
AppSec [baseline] (32.585 ms) : 0, 32585
AppSec [candidate] (32.633 ms) : 0, 32633
Debugger [baseline] (63.615 ms) : 0, 63615
Debugger [candidate] (63.6 ms) : 0, 63600
Remote Config [baseline] (630.734 µs) : 0, 631
Remote Config [candidate] (641.176 µs) : 0, 641
Telemetry [baseline] (8.12 ms) : 0, 8120
Telemetry [candidate] (8.23 ms) : 0, 8230
Flare Poller [baseline] (3.667 ms) : 0, 3667
Flare Poller [candidate] (3.698 ms) : 0, 3698
section iast
crashtracking [baseline] (1.453 ms) : 0, 1453
crashtracking [candidate] (1.455 ms) : 0, 1455
BytebuddyAgent [baseline] (832.151 ms) : 0, 832151
BytebuddyAgent [candidate] (829.687 ms) : 0, 829687
GlobalTracer [baseline] (237.318 ms) : 0, 237318
GlobalTracer [candidate] (237.514 ms) : 0, 237514
AppSec [baseline] (33.892 ms) : 0, 33892
AppSec [candidate] (32.299 ms) : 0, 32299
Debugger [baseline] (60.023 ms) : 0, 60023
Debugger [candidate] (60.243 ms) : 0, 60243
Remote Config [baseline] (540.783 µs) : 0, 541
Remote Config [candidate] (543.8 µs) : 0, 544
Telemetry [baseline] (7.684 ms) : 0, 7684
Telemetry [candidate] (7.73 ms) : 0, 7730
Flare Poller [baseline] (3.435 ms) : 0, 3435
Flare Poller [candidate] (3.478 ms) : 0, 3478
IAST [baseline] (27.349 ms) : 0, 27349
IAST [candidate] (29.202 ms) : 0, 29202
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 0 performance regressions! Performance is the same for 18 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~3926cad009, baseline=1.56.0-SNAPSHOT~640a4bd02b
dateFormat X
axisFormat %s
section baseline
no_agent (18.047 ms) : 17859, 18236
. : milestone, 18047,
appsec (18.703 ms) : 18514, 18892
. : milestone, 18703,
code_origins (17.7 ms) : 17526, 17874
. : milestone, 17700,
iast (17.789 ms) : 17609, 17969
. : milestone, 17789,
profiling (18.404 ms) : 18222, 18587
. : milestone, 18404,
tracing (17.935 ms) : 17755, 18114
. : milestone, 17935,
section candidate
no_agent (18.22 ms) : 18034, 18406
. : milestone, 18220,
appsec (18.818 ms) : 18624, 19012
. : milestone, 18818,
code_origins (17.814 ms) : 17635, 17992
. : milestone, 17814,
iast (17.515 ms) : 17341, 17688
. : milestone, 17515,
profiling (18.67 ms) : 18486, 18854
. : milestone, 18670,
tracing (17.438 ms) : 17266, 17610
. : milestone, 17438,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~3926cad009, baseline=1.56.0-SNAPSHOT~640a4bd02b
dateFormat X
axisFormat %s
section baseline
no_agent (1.185 ms) : 1173, 1196
. : milestone, 1185,
iast (3.344 ms) : 3295, 3394
. : milestone, 3344,
iast_FULL (5.767 ms) : 5710, 5824
. : milestone, 5767,
iast_GLOBAL (3.842 ms) : 3710, 3975
. : milestone, 3842,
profiling (1.924 ms) : 1908, 1940
. : milestone, 1924,
tracing (1.783 ms) : 1768, 1798
. : milestone, 1783,
section candidate
no_agent (1.176 ms) : 1164, 1187
. : milestone, 1176,
iast (3.226 ms) : 3180, 3272
. : milestone, 3226,
iast_FULL (5.946 ms) : 5886, 6006
. : milestone, 5946,
iast_GLOBAL (3.497 ms) : 3446, 3549
. : milestone, 3497,
profiling (1.988 ms) : 1970, 2005
. : milestone, 1988,
tracing (1.913 ms) : 1896, 1930
. : milestone, 1913,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~3926cad009, baseline=1.56.0-SNAPSHOT~640a4bd02b
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1464, 1487
. : milestone, 1475,
appsec (3.686 ms) : 3466, 3906
. : milestone, 3686,
iast (2.209 ms) : 2146, 2272
. : milestone, 2209,
iast_GLOBAL (2.253 ms) : 2189, 2317
. : milestone, 2253,
profiling (2.057 ms) : 2006, 2108
. : milestone, 2057,
tracing (2.019 ms) : 1970, 2068
. : milestone, 2019,
section candidate
no_agent (1.473 ms) : 1462, 1485
. : milestone, 1473,
appsec (3.727 ms) : 3509, 3946
. : milestone, 3727,
iast (2.207 ms) : 2144, 2271
. : milestone, 2207,
iast_GLOBAL (2.266 ms) : 2201, 2331
. : milestone, 2266,
profiling (2.07 ms) : 2017, 2122
. : milestone, 2070,
tracing (2.025 ms) : 1975, 2075
. : milestone, 2025,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~3926cad009, baseline=1.56.0-SNAPSHOT~640a4bd02b
dateFormat X
axisFormat %s
section baseline
no_agent (15.058 s) : 15058000, 15058000
. : milestone, 15058000,
appsec (14.736 s) : 14736000, 14736000
. : milestone, 14736000,
iast (18.132 s) : 18132000, 18132000
. : milestone, 18132000,
iast_GLOBAL (18.015 s) : 18015000, 18015000
. : milestone, 18015000,
profiling (15.707 s) : 15707000, 15707000
. : milestone, 15707000,
tracing (14.921 s) : 14921000, 14921000
. : milestone, 14921000,
section candidate
no_agent (15.121 s) : 15121000, 15121000
. : milestone, 15121000,
appsec (15.019 s) : 15019000, 15019000
. : milestone, 15019000,
iast (18.246 s) : 18246000, 18246000
. : milestone, 18246000,
iast_GLOBAL (18.279 s) : 18279000, 18279000
. : milestone, 18279000,
profiling (14.956 s) : 14956000, 14956000
. : milestone, 14956000,
tracing (14.898 s) : 14898000, 14898000
. : milestone, 14898000,
|
What Does This Do
Inject a config instance to DebuggerAgent and stop rely on Config.get() to be able to provide clean config at any time. add some reset method for reseting static fields
Fix readFromFile test that wasn't at all executed
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]