-
Notifications
You must be signed in to change notification settings - Fork 318
Simplify create-release-branch workflow #9954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🎯 Code Coverage 🔗 Commit SHA: a08227c | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 6 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.56.0-SNAPSHOT~a08227c1bb, baseline=1.56.0-SNAPSHOT~640a4bd02b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.105 s) : 0, 1104849
Total [baseline] (10.67 s) : 0, 10669850
Agent [candidate] (1.103 s) : 0, 1102880
Total [candidate] (10.751 s) : 0, 10750700
section appsec
Agent [baseline] (1.29 s) : 0, 1289637
Total [baseline] (11.046 s) : 0, 11045660
Agent [candidate] (1.284 s) : 0, 1283630
Total [candidate] (11.192 s) : 0, 11192032
section iast
Agent [baseline] (1.239 s) : 0, 1239368
Total [baseline] (11.206 s) : 0, 11206085
Agent [candidate] (1.24 s) : 0, 1239878
Total [candidate] (11.132 s) : 0, 11132433
section profiling
Agent [baseline] (1.23 s) : 0, 1230248
Total [baseline] (10.976 s) : 0, 10976329
Agent [candidate] (1.239 s) : 0, 1239201
Total [candidate] (11.138 s) : 0, 11137652
gantt
title petclinic - break down per module: candidate=1.56.0-SNAPSHOT~a08227c1bb, baseline=1.56.0-SNAPSHOT~640a4bd02b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.473 ms) : 0, 1473
crashtracking [candidate] (1.456 ms) : 0, 1456
BytebuddyAgent [baseline] (708.475 ms) : 0, 708475
BytebuddyAgent [candidate] (707.613 ms) : 0, 707613
GlobalTracer [baseline] (250.504 ms) : 0, 250504
GlobalTracer [candidate] (249.358 ms) : 0, 249358
AppSec [baseline] (32.619 ms) : 0, 32619
AppSec [candidate] (32.539 ms) : 0, 32539
Debugger [baseline] (64.466 ms) : 0, 64466
Debugger [candidate] (64.437 ms) : 0, 64437
Remote Config [baseline] (630.265 µs) : 0, 630
Remote Config [candidate] (643.136 µs) : 0, 643
Telemetry [baseline] (8.157 ms) : 0, 8157
Telemetry [candidate] (8.303 ms) : 0, 8303
Flare Poller [baseline] (3.661 ms) : 0, 3661
Flare Poller [candidate] (3.741 ms) : 0, 3741
section appsec
crashtracking [baseline] (1.461 ms) : 0, 1461
crashtracking [candidate] (1.462 ms) : 0, 1462
BytebuddyAgent [baseline] (736.019 ms) : 0, 736019
BytebuddyAgent [candidate] (731.77 ms) : 0, 731770
GlobalTracer [baseline] (242.656 ms) : 0, 242656
GlobalTracer [candidate] (241.951 ms) : 0, 241951
AppSec [baseline] (174.937 ms) : 0, 174937
AppSec [candidate] (174.43 ms) : 0, 174430
Debugger [baseline] (61.569 ms) : 0, 61569
Debugger [candidate] (61.102 ms) : 0, 61102
Remote Config [baseline] (665.624 µs) : 0, 666
Remote Config [candidate] (748.352 µs) : 0, 748
Telemetry [baseline] (8.41 ms) : 0, 8410
Telemetry [candidate] (8.492 ms) : 0, 8492
Flare Poller [baseline] (3.915 ms) : 0, 3915
Flare Poller [candidate] (3.933 ms) : 0, 3933
IAST [baseline] (25.136 ms) : 0, 25136
IAST [candidate] (24.914 ms) : 0, 24914
section iast
crashtracking [baseline] (1.456 ms) : 0, 1456
crashtracking [candidate] (1.453 ms) : 0, 1453
BytebuddyAgent [baseline] (830.817 ms) : 0, 830817
BytebuddyAgent [candidate] (830.309 ms) : 0, 830309
GlobalTracer [baseline] (238.571 ms) : 0, 238571
GlobalTracer [candidate] (238.476 ms) : 0, 238476
AppSec [baseline] (28.772 ms) : 0, 28772
AppSec [candidate] (33.412 ms) : 0, 33412
Debugger [baseline] (60.86 ms) : 0, 60860
Debugger [candidate] (61.398 ms) : 0, 61398
Remote Config [baseline] (548.364 µs) : 0, 548
Remote Config [candidate] (548.515 µs) : 0, 549
Telemetry [baseline] (7.709 ms) : 0, 7709
Telemetry [candidate] (7.64 ms) : 0, 7640
Flare Poller [baseline] (3.495 ms) : 0, 3495
Flare Poller [candidate] (3.485 ms) : 0, 3485
IAST [baseline] (32.55 ms) : 0, 32550
IAST [candidate] (28.443 ms) : 0, 28443
section profiling
crashtracking [baseline] (1.442 ms) : 0, 1442
crashtracking [candidate] (1.442 ms) : 0, 1442
BytebuddyAgent [baseline] (731.717 ms) : 0, 731717
BytebuddyAgent [candidate] (736.608 ms) : 0, 736608
GlobalTracer [baseline] (222.528 ms) : 0, 222528
GlobalTracer [candidate] (223.52 ms) : 0, 223520
AppSec [baseline] (32.482 ms) : 0, 32482
AppSec [candidate] (32.563 ms) : 0, 32563
Debugger [baseline] (63.243 ms) : 0, 63243
Debugger [candidate] (63.901 ms) : 0, 63901
Remote Config [baseline] (652.484 µs) : 0, 652
Remote Config [candidate] (650.136 µs) : 0, 650
Telemetry [baseline] (7.918 ms) : 0, 7918
Telemetry [candidate] (8.092 ms) : 0, 8092
Flare Poller [baseline] (3.763 ms) : 0, 3763
Flare Poller [candidate] (3.872 ms) : 0, 3872
ProfilingAgent [baseline] (96.755 ms) : 0, 96755
ProfilingAgent [candidate] (98.448 ms) : 0, 98448
Profiling [baseline] (97.339 ms) : 0, 97339
Profiling [candidate] (99.045 ms) : 0, 99045
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.56.0-SNAPSHOT~a08227c1bb, baseline=1.56.0-SNAPSHOT~640a4bd02b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.099 s) : 0, 1098797
Total [baseline] (8.867 s) : 0, 8867042
Agent [candidate] (1.098 s) : 0, 1098449
Total [candidate] (8.834 s) : 0, 8833629
section iast
Agent [baseline] (1.236 s) : 0, 1236211
Total [baseline] (9.52 s) : 0, 9520392
Agent [candidate] (1.24 s) : 0, 1239909
Total [candidate] (9.573 s) : 0, 9572742
gantt
title insecure-bank - break down per module: candidate=1.56.0-SNAPSHOT~a08227c1bb, baseline=1.56.0-SNAPSHOT~640a4bd02b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.458 ms) : 0, 1458
crashtracking [candidate] (1.449 ms) : 0, 1449
BytebuddyAgent [baseline] (706.288 ms) : 0, 706288
BytebuddyAgent [candidate] (706.066 ms) : 0, 706066
GlobalTracer [baseline] (248.403 ms) : 0, 248403
GlobalTracer [candidate] (248.604 ms) : 0, 248604
AppSec [baseline] (32.215 ms) : 0, 32215
AppSec [candidate] (32.241 ms) : 0, 32241
Debugger [baseline] (63.331 ms) : 0, 63331
Debugger [candidate] (63.032 ms) : 0, 63032
Remote Config [baseline] (630.676 µs) : 0, 631
Remote Config [candidate] (632.159 µs) : 0, 632
Telemetry [baseline] (8.122 ms) : 0, 8122
Telemetry [candidate] (8.116 ms) : 0, 8116
Flare Poller [baseline] (3.64 ms) : 0, 3640
Flare Poller [candidate] (3.642 ms) : 0, 3642
section iast
crashtracking [baseline] (1.448 ms) : 0, 1448
crashtracking [candidate] (1.456 ms) : 0, 1456
BytebuddyAgent [baseline] (828.88 ms) : 0, 828880
BytebuddyAgent [candidate] (830.754 ms) : 0, 830754
GlobalTracer [baseline] (237.615 ms) : 0, 237615
GlobalTracer [candidate] (238.953 ms) : 0, 238953
AppSec [baseline] (32.325 ms) : 0, 32325
AppSec [candidate] (33.089 ms) : 0, 33089
Debugger [baseline] (60.327 ms) : 0, 60327
Debugger [candidate] (60.535 ms) : 0, 60535
Remote Config [baseline] (549.478 µs) : 0, 549
Remote Config [candidate] (545.709 µs) : 0, 546
Telemetry [baseline] (7.688 ms) : 0, 7688
Telemetry [candidate] (7.694 ms) : 0, 7694
Flare Poller [baseline] (3.482 ms) : 0, 3482
Flare Poller [candidate] (3.494 ms) : 0, 3494
IAST [baseline] (29.183 ms) : 0, 29183
IAST [candidate] (28.556 ms) : 0, 28556
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 2 performance regressions! Performance is the same for 15 metrics, 18 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~a08227c1bb, baseline=1.56.0-SNAPSHOT~640a4bd02b
dateFormat X
axisFormat %s
section baseline
no_agent (1.251 ms) : 1238, 1264
. : milestone, 1251,
iast (3.299 ms) : 3231, 3367
. : milestone, 3299,
iast_FULL (5.711 ms) : 5638, 5785
. : milestone, 5711,
iast_GLOBAL (3.642 ms) : 3489, 3795
. : milestone, 3642,
profiling (1.916 ms) : 1900, 1932
. : milestone, 1916,
tracing (1.846 ms) : 1828, 1864
. : milestone, 1846,
section candidate
no_agent (1.191 ms) : 1179, 1203
. : milestone, 1191,
iast (3.22 ms) : 3148, 3293
. : milestone, 3220,
iast_FULL (5.861 ms) : 5802, 5921
. : milestone, 5861,
iast_GLOBAL (3.834 ms) : 3733, 3936
. : milestone, 3834,
profiling (1.968 ms) : 1951, 1984
. : milestone, 1968,
tracing (1.788 ms) : 1774, 1803
. : milestone, 1788,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~a08227c1bb, baseline=1.56.0-SNAPSHOT~640a4bd02b
dateFormat X
axisFormat %s
section baseline
no_agent (17.558 ms) : 17377, 17740
. : milestone, 17558,
appsec (18.454 ms) : 18266, 18642
. : milestone, 18454,
code_origins (17.72 ms) : 17543, 17897
. : milestone, 17720,
iast (18.537 ms) : 18349, 18724
. : milestone, 18537,
profiling (19.547 ms) : 19355, 19739
. : milestone, 19547,
tracing (17.671 ms) : 17495, 17847
. : milestone, 17671,
section candidate
no_agent (18.362 ms) : 18175, 18548
. : milestone, 18362,
appsec (18.706 ms) : 18517, 18894
. : milestone, 18706,
code_origins (17.61 ms) : 17439, 17781
. : milestone, 17610,
iast (17.662 ms) : 17487, 17837
. : milestone, 17662,
profiling (19.715 ms) : 19516, 19914
. : milestone, 19715,
tracing (17.378 ms) : 17205, 17550
. : milestone, 17378,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~a08227c1bb, baseline=1.56.0-SNAPSHOT~640a4bd02b
dateFormat X
axisFormat %s
section baseline
no_agent (15.215 s) : 15215000, 15215000
. : milestone, 15215000,
appsec (14.804 s) : 14804000, 14804000
. : milestone, 14804000,
iast (18.27 s) : 18270000, 18270000
. : milestone, 18270000,
iast_GLOBAL (18.075 s) : 18075000, 18075000
. : milestone, 18075000,
profiling (15.032 s) : 15032000, 15032000
. : milestone, 15032000,
tracing (15.46 s) : 15460000, 15460000
. : milestone, 15460000,
section candidate
no_agent (15.065 s) : 15065000, 15065000
. : milestone, 15065000,
appsec (14.553 s) : 14553000, 14553000
. : milestone, 14553000,
iast (18.687 s) : 18687000, 18687000
. : milestone, 18687000,
iast_GLOBAL (17.779 s) : 17779000, 17779000
. : milestone, 17779000,
profiling (14.836 s) : 14836000, 14836000
. : milestone, 14836000,
tracing (14.54 s) : 14540000, 14540000
. : milestone, 14540000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~a08227c1bb, baseline=1.56.0-SNAPSHOT~640a4bd02b
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1462, 1485
. : milestone, 1474,
appsec (3.699 ms) : 3480, 3918
. : milestone, 3699,
iast (2.216 ms) : 2152, 2280
. : milestone, 2216,
iast_GLOBAL (2.258 ms) : 2194, 2322
. : milestone, 2258,
profiling (2.075 ms) : 2022, 2128
. : milestone, 2075,
tracing (2.03 ms) : 1980, 2080
. : milestone, 2030,
section candidate
no_agent (1.47 ms) : 1458, 1481
. : milestone, 1470,
appsec (2.464 ms) : 2413, 2516
. : milestone, 2464,
iast (2.213 ms) : 2148, 2277
. : milestone, 2213,
iast_GLOBAL (2.259 ms) : 2195, 2323
. : milestone, 2259,
profiling (2.054 ms) : 2003, 2106
. : milestone, 2054,
tracing (2.038 ms) : 1987, 2088
. : milestone, 2038,
|
What Does This Do
Simplify the
create-release-branchworkflow such that it only creates the release branch.Delete the
update-system-teststrust policy, as it's no longer needed with the simplified workflow.Motivation
Given the many failed attempts (of which the most recent was #9942 with the same Resource not accessible by integration error) to include automation for creating a PR that pins system tests, perhaps that step is best left to be manually run. I updated the release guide with all relevant steps as well.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: https://datadoghq.atlassian.net/browse/APMLP-598