Replace groovy.servlet with javax.servlet to reduce dependency on Groovy.
#9957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexeyKuznetsov-DD
requested review from
PerfectSlayer,
amarziali,
bric3 and
sarahchen6
AlexeyKuznetsov-DD
added
comp: testing
sarahchen6
approved these changes
Nov 13, 2025
Contributor
sarahchen6
left a comment
sarahchen6
left a comment
There was a problem hiding this comment.
LGTM. Perhaps others would have more insight into why we have the Groovy servlet though
amarziali
approved these changes
Nov 14, 2025
bric3
approved these changes
Nov 14, 2025
AlexeyKuznetsov-DD
deleted the
alexeyk/groovy_servlet-to-javax_servlet
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Replace
groovy.servlet.AbstractHttpServletwithjavax.servlet.HttpServlet.Motivation
Reduce dependency on Groovy.
Additional Notes
Found no evidence that we need to use groovy servlet.