Add support for DD_THIRD_PARTY_DETECTION_* #9963
Merged
+16
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
need to align with others tracers
jpbempel
added
type: enhancement
|
🎯 Code Coverage 🔗 Commit SHA: 457248b | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 5 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.56.0-SNAPSHOT~457248bd36, baseline=1.56.0-SNAPSHOT~8ceb94de51
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.1 s) : 0, 1100163
Total [baseline] (8.836 s) : 0, 8835710
Agent [candidate] (1.097 s) : 0, 1097326
Total [candidate] (8.807 s) : 0, 8807284
section iast
Agent [baseline] (1.231 s) : 0, 1231043
Total [baseline] (9.531 s) : 0, 9530662
Agent [candidate] (1.244 s) : 0, 1243906
Total [candidate] (9.572 s) : 0, 9572122
gantt
title insecure-bank - break down per module: candidate=1.56.0-SNAPSHOT~457248bd36, baseline=1.56.0-SNAPSHOT~8ceb94de51
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.449 ms) : 0, 1449
crashtracking [candidate] (1.449 ms) : 0, 1449
BytebuddyAgent [baseline] (707.206 ms) : 0, 707206
BytebuddyAgent [candidate] (704.731 ms) : 0, 704731
GlobalTracer [baseline] (248.415 ms) : 0, 248415
GlobalTracer [candidate] (248.376 ms) : 0, 248376
AppSec [baseline] (32.323 ms) : 0, 32323
AppSec [candidate] (32.263 ms) : 0, 32263
Debugger [baseline] (63.571 ms) : 0, 63571
Debugger [candidate] (63.399 ms) : 0, 63399
Remote Config [baseline] (654.061 µs) : 0, 654
Remote Config [candidate] (620.837 µs) : 0, 621
Telemetry [baseline] (8.13 ms) : 0, 8130
Telemetry [candidate] (8.15 ms) : 0, 8150
Flare Poller [baseline] (3.719 ms) : 0, 3719
Flare Poller [candidate] (3.624 ms) : 0, 3624
section iast
crashtracking [baseline] (1.447 ms) : 0, 1447
crashtracking [candidate] (1.469 ms) : 0, 1469
BytebuddyAgent [baseline] (825.339 ms) : 0, 825339
BytebuddyAgent [candidate] (834.897 ms) : 0, 834897
GlobalTracer [baseline] (236.91 ms) : 0, 236910
GlobalTracer [candidate] (238.688 ms) : 0, 238688
AppSec [baseline] (34.115 ms) : 0, 34115
AppSec [candidate] (33.296 ms) : 0, 33296
Debugger [baseline] (59.592 ms) : 0, 59592
Debugger [candidate] (60.662 ms) : 0, 60662
Remote Config [baseline] (538.034 µs) : 0, 538
Remote Config [candidate] (547.699 µs) : 0, 548
Telemetry [baseline] (7.619 ms) : 0, 7619
Telemetry [candidate] (7.709 ms) : 0, 7709
Flare Poller [baseline] (3.448 ms) : 0, 3448
Flare Poller [candidate] (3.516 ms) : 0, 3516
IAST [baseline] (27.347 ms) : 0, 27347
IAST [candidate] (28.335 ms) : 0, 28335
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.56.0-SNAPSHOT~457248bd36, baseline=1.56.0-SNAPSHOT~8ceb94de51
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.099 s) : 0, 1098566
Total [baseline] (10.737 s) : 0, 10737086
Agent [candidate] (1.106 s) : 0, 1105603
Total [candidate] (10.826 s) : 0, 10826036
section appsec
Agent [baseline] (1.284 s) : 0, 1284184
Total [baseline] (11.095 s) : 0, 11094854
Agent [candidate] (1.278 s) : 0, 1278231
Total [candidate] (11.065 s) : 0, 11064824
section iast
Agent [baseline] (1.241 s) : 0, 1241428
Total [baseline] (11.265 s) : 0, 11264936
Agent [candidate] (1.239 s) : 0, 1238787
Total [candidate] (11.298 s) : 0, 11297874
section profiling
Agent [baseline] (1.227 s) : 0, 1227183
Total [baseline] (11.039 s) : 0, 11038633
Agent [candidate] (1.229 s) : 0, 1229437
Total [candidate] (11.128 s) : 0, 11127616
gantt
title petclinic - break down per module: candidate=1.56.0-SNAPSHOT~457248bd36, baseline=1.56.0-SNAPSHOT~8ceb94de51
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.451 ms) : 0, 1451
crashtracking [candidate] (1.456 ms) : 0, 1456
BytebuddyAgent [baseline] (704.469 ms) : 0, 704469
BytebuddyAgent [candidate] (709.892 ms) : 0, 709892
GlobalTracer [baseline] (248.65 ms) : 0, 248650
GlobalTracer [candidate] (250.182 ms) : 0, 250182
AppSec [baseline] (32.285 ms) : 0, 32285
AppSec [candidate] (32.464 ms) : 0, 32464
Debugger [baseline] (64.63 ms) : 0, 64630
Debugger [candidate] (64.261 ms) : 0, 64261
Remote Config [baseline] (637.353 µs) : 0, 637
Remote Config [candidate] (641.364 µs) : 0, 641
Telemetry [baseline] (8.146 ms) : 0, 8146
Telemetry [candidate] (8.244 ms) : 0, 8244
Flare Poller [baseline] (3.684 ms) : 0, 3684
Flare Poller [candidate] (3.743 ms) : 0, 3743
section appsec
crashtracking [baseline] (1.455 ms) : 0, 1455
crashtracking [candidate] (1.444 ms) : 0, 1444
BytebuddyAgent [baseline] (731.8 ms) : 0, 731800
BytebuddyAgent [candidate] (729.52 ms) : 0, 729520
GlobalTracer [baseline] (241.204 ms) : 0, 241204
GlobalTracer [candidate] (240.565 ms) : 0, 240565
IAST [baseline] (25.077 ms) : 0, 25077
IAST [candidate] (24.827 ms) : 0, 24827
AppSec [baseline] (175.301 ms) : 0, 175301
AppSec [candidate] (173.604 ms) : 0, 173604
Debugger [baseline] (61.625 ms) : 0, 61625
Debugger [candidate] (60.805 ms) : 0, 60805
Remote Config [baseline] (728.33 µs) : 0, 728
Remote Config [candidate] (751.192 µs) : 0, 751
Telemetry [baseline] (8.285 ms) : 0, 8285
Telemetry [candidate] (8.19 ms) : 0, 8190
Flare Poller [baseline] (3.923 ms) : 0, 3923
Flare Poller [candidate] (3.825 ms) : 0, 3825
section iast
crashtracking [baseline] (1.465 ms) : 0, 1465
crashtracking [candidate] (1.455 ms) : 0, 1455
BytebuddyAgent [baseline] (832.049 ms) : 0, 832049
BytebuddyAgent [candidate] (831.224 ms) : 0, 831224
GlobalTracer [baseline] (238.994 ms) : 0, 238994
GlobalTracer [candidate] (237.47 ms) : 0, 237470
IAST [baseline] (30.878 ms) : 0, 30878
IAST [candidate] (29.85 ms) : 0, 29850
AppSec [baseline] (30.559 ms) : 0, 30559
AppSec [candidate] (31.39 ms) : 0, 31390
Debugger [baseline] (60.986 ms) : 0, 60986
Debugger [candidate] (60.976 ms) : 0, 60976
Remote Config [baseline] (548.303 µs) : 0, 548
Remote Config [candidate] (557.345 µs) : 0, 557
Telemetry [baseline] (7.627 ms) : 0, 7627
Telemetry [candidate] (7.643 ms) : 0, 7643
Flare Poller [baseline] (3.489 ms) : 0, 3489
Flare Poller [candidate] (3.434 ms) : 0, 3434
section profiling
crashtracking [baseline] (1.425 ms) : 0, 1425
crashtracking [candidate] (1.435 ms) : 0, 1435
BytebuddyAgent [baseline] (729.917 ms) : 0, 729917
BytebuddyAgent [candidate] (729.959 ms) : 0, 729959
GlobalTracer [baseline] (221.904 ms) : 0, 221904
GlobalTracer [candidate] (222.414 ms) : 0, 222414
AppSec [baseline] (32.203 ms) : 0, 32203
AppSec [candidate] (32.39 ms) : 0, 32390
Debugger [baseline] (62.928 ms) : 0, 62928
Debugger [candidate] (63.378 ms) : 0, 63378
Remote Config [baseline] (657.654 µs) : 0, 658
Remote Config [candidate] (642.344 µs) : 0, 642
Telemetry [baseline] (7.972 ms) : 0, 7972
Telemetry [candidate] (8.022 ms) : 0, 8022
Flare Poller [baseline] (3.83 ms) : 0, 3830
Flare Poller [candidate] (3.795 ms) : 0, 3795
ProfilingAgent [baseline] (96.856 ms) : 0, 96856
ProfilingAgent [candidate] (97.869 ms) : 0, 97869
Profiling [baseline] (97.451 ms) : 0, 97451
Profiling [candidate] (98.46 ms) : 0, 98460
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 3 performance regressions! Performance is the same for 16 metrics, 17 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~457248bd36, baseline=1.56.0-SNAPSHOT~8ceb94de51
dateFormat X
axisFormat %s
section baseline
no_agent (1.18 ms) : 1168, 1191
. : milestone, 1180,
iast (3.145 ms) : 3103, 3188
. : milestone, 3145,
iast_FULL (5.955 ms) : 5896, 6014
. : milestone, 5955,
iast_GLOBAL (3.561 ms) : 3509, 3614
. : milestone, 3561,
profiling (1.98 ms) : 1963, 1997
. : milestone, 1980,
tracing (1.81 ms) : 1794, 1827
. : milestone, 1810,
section candidate
no_agent (1.172 ms) : 1161, 1183
. : milestone, 1172,
iast (3.29 ms) : 3253, 3327
. : milestone, 3290,
iast_FULL (5.963 ms) : 5903, 6023
. : milestone, 5963,
iast_GLOBAL (3.631 ms) : 3565, 3698
. : milestone, 3631,
profiling (2.151 ms) : 2131, 2171
. : milestone, 2151,
tracing (1.815 ms) : 1800, 1830
. : milestone, 1815,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~457248bd36, baseline=1.56.0-SNAPSHOT~8ceb94de51
dateFormat X
axisFormat %s
section baseline
no_agent (17.941 ms) : 17760, 18121
. : milestone, 17941,
appsec (18.668 ms) : 18480, 18855
. : milestone, 18668,
code_origins (17.416 ms) : 17242, 17590
. : milestone, 17416,
iast (17.864 ms) : 17687, 18041
. : milestone, 17864,
profiling (18.866 ms) : 18674, 19057
. : milestone, 18866,
tracing (17.516 ms) : 17344, 17688
. : milestone, 17516,
section candidate
no_agent (19.083 ms) : 18886, 19280
. : milestone, 19083,
appsec (18.765 ms) : 18576, 18955
. : milestone, 18765,
code_origins (17.862 ms) : 17684, 18041
. : milestone, 17862,
iast (17.872 ms) : 17697, 18047
. : milestone, 17872,
profiling (19.607 ms) : 19407, 19806
. : milestone, 19607,
tracing (17.699 ms) : 17524, 17874
. : milestone, 17699,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~457248bd36, baseline=1.56.0-SNAPSHOT~8ceb94de51
dateFormat X
axisFormat %s
section baseline
no_agent (15.535 s) : 15535000, 15535000
. : milestone, 15535000,
appsec (14.686 s) : 14686000, 14686000
. : milestone, 14686000,
iast (18.64 s) : 18640000, 18640000
. : milestone, 18640000,
iast_GLOBAL (18.155 s) : 18155000, 18155000
. : milestone, 18155000,
profiling (14.926 s) : 14926000, 14926000
. : milestone, 14926000,
tracing (14.569 s) : 14569000, 14569000
. : milestone, 14569000,
section candidate
no_agent (15.013 s) : 15013000, 15013000
. : milestone, 15013000,
appsec (14.718 s) : 14718000, 14718000
. : milestone, 14718000,
iast (17.996 s) : 17996000, 17996000
. : milestone, 17996000,
iast_GLOBAL (17.909 s) : 17909000, 17909000
. : milestone, 17909000,
profiling (14.633 s) : 14633000, 14633000
. : milestone, 14633000,
tracing (14.705 s) : 14705000, 14705000
. : milestone, 14705000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~457248bd36, baseline=1.56.0-SNAPSHOT~8ceb94de51
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1463, 1486
. : milestone, 1474,
appsec (3.639 ms) : 3426, 3853
. : milestone, 3639,
iast (2.21 ms) : 2146, 2273
. : milestone, 2210,
iast_GLOBAL (2.262 ms) : 2198, 2326
. : milestone, 2262,
profiling (2.478 ms) : 2320, 2637
. : milestone, 2478,
tracing (2.024 ms) : 1975, 2074
. : milestone, 2024,
section candidate
no_agent (1.476 ms) : 1464, 1487
. : milestone, 1476,
appsec (3.659 ms) : 3441, 3877
. : milestone, 3659,
iast (2.218 ms) : 2154, 2282
. : milestone, 2218,
iast_GLOBAL (2.249 ms) : 2185, 2314
. : milestone, 2249,
profiling (2.085 ms) : 2032, 2138
. : milestone, 2085,
tracing (2.03 ms) : 1980, 2080
. : milestone, 2030,
|
| } | ||
|
|
||
| public List<String> getList(String key, List<String> defaultValue) { | ||
| public List<String> getList(String key, List<String> defaultValue, String... aliases) { |
Contributor
There was a problem hiding this comment.
❔ question: Isn't this change going to allocate an empty array for all calls?
Member
Author
There was a problem hiding this comment.
true, but not different from
https://github.com/DataDog/dd-trace-java/blob/master/utils/config-utils/src/main/java/datadog/trace/bootstrap/config/provider/ConfigProvider.java#L73
/**
* Gets a string value with a default fallback and optional aliases. Use for configs with
* meaningful defaults. Reports default to telemetry.
*/
public String getString(String key, String defaultValue, String... aliases) {
if (collectConfig) {
reportDefault(key, defaultValue);
}
String value = getStringInternal(key, aliases);
return value != null ? value : defaultValue;
}
Contributor
There was a problem hiding this comment.
Agree! We might review it in a separate PR then 👌
PerfectSlayer
approved these changes
Nov 18, 2025
jpbempel
added
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
need to align with others tracers
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: DEBUG-4743