Skip to content

Use ClassFile parser when pre-loading class hierarchies #9969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2025
Merged

Use ClassFile parser when pre-loading class hierarchies #9969

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions ...tooling/src/main/java/datadog/trace/agent/tooling/bytebuddy/memoize/PreloadHierarchy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
package datadog.trace.agent.tooling.bytebuddy.memoize;

import datadog.instrument.classmatch.ClassFile;
import datadog.instrument.classmatch.ClassHeader;
import datadog.trace.bootstrap.instrumentation.classloading.ClassDefining;
import net.bytebuddy.jar.asm.ClassReader;

/** Ensures superclasses and interfaces are loaded before classes that extend/implement them. */
final class PreloadHierarchy implements ClassDefining.Observer {
Expand All @@ -22,12 +23,12 @@ public void beforeDefineClass(ClassLoader loader, byte[] bytecode, int offset, i
return; // ignore non-standard formats like J9 ROMs
}
// minimal parsing of bytecode to get name of superclass and any interfaces
ClassReader cr = new ClassReader(bytecode, offset, length);
String superName = cr.getSuperName();
ClassHeader header = ClassFile.header(bytecode, offset);
String superName = header.superName;
if (null != superName && !"java/lang/Object".equals(superName)) {
preload(loader, superName);
}
for (String interfaceName : cr.getInterfaces()) {
for (String interfaceName : header.interfaces) {
preload(loader, interfaceName);
}
} catch (Throwable ignore) {
Expand Down