-
Notifications
You must be signed in to change notification settings - Fork 360
Open
Labels
Description
Package Name
No response
Package Version(s)
5.10.0
Describe the feature you'd like
Hi everyone,
We are using this library to trace our NodeJS service request, and noticed that inferred redis name on span is resolved to db.name: "0" which looks more like a placeholder - here
here is the screenshot of one of the ioredis spans:
Maybe it could be more interesting to reuse same approach as redis integration in PHP library and use peer.hostname instead.
Is your feature request related to a problem?
it's not a huge problem, but rather an inconvenience when on dependency map you can't clearly see which redis instance it is and we see just a placeholder instead
Describe alternatives you've considered
Alternative would probably be to use hook and try to intercept redis span and change service name which may be probably treated as override
Additional context
No response
dejan-lukic, cailen, mwadel-cu and JayJamieson