-
Notifications
You must be signed in to change notification settings - Fork 360
Description
Package Name
datadog-plugin-playwright
Package Version(s)
No response
Describe the feature you'd like
How it works now
Playwright does support a lower level breakdown within scenarios called [test.step].(https://playwright.dev/docs/api/class-test#test-step). Currently the error messages throwing within this closure are not reported via dd-trace in searchable manner. Even though the span is visible in Trace view the search input in Test Runs doesn't allow for finding it. Similarly the Table view doesn't allow for breaking the results down by these values which limits the analytics capabilities.
Relevant code:
dd-trace-js/packages/datadog-plugin-playwright/src/index.js
Lines 323 to 331 in 837bef3
| const stepSpan = this.tracer.startSpan('playwright.step', { | |
| childOf: span, | |
| startTime: stepStartTime, | |
| tags: { | |
| [COMPONENT]: this.constructor.id, | |
| 'playwright.step': step.title, | |
| [RESOURCE_NAME]: step.title | |
| } | |
| }) |
How it could work in future
playwright.step error message could get surfaced alongside existing Other Tags
Is your feature request related to a problem?
No response
Describe alternatives you've considered
No response
Additional context
I'd be willing to submit a PR based on minimal set of suggestions and pointers towards a desired solution 👋
