Skip to content

Conversation

@rochdev
Copy link
Member

@rochdev rochdev commented Mar 27, 2025

  • [120b6b081b] - (SEMVER-PATCH) fix duplicate custom metrics when multiple tags are used (Roch Devost) #5491
  • [e4bf59aa2a] - (SEMVER-MINOR) report rc.client_id tag when rc is enabled (Ilyas Shabi) #5467
  • [762e2cf956] - (SEMVER-MINOR) add sdk.event to communicate a login or custom event (Ilyas Shabi) #5462
  • [50b53548f2] - (SEMVER-PATCH) add matrix strategy to debugger ci job (Roch Devost) #5450
  • [0ceef34fc7] - (SEMVER-MINOR) chore(llmobs): add telemetry metrics for dropped span/eval payloads (Yun Kim) #5469
  • [04f6bc4bc9] - (SEMVER-MINOR) chore(llmobs): Add llmobs product enabled telemetry metrics (Yun Kim) #5475
  • [312a500fc9] - (SEMVER-PATCH) chore(langchain): fix test flakiness (Sam Brenner) #5461

sabrenner and others added 8 commits March 27, 2025 12:30
* try timeout increase

* add logging for debugging ci

* more logging

* remove problematic test altogether

* remove console.log stmts

* remove extra timeout

* Update packages/datadog-plugin-langchain/test/index.spec.js
* Add product_enabled metric, need to add tags

* Add llmobs enabled metrics - wip, add more tags

* Add manual flag

* Use env var check

* Allow optional envs

* fmt
…5469)

* Add raw span size metric

* Add processed span event size metrics

* Refactor

* Add dropped payload telemetry metric

* fmt

* lint, add record for full buffer
* add sdk.event to communicate a login or custom event

* change sdk version to v1
* report rc.client_id tag when rc is enabled

* report client id within rc manager

* add integration test

* linter

* remove getClientId from test

* Update packages/dd-trace/test/remote_config/rc-client_id.spec.js

---------

Co-authored-by: simon-id <simon.id@datadoghq.com>
@codecov
Copy link

codecov bot commented Mar 27, 2025

Codecov Report

Attention: Patch coverage is 91.48936% with 8 lines in your changes missing coverage. Please review.

Please upload report for BASE (v5.x@f2a38c1). Learn more about missing BASE report.

Files with missing lines Patch % Lines
packages/dd-trace/src/llmobs/telemetry.js 55.55% 4 Missing ⚠️
packages/dd-trace/src/llmobs/writers/base.js 25.00% 3 Missing ⚠️
packages/dd-trace/src/histogram.js 88.88% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             v5.x    #5495   +/-   ##
=======================================
  Coverage        ?   79.20%           
=======================================
  Files           ?      513           
  Lines           ?    23124           
  Branches        ?        0           
=======================================
  Hits            ?    18315           
  Misses          ?     4809           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link

pr-commenter bot commented Mar 27, 2025

Benchmarks

Benchmark execution time: 2025-03-27 16:44:48

Comparing candidate commit e2dd67b in PR branch v5.45.0-proposal with baseline commit f2a38c1 in branch v5.x.

Found 0 performance improvements and 10 performance regressions! Performance is the same for 938 metrics, 15 unstable metrics.

scenario:runtime-metrics-with-runtime-metrics-18

  • 🟥 cpu_user_time [+21.438ms; +40.490ms] or [+5.792%; +10.940%]
  • 🟥 instructions [+91.7M instructions; +99.8M instructions] or [+9.735%; +10.593%]

scenario:runtime-metrics-with-runtime-metrics-20

  • 🟥 cpu_usage_percentage [+5.619%; +6.240%]
  • 🟥 cpu_user_time [+59.470ms; +82.271ms] or [+14.393%; +19.911%]
  • 🟥 instructions [+89.9M instructions; +106.9M instructions] or [+9.591%; +11.412%]
  • 🟥 max_rss_usage [+4.443MB; +6.174MB] or [+6.172%; +8.577%]

scenario:runtime-metrics-with-runtime-metrics-22

  • 🟥 cpu_usage_percentage [+5.531%; +6.296%]
  • 🟥 cpu_user_time [+62.310ms; +74.694ms] or [+16.789%; +20.126%]
  • 🟥 instructions [+112.6M instructions; +125.4M instructions] or [+11.411%; +12.708%]
  • 🟥 max_rss_usage [+7.361MB; +8.275MB] or [+9.154%; +10.291%]

@rochdev rochdev marked this pull request as ready for review March 27, 2025 17:35
@rochdev rochdev requested a review from a team as a code owner March 27, 2025 17:35
@github-actions
Copy link

Overall package size

Self size: 9.11 MB
Deduped: 101.64 MB
No deduping: 102.16 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.5.0 | 29.83 MB | 29.83 MB | | @datadog/native-appsec | 8.5.1 | 19.26 MB | 19.27 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.6.0 | 9.79 MB | 10.16 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.4.0 | 2.77 MB | 5.42 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.13.1 | 117.64 kB | 839.26 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | dc-polyfill | 0.1.6 | 24.56 kB | 24.56 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@datadog-datadog-prod-us1
Copy link

Datadog Report

Branch report: v5.45.0-proposal
Commit report: 0754c37
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 917 Passed, 0 Skipped, 12m 52.03s Total Time

@rochdev rochdev merged commit 8471baa into v5.x Mar 27, 2025
430 checks passed
@rochdev rochdev deleted the v5.45.0-proposal branch March 27, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants