Skip to content

Conversation

@watson
Copy link
Collaborator

@watson watson commented Mar 28, 2025

What does this PR do?

As the title says :)

Motivation

There's a race condition in Node.js 18 that these tests sometimes trigger when requiring the async_hooks module.

Once #5357 is merged, this PR can be reverted.

Plugin Checklist

Additional Notes

There's a race condition in Node.js 18 that these tests sometimes
trigger when requiring the `async_hooks` module.

Once #5357 is merged, this
commit can be reverted.
@watson watson requested a review from a team as a code owner March 28, 2025 09:57
@watson watson self-assigned this Mar 28, 2025
Copy link
Collaborator Author

watson commented Mar 28, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@watson watson added semver-patch debugger Dynamic Instrumentation & Live Debugger labels Mar 28, 2025
@watson watson changed the title Temporarily disable the Node.js 18 Debugger tests [DI] Temporarily disable the Node.js 18 Debugger tests Mar 28, 2025
@github-actions
Copy link

Overall package size

Self size: 9.11 MB
Deduped: 101.64 MB
No deduping: 102.16 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.5.0 | 29.83 MB | 29.83 MB | | @datadog/native-appsec | 8.5.1 | 19.26 MB | 19.27 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.6.0 | 9.79 MB | 10.16 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.4.0 | 2.77 MB | 5.42 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.13.1 | 117.64 kB | 839.26 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | dc-polyfill | 0.1.6 | 24.56 kB | 24.56 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented Mar 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.20%. Comparing base (120b6b0) to head (c854564).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5498      +/-   ##
==========================================
- Coverage   79.26%   79.20%   -0.07%     
==========================================
  Files         513      512       -1     
  Lines       23183    23111      -72     
==========================================
- Hits        18377    18305      -72     
  Misses       4806     4806              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-datadog-prod-us1
Copy link

Datadog Report

Branch report: watson/disable-node18-debugger-tests
Commit report: fcf0b30
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 924 Passed, 0 Skipped, 15m 5.71s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Mar 28, 2025

Benchmarks

Benchmark execution time: 2025-03-28 10:10:02

Comparing candidate commit c854564 in PR branch watson/disable-node18-debugger-tests with baseline commit 120b6b0 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 946 metrics, 17 unstable metrics.

Copy link
Collaborator

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest Node.js release includes a fix. As soon as the CI installs the latest version, it's going to also be resolved. I don't think we need this therefore.
Right now, the cache is still hit. Seems like we do not automatically check for latest versions.

@watson watson closed this Mar 29, 2025
@watson watson deleted the watson/disable-node18-debugger-tests branch March 29, 2025 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

debugger Dynamic Instrumentation & Live Debugger semver-patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants