-
Notifications
You must be signed in to change notification settings - Fork 364
[test optimization] Add automatic NX service detection #7231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BenchmarksBenchmark execution time: 2026-01-19 12:54:06 Comparing candidate commit 5afa390 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 291 metrics, 29 unstable metrics. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7231 +/- ##
==========================================
+ Coverage 84.87% 85.19% +0.32%
==========================================
Files 532 532
Lines 22654 22788 +134
==========================================
+ Hits 19227 19414 +187
+ Misses 3427 3374 -53 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Overall package sizeSelf size: 4.4 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 2.0.0 | 68.46 kB | 797.03 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
c2536a6 to
b0cb7ec
Compare
This comment has been minimized.
This comment has been minimized.
BridgeAR
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather not add the new DD_ env. Do we have to add that?
|
Hello 😄 I think this could be a bit confusing. Do we really need a flag to detect Nx? The existence of Is the goal to let the consumer decide whether to use it or not? If so, I’d name it something like If we want the service name to default to the Nx project name, we can always read Also, |
hey thanks for the feedback. We will use We're going to ship a breaking change in v6 though, removing the need for passing
We've decided not to support |
What does this PR do?
process.env. DD_ENABLE_NX_SERVICE_NAMEandprocess.env.NX_TASK_TARGET_PROJECTare both set and the user hasn't configured test service in any other way,serviceis set toprocess.env.NX_TASK_TARGET_PROJECTMotivation
Make it simpler for
nxusers to set an automatic test service whennxis testing multiple different projects.Plugin Checklist