feat(process-tags): Propagate Service Naming Context via Process Tags#7762
Merged
pabloerhard merged 8 commits intomasterfrom Mar 16, 2026
Merged
feat(process-tags): Propagate Service Naming Context via Process Tags#7762pabloerhard merged 8 commits intomasterfrom
pabloerhard merged 8 commits intomasterfrom
Conversation
Contributor
Overall package sizeSelf size: 4.96 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.0.0 | 81.15 kB | 815.98 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7762 +/- ##
==========================================
+ Coverage 80.39% 80.44% +0.05%
==========================================
Files 741 741
Lines 32087 32170 +83
==========================================
+ Hits 25795 25878 +83
Misses 6292 6292
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
✨ Fix all issues with BitsAI or with Cursor
|
BenchmarksBenchmark execution time: 2026-03-12 16:32:16 Comparing candidate commit 204a5e1 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 233 metrics, 27 unstable metrics. |
amarziali
approved these changes
Mar 13, 2026
Contributor
amarziali
left a comment
amarziali
left a comment
There was a problem hiding this comment.
Looks good to me from a functional standpoint. Thanks
tlhunter
reviewed
Mar 13, 2026
| if (config?.isServiceNameInferred) { | ||
| tags.push(['svc.auto', config.service]) | ||
| } else if (config) { | ||
| tags.push(['svc.user', true]) |
Member
There was a problem hiding this comment.
If process tags are used for renaming services would it ever make sense to have a value of "true"?
Contributor
Author
There was a problem hiding this comment.
I'm not sure I get what you mean? From my understanding whenever the user actually did the naming of the service, we intend to not do any renaming.
tlhunter
approved these changes
Mar 13, 2026
dd-octo-sts bot
pushed a commit
that referenced
this pull request
Mar 17, 2026
…#7762) * initial work for service naming process tag * reworked process tags implementation * lint fix * removed testing leftovers * fix grammar mistake * fix test being undefined * added missing inits * debugger fix
Merged
juan-fernandez
pushed a commit
that referenced
this pull request
Mar 18, 2026
…#7762) * initial work for service naming process tag * reworked process tags implementation * lint fix * removed testing leftovers * fix grammar mistake * fix test being undefined * added missing inits * debugger fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds configuration dependent process tags, specifically svc.auto:<default_service_name> and svc.user.
Whenever a user sets the service name, we need to set a process tag indicating that. In this case, svc.user would be set to true. Whenever service name is inferred by the tracer, we should set svc.auto:<default_service_name>, with <default_service_name> replaced by the inferred service name.
Motivation
Additional Notes
Some modifications were required to add configuration dependent process tags to the processTags object, since it was originally a singleton that initialized itself at require time, which happened before config was built.