Conversation
pabloerhard
changed the title
Overall package sizeSelf size: 5.5 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.0.1 | 82.56 kB | 817.39 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: 2e4d61a | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
BenchmarksBenchmark execution time: 2026-04-17 00:39:37 Comparing candidate commit 2e4d61a in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 1376 metrics, 108 unstable metrics. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8014 +/- ##
==========================================
- Coverage 73.60% 73.59% -0.01%
==========================================
Files 773 773
Lines 36084 36088 +4
==========================================
+ Hits 26558 26560 +2
- Misses 9526 9528 +2 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BridgeAR
left a comment
BridgeAR
left a comment
There was a problem hiding this comment.
Almost LGTM. I think we could just clean up some code a bit more :)
|
I updated the description so that the related issue will automatically close as resolved when this lands. |
BridgeAR
left a comment
BridgeAR
left a comment
There was a problem hiding this comment.
LGTM, thanks for the cleanup!
* added splitByInstance config for redis * added splitByInstance into redis declaration file * remove .only * use weakmap instead of adding properties to class * use assertObjectContains isntead of multiple asserts --------- Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>
2 participants
What does this PR do?
This PR adds splitByInstance config into the Redis plugin and solves #7914.
The service naming layer already had full support for splitByInstance on the redis plugin, (shared redisConfig with ioredis), so no schema changes were needed.
Fixes: #7914
Motivation
Additional Notes