switch back to hoisted linker for bun#8142
Conversation
Overall package sizeSelf size: 5.66 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.0.1 | 82.56 kB | 817.39 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: 1329a8b | Docs | Datadog PR Page | Give us feedback! |
BenchmarksBenchmark execution time: 2026-04-28 20:23:54 Comparing candidate commit 1329a8b in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 1342 metrics, 102 unstable metrics. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8142 +/- ##
==========================================
+ Coverage 73.53% 74.11% +0.58%
==========================================
Files 784 786 +2
Lines 36369 36400 +31
==========================================
+ Hits 26744 26979 +235
+ Misses 9625 9421 -204 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c689371d0d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| ...addOptions, | ||
| timeout: 90_000, | ||
| }) | ||
| execHelper(`${BUN} add ${cappedDependencies.join(' ')} ${addFlags.join(' ')}`, addOptions) |
There was a problem hiding this comment.
This call now runs even when dependencies is empty (the default path used by tests like integration-tests/init.spec.js via useSandbox()), so it executes bun add with no package argument. bun add --help documents Usage: bun add [flags] <package><@version>, and invoking it without a package emits error: no package specified to add; on Bun versions that return non-zero for this error, sandbox creation fails before tests run. Please skip this bun add invocation when cappedDependencies.length === 0.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
I believe we want it to fail in case no dependencies are found? So it should likely be fine, what do you think @rochdev?
There was a problem hiding this comment.
Some usage of sandbox don't have depedencies, so that's a valid use case. It doesn't crash either, it just outputs the help, so that's why everything is passing. Not the end of the world, but it would indeed be better to skip the line entirely instead so I will push a fix.
BridgeAR
left a comment
BridgeAR
left a comment
There was a problem hiding this comment.
LGTM, while we might want to look at the comment being brought up (I think that is actually totally acceptable or even wanted)
rochdev
changed the title
* skip unnecessary install when no dependencies are defined
* skip unnecessary install when no dependencies are defined
2 participants
What does this PR do?
Switch back to hoisted linker for bun.
Motivation
Bun 1.3 switched the default linker to isolated. However, it still has many unresolved issues even with the latest version, so it's safer to use the more robust hoisted linker until those issues are resolved to avoid flakiness.
Additional Notes