Skip to content

chore(node) allow node 26#8143

Merged
pabloerhard merged 2 commits intomasterfrom
pabloerhard/node-26
Apr 28, 2026
Merged

chore(node) allow node 26#8143
pabloerhard merged 2 commits intomasterfrom
pabloerhard/node-26

Conversation

@pabloerhard
Copy link
Copy Markdown
Contributor

What does this PR do?

Allow test to run with node 26

Motivation

Additional Notes

@datadog-prod-us1-5

This comment has been minimized.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.11%. Comparing base (6044071) to head (2824219).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8143      +/-   ##
==========================================
- Coverage   74.11%   74.11%   -0.01%     
==========================================
  Files         786      786              
  Lines       36400    36400              
==========================================
- Hits        26979    26978       -1     
- Misses       9421     9422       +1     
Flag Coverage Δ
aiguard-macos 36.38% <ø> (-0.09%) ⬇️
aiguard-ubuntu 36.49% <ø> (-0.09%) ⬇️
aiguard-windows 36.29% <ø> (-0.09%) ⬇️
apm-capabilities-tracing-macos 48.14% <ø> (ø)
apm-capabilities-tracing-ubuntu-active 48.17% <ø> (ø)
apm-capabilities-tracing-ubuntu-latest 48.14% <ø> (ø)
apm-capabilities-tracing-ubuntu-maintenance 48.17% <ø> (ø)
apm-capabilities-tracing-ubuntu-oldest 48.16% <ø> (ø)
apm-capabilities-tracing-windows 47.93% <ø> (+0.06%) ⬆️
apm-integrations-child-process 36.04% <ø> (-0.10%) ⬇️
apm-integrations-couchbase-18 35.04% <ø> (-0.12%) ⬇️
apm-integrations-couchbase-eol 35.09% <ø> (-0.09%) ⬇️
apm-integrations-oracledb 35.10% <ø> (-0.09%) ⬇️
appsec-express 52.73% <ø> (-0.10%) ⬇️
appsec-fastify 49.21% <ø> (-0.07%) ⬇️
appsec-graphql 49.50% <ø> (-0.07%) ⬇️
appsec-kafka 41.98% <ø> (-0.07%) ⬇️
appsec-ldapjs 41.31% <ø> (-0.08%) ⬇️
appsec-lodash 41.34% <ø> (-0.08%) ⬇️
appsec-macos 56.76% <ø> (-0.07%) ⬇️
appsec-mongodb-core 45.63% <ø> (-0.07%) ⬇️
appsec-mongoose 46.51% <ø> (-0.07%) ⬇️
appsec-mysql 48.69% <ø> (-0.07%) ⬇️
appsec-node-serialize 40.51% <ø> (-0.08%) ⬇️
appsec-passport 44.52% <ø> (-0.08%) ⬇️
appsec-postgres 48.28% <ø> (-0.07%) ⬇️
appsec-sourcing 40.01% <ø> (-0.08%) ⬇️
appsec-stripe 42.24% <ø> (-0.08%) ⬇️
appsec-template 40.68% <ø> (-0.08%) ⬇️
appsec-ubuntu 56.84% <ø> (-0.07%) ⬇️
appsec-windows 56.65% <ø> (-0.05%) ⬇️
instrumentations-instrumentation-bluebird 29.75% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-body-parser 37.64% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-child_process 35.41% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-cookie-parser 31.68% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-express 31.90% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-express-mongo-sanitize 31.80% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-express-session 37.27% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-fs 29.43% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-generic-pool 30.53% <ø> (ø)
instrumentations-instrumentation-http 36.88% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-knex 29.72% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-light-my-request 37.20% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-mongoose 30.82% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-multer 37.41% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-mysql2 35.38% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-passport 41.17% <ø> (-0.08%) ⬇️
instrumentations-instrumentation-passport-http 40.87% <ø> (-0.08%) ⬇️
instrumentations-instrumentation-passport-local 41.38% <ø> (-0.08%) ⬇️
instrumentations-instrumentation-pg 34.91% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-promise 29.68% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-promise-js 29.69% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-q 29.72% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-url 29.69% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-when 29.70% <ø> (-0.10%) ⬇️
llmobs-ai 38.35% <ø> (-0.09%) ⬇️
llmobs-anthropic 37.84% <ø> (-0.09%) ⬇️
llmobs-bedrock 37.06% <ø> (-0.08%) ⬇️
llmobs-google-genai 37.43% <ø> (-0.15%) ⬇️
llmobs-langchain 37.00% <ø> (-0.07%) ⬇️
llmobs-openai 41.18% <ø> (-0.08%) ⬇️
llmobs-vertex-ai 37.67% <ø> (-0.09%) ⬇️
platform-core 30.03% <ø> (ø)
platform-esbuild 32.83% <ø> (ø)
platform-instrumentations-misc 31.22% <ø> (ø)
platform-shimmer 35.72% <ø> (ø)
platform-unit-guardrails 31.39% <ø> (ø)
platform-webpack 20.73% <ø> (ø)
plugins-azure-durable-functions 25.36% <ø> (ø)
plugins-azure-event-hubs 25.51% <ø> (ø)
plugins-azure-service-bus 24.92% <ø> (ø)
plugins-bullmq 40.55% <ø> (-0.22%) ⬇️
plugins-cassandra 35.12% <ø> (-0.09%) ⬇️
plugins-cookie 26.47% <ø> (ø)
plugins-cookie-parser 26.28% <ø> (ø)
plugins-crypto 25.70% <ø> (ø)
plugins-dd-trace-api 35.35% <ø> (-0.09%) ⬇️
plugins-express-mongo-sanitize 26.42% <ø> (ø)
plugins-express-session 26.24% <ø> (ø)
plugins-fastify 39.25% <ø> (-0.09%) ⬇️
plugins-fetch 35.91% <ø> (+0.06%) ⬆️
plugins-fs 35.64% <ø> (-0.10%) ⬇️
plugins-generic-pool 25.40% <ø> (ø)
plugins-google-cloud-pubsub 42.99% <ø> (-0.08%) ⬇️
plugins-grpc 38.01% <ø> (-0.09%) ⬇️
plugins-handlebars 26.46% <ø> (ø)
plugins-hapi 37.25% <ø> (-0.22%) ⬇️
plugins-hono 37.50% <ø> (-0.09%) ⬇️
plugins-ioredis 35.68% <ø> (-0.09%) ⬇️
plugins-knex 26.14% <ø> (ø)
plugins-langgraph 35.03% <ø> (-0.09%) ⬇️
plugins-ldapjs 24.02% <ø> (ø)
plugins-light-my-request 25.88% <ø> (ø)
plugins-limitd-client 29.98% <ø> (-0.09%) ⬇️
plugins-lodash 25.47% <ø> (ø)
plugins-mariadb 36.55% <ø> (-0.09%) ⬇️
plugins-memcached 35.34% <ø> (-0.09%) ⬇️
plugins-microgateway-core 36.54% <ø> (+0.11%) ⬆️
plugins-modelcontextprotocol-sdk 34.27% <ø> (-0.09%) ⬇️
plugins-moleculer 38.03% <ø> (-0.09%) ⬇️
plugins-mongodb 36.50% <ø> (-0.09%) ⬇️
plugins-mongodb-core 36.13% <ø> (-0.09%) ⬇️
plugins-mongoose 36.01% <ø> (-0.09%) ⬇️
plugins-multer 26.24% <ø> (ø)
plugins-mysql 36.42% <ø> (-0.09%) ⬇️
plugins-mysql2 36.40% <ø> (-0.09%) ⬇️
plugins-node-serialize 26.51% <ø> (ø)
plugins-opensearch 35.00% <ø> (-0.09%) ⬇️
plugins-passport-http 26.30% <ø> (ø)
plugins-pino 31.78% <ø> (-0.09%) ⬇️
plugins-postgres 34.51% <ø> (+0.04%) ⬆️
plugins-process 25.70% <ø> (ø)
plugins-pug 26.47% <ø> (ø)
plugins-redis 35.89% <ø> (-0.09%) ⬇️
plugins-router 39.90% <ø> (+0.04%) ⬆️
plugins-sequelize 25.18% <ø> (ø)
plugins-test-and-upstream-amqp10 35.52% <ø> (-0.23%) ⬇️
plugins-test-and-upstream-amqplib 40.82% <ø> (-0.09%) ⬇️
plugins-test-and-upstream-apollo 36.51% <ø> (-0.08%) ⬇️
plugins-test-and-upstream-avsc 35.41% <ø> (-0.09%) ⬇️
plugins-test-and-upstream-bunyan 31.13% <ø> (-0.09%) ⬇️
plugins-test-and-upstream-connect 37.84% <ø> (-0.09%) ⬇️
plugins-test-and-upstream-graphql 37.18% <ø> (-0.09%) ⬇️
plugins-test-and-upstream-koa 37.45% <ø> (-0.09%) ⬇️
plugins-test-and-upstream-protobufjs 35.63% <ø> (-0.09%) ⬇️
plugins-test-and-upstream-rhea 40.92% <ø> (-0.07%) ⬇️
plugins-undici 36.51% <ø> (-0.09%) ⬇️
plugins-url 25.70% <ø> (ø)
plugins-valkey 35.36% <ø> (-0.08%) ⬇️
plugins-vm 25.70% <ø> (ø)
plugins-winston 31.58% <ø> (-0.09%) ⬇️
plugins-ws 38.97% <ø> (-0.09%) ⬇️
profiling-macos 39.20% <ø> (-0.09%) ⬇️
profiling-ubuntu 39.82% <ø> (+0.35%) ⬆️
profiling-windows 38.92% <ø> (-0.09%) ⬇️
serverless-azure-functions-client 25.25% <ø> (ø)
serverless-azure-functions-eventhubs 25.25% <ø> (ø)
serverless-azure-functions-servicebus 25.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 28, 2026

Overall package size

Self size: 5.66 MB
Deduped: 6.51 MB
No deduping: 6.51 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.0.1 | 82.56 kB | 817.39 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Apr 28, 2026

Benchmarks

Benchmark execution time: 2026-04-28 17:36:23

Comparing candidate commit 2824219 in PR branch pabloerhard/node-26 with baseline commit 6044071 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1346 metrics, 98 unstable metrics.

@pabloerhard pabloerhard marked this pull request as ready for review April 28, 2026 15:51
@pabloerhard pabloerhard requested a review from a team as a code owner April 28, 2026 15:51
@pabloerhard pabloerhard changed the title chore(node) test node 26 chore(node) allow node 26 Apr 28, 2026
Copy link
Copy Markdown
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think we should also change our CI jobs. I am actually uncertain how we will do this when we have v6 released. We pretty much need to use different test versions in our CI

@pabloerhard pabloerhard enabled auto-merge (squash) April 28, 2026 17:35
@pabloerhard pabloerhard merged commit a1d8a7f into master Apr 28, 2026
981 of 983 checks passed
@pabloerhard pabloerhard deleted the pabloerhard/node-26 branch April 28, 2026 17:47
dd-octo-sts Bot pushed a commit that referenced this pull request Apr 29, 2026
@dd-octo-sts dd-octo-sts Bot mentioned this pull request Apr 29, 2026
BridgeAR pushed a commit that referenced this pull request Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants