Skip to content

test: make sure unknown config entries cause an error#8152

Merged
BridgeAR merged 1 commit intomasterfrom
BridgeAR/2026-04-28-safer-config-values
Apr 29, 2026
Merged

test: make sure unknown config entries cause an error#8152
BridgeAR merged 1 commit intomasterfrom
BridgeAR/2026-04-28-safer-config-values

Conversation

@BridgeAR
Copy link
Copy Markdown
Member

Unknown configurations now have a test against being added to prevent unknown telemetry being reported.

Unknown configurations now have a test against being added to
prevent unknown telemetry being reported.
@github-actions
Copy link
Copy Markdown
Contributor

Overall package size

Self size: 5.66 MB
Deduped: 6.5 MB
No deduping: 6.5 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.0.1 | 82.56 kB | 817.39 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@datadog-datadog-prod-us1-2
Copy link
Copy Markdown

datadog-datadog-prod-us1-2 Bot commented Apr 28, 2026

Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 71.48% (+0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 58a5f8a | Docs | Datadog PR Page | Give us feedback!

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.20%. Comparing base (0e63640) to head (58a5f8a).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8152   +/-   ##
=======================================
  Coverage   77.20%   77.20%           
=======================================
  Files         809      809           
  Lines       37562    37562           
=======================================
  Hits        28998    28998           
  Misses       8564     8564           
Flag Coverage Δ
aiguard-macos 35.71% <ø> (-0.09%) ⬇️
aiguard-ubuntu 35.81% <ø> (-0.09%) ⬇️
aiguard-windows 35.61% <ø> (-0.09%) ⬇️
apm-capabilities-tracing-macos 48.10% <ø> (-0.05%) ⬇️
apm-capabilities-tracing-ubuntu-active 48.17% <ø> (ø)
apm-capabilities-tracing-ubuntu-latest 48.14% <ø> (ø)
apm-capabilities-tracing-ubuntu-maintenance 48.17% <ø> (ø)
apm-capabilities-tracing-ubuntu-oldest 48.16% <ø> (ø)
apm-capabilities-tracing-windows 47.93% <ø> (-0.04%) ⬇️
apm-integrations-aerospike-18-gte.5.2.0 34.85% <ø> (-0.09%) ⬇️
apm-integrations-aerospike-20-gte.5.5.0 34.87% <ø> (-0.09%) ⬇️
apm-integrations-aerospike-22-gte.5.12.1 34.87% <ø> (-0.09%) ⬇️
apm-integrations-aerospike-22-gte.6.0.0 34.87% <ø> (-0.09%) ⬇️
apm-integrations-aerospike-eol- 34.77% <ø> (-0.09%) ⬇️
apm-integrations-child-process 36.04% <ø> (-0.10%) ⬇️
apm-integrations-confluentinc-kafka-javascript-18 41.71% <ø> (-0.09%) ⬇️
apm-integrations-confluentinc-kafka-javascript-20 41.73% <ø> (-0.09%) ⬇️
apm-integrations-confluentinc-kafka-javascript-22 41.73% <ø> (-0.09%) ⬇️
apm-integrations-confluentinc-kafka-javascript-24 41.66% <ø> (-0.09%) ⬇️
apm-integrations-couchbase-18 35.04% <ø> (-0.12%) ⬇️
apm-integrations-couchbase-eol 35.12% <ø> (-0.09%) ⬇️
apm-integrations-dns 34.84% <ø> (-0.10%) ⬇️
apm-integrations-elasticsearch 35.44% <ø> (-0.09%) ⬇️
apm-integrations-http-latest 42.90% <ø> (-0.08%) ⬇️
apm-integrations-http-maintenance 42.96% <ø> (-0.08%) ⬇️
apm-integrations-http-oldest 42.97% <ø> (-0.08%) ⬇️
apm-integrations-http2 40.24% <ø> (-0.09%) ⬇️
apm-integrations-kafkajs-latest 41.60% <ø> (-0.08%) ⬇️
apm-integrations-kafkajs-oldest 41.65% <ø> (-0.09%) ⬇️
apm-integrations-net 35.50% <ø> (-0.10%) ⬇️
apm-integrations-next-11.1.4 29.30% <ø> (-0.08%) ⬇️
apm-integrations-next-13.2.0 31.15% <ø> (-0.09%) ⬇️
apm-integrations-next-gte.10.2.0.and.lt.11 23.33% <ø> (ø)
apm-integrations-next-gte.11.0.0.and.lt.13 31.16% <ø> (-0.09%) ⬇️
apm-integrations-next-gte.13.0.0.and.lt.14 31.41% <ø> (-0.09%) ⬇️
apm-integrations-next-gte.14.0.0.and.lte.14.2.6 31.23% <ø> (-0.11%) ⬇️
apm-integrations-next-gte.14.2.7.and.lt.15 31.23% <ø> (-0.09%) ⬇️
apm-integrations-next-gte.15.0.0 31.29% <ø> (-0.09%) ⬇️
apm-integrations-prisma-18-gte.6.16.0.and.lt.7.0.0 35.41% <ø> (-0.09%) ⬇️
apm-integrations-prisma-latest-all 35.74% <ø> (-0.09%) ⬇️
apm-integrations-sharedb 34.46% <ø> (-0.09%) ⬇️
apm-integrations-tedious 35.01% <ø> (-0.09%) ⬇️
appsec-express 52.73% <ø> (-0.07%) ⬇️
appsec-fastify 49.21% <ø> (-0.07%) ⬇️
appsec-graphql 49.39% <ø> (-0.07%) ⬇️
appsec-kafka 41.97% <ø> (-0.09%) ⬇️
appsec-ldapjs 41.22% <ø> (-0.08%) ⬇️
appsec-lodash 41.34% <ø> (-0.08%) ⬇️
appsec-macos 56.76% <ø> (-0.07%) ⬇️
appsec-mongodb-core 45.63% <ø> (-0.07%) ⬇️
appsec-mongoose 46.51% <ø> (-0.07%) ⬇️
appsec-mysql 48.60% <ø> (-0.17%) ⬇️
appsec-next-latest-11.1.4 29.49% <ø> (-0.08%) ⬇️
appsec-next-latest-13.2.0 31.37% <ø> (-0.09%) ⬇️
appsec-next-latest-gte.10.2.0.and.lt.11 31.56% <ø> (ø)
appsec-next-latest-gte.11.0.0.and.lt.13 31.35% <ø> (-0.09%) ⬇️
appsec-next-latest-gte.13.0.0.and.lt.14 31.55% <ø> (-0.09%) ⬇️
appsec-next-latest-gte.14.0.0.and.lte.14.2.6 31.39% <ø> (-0.09%) ⬇️
appsec-next-latest-gte.14.2.7.and.lt.15 31.39% <ø> (-0.09%) ⬇️
appsec-next-latest-gte.15.0.0 31.39% <ø> (-0.09%) ⬇️
appsec-next-oldest-11.1.4 29.50% <ø> (-0.08%) ⬇️
appsec-next-oldest-13.2.0 31.61% <ø> (-0.09%) ⬇️
appsec-next-oldest-gte.10.2.0.and.lt.11 31.72% <ø> (ø)
appsec-next-oldest-gte.11.0.0.and.lt.13 31.37% <ø> (-0.09%) ⬇️
appsec-next-oldest-gte.13.0.0.and.lt.14 31.80% <ø> (-0.09%) ⬇️
appsec-next-oldest-gte.14.0.0.and.lte.14.2.6 31.65% <ø> (-0.09%) ⬇️
appsec-next-oldest-gte.14.2.7.and.lt.15 31.65% <ø> (-0.09%) ⬇️
appsec-next-oldest-gte.15.0.0 31.65% <ø> (-0.09%) ⬇️
appsec-node-serialize 40.51% <ø> (-0.08%) ⬇️
appsec-passport 44.51% <ø> (-0.08%) ⬇️
appsec-postgres 48.27% <ø> (-0.07%) ⬇️
appsec-sourcing 40.00% <ø> (-0.08%) ⬇️
appsec-stripe 42.24% <ø> (-0.08%) ⬇️
appsec-template 40.68% <ø> (-0.08%) ⬇️
appsec-ubuntu 56.84% <ø> (-0.07%) ⬇️
appsec-windows 56.63% <ø> (-0.09%) ⬇️
debugger-ubuntu-active 62.12% <ø> (-0.33%) ⬇️
debugger-ubuntu-latest 62.02% <ø> (-0.33%) ⬇️
debugger-ubuntu-maintenance 62.12% <ø> (-0.33%) ⬇️
debugger-ubuntu-oldest 62.21% <ø> (-0.33%) ⬇️
instrumentations-instrumentation-bluebird 29.75% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-body-parser 37.64% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-child_process 35.41% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-cookie-parser 31.68% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-express 31.90% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-express-mongo-sanitize 31.80% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-express-session 37.27% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-fs 29.43% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-generic-pool 30.30% <ø> (ø)
instrumentations-instrumentation-http 36.88% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-knex 29.72% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-light-my-request 37.20% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-mongoose 30.81% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-multer 37.41% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-mysql2 35.38% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-passport 41.09% <ø> (-0.08%) ⬇️
instrumentations-instrumentation-passport-http 40.87% <ø> (-0.08%) ⬇️
instrumentations-instrumentation-passport-local 41.38% <ø> (-0.08%) ⬇️
instrumentations-instrumentation-pg 34.91% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-promise 29.68% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-promise-js 29.69% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-q 29.72% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-url 29.69% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-when 29.70% <ø> (-0.10%) ⬇️
llmobs-ai 38.35% <ø> (-0.09%) ⬇️
llmobs-anthropic 37.84% <ø> (-0.09%) ⬇️
llmobs-bedrock 37.06% <ø> (-0.08%) ⬇️
llmobs-google-genai 37.49% <ø> (-0.08%) ⬇️
llmobs-langchain 37.00% <ø> (-0.07%) ⬇️
llmobs-openai 41.18% <ø> (-0.08%) ⬇️
llmobs-vertex-ai 37.67% <ø> (-0.02%) ⬇️
openfeature-unit-active 50.41% <ø> (-0.52%) ⬇️
openfeature-unit-latest 50.25% <ø> (-0.52%) ⬇️
openfeature-unit-maintenance 50.41% <ø> (-0.52%) ⬇️
openfeature-unit-oldest 50.41% <ø> (-0.52%) ⬇️
platform-core 36.53% <ø> (ø)
platform-esbuild 40.80% <ø> (ø)
platform-instrumentations-misc 31.22% <ø> (ø)
platform-shimmer 42.11% <ø> (ø)
platform-unit-guardrails 35.88% <ø> (ø)
platform-webpack 20.72% <ø> (ø)
plugins-azure-durable-functions 25.36% <ø> (ø)
plugins-azure-event-hubs 25.51% <ø> (ø)
plugins-azure-service-bus 24.92% <ø> (ø)
plugins-bullmq 40.55% <ø> (-0.09%) ⬇️
plugins-cassandra 35.24% <ø> (+0.04%) ⬆️
plugins-cookie 26.47% <ø> (ø)
plugins-cookie-parser 26.28% <ø> (ø)
plugins-crypto 27.32% <ø> (ø)
plugins-dd-trace-api 35.35% <ø> (-0.09%) ⬇️
plugins-express-mongo-sanitize 26.42% <ø> (ø)
plugins-express-session 26.24% <ø> (ø)
plugins-fastify 39.25% <ø> (-0.09%) ⬇️
plugins-fetch 35.76% <ø> (-0.09%) ⬇️
plugins-fs 35.64% <ø> (-0.10%) ⬇️
plugins-generic-pool 25.40% <ø> (ø)
plugins-google-cloud-pubsub 42.99% <ø> (-0.08%) ⬇️
plugins-grpc 38.01% <ø> (-0.09%) ⬇️
plugins-handlebars 26.46% <ø> (ø)
plugins-hapi 37.25% <ø> (-0.09%) ⬇️
plugins-hono 37.50% <ø> (-0.09%) ⬇️
plugins-ioredis 35.68% <ø> (-0.09%) ⬇️
plugins-knex 26.14% <ø> (ø)
plugins-langgraph 35.03% <ø> (-0.09%) ⬇️
plugins-ldapjs 24.02% <ø> (ø)
plugins-light-my-request 25.88% <ø> (ø)
plugins-limitd-client 29.98% <ø> (-0.09%) ⬇️
plugins-lodash 25.47% <ø> (ø)
plugins-mariadb 36.55% <ø> (-0.14%) ⬇️
plugins-memcached 35.33% <ø> (-0.10%) ⬇️
plugins-microgateway-core 36.34% <ø> (-0.09%) ⬇️
plugins-modelcontextprotocol-sdk 34.27% <ø> (-0.09%) ⬇️
plugins-moleculer 38.03% <ø> (-0.09%) ⬇️
plugins-mongodb 36.50% <ø> (-0.09%) ⬇️
plugins-mongodb-core 36.13% <ø> (-0.09%) ⬇️
plugins-mongoose 36.01% <ø> (-0.09%) ⬇️
plugins-multer 26.24% <ø> (ø)
plugins-mysql 36.28% <ø> (-0.23%) ⬇️
plugins-mysql2 36.40% <ø> (-0.09%) ⬇️
plugins-node-serialize 26.51% <ø> (ø)
plugins-opensearch 35.00% <ø> (-0.09%) ⬇️
plugins-passport-http 26.30% <ø> (ø)
plugins-pino 31.78% <ø> (-0.09%) ⬇️
plugins-postgres 34.39% <ø> (-0.09%) ⬇️
plugins-process 27.32% <ø> (ø)
plugins-pug 26.47% <ø> (ø)
plugins-redis 35.89% <ø> (-0.09%) ⬇️
plugins-router 39.68% <ø> (-0.09%) ⬇️
plugins-sequelize 25.18% <ø> (ø)
plugins-test-and-upstream-amqp10 35.65% <ø> (+0.04%) ⬆️
plugins-test-and-upstream-amqplib 40.82% <ø> (-0.09%) ⬇️
plugins-test-and-upstream-apollo 36.51% <ø> (-0.08%) ⬇️
plugins-test-and-upstream-avsc 34.98% <ø> (-0.09%) ⬇️
plugins-test-and-upstream-bunyan 31.13% <ø> (-0.09%) ⬇️
plugins-test-and-upstream-connect 37.84% <ø> (-0.09%) ⬇️
plugins-test-and-upstream-graphql 37.18% <ø> (-0.09%) ⬇️
plugins-test-and-upstream-koa 37.45% <ø> (-0.09%) ⬇️
plugins-test-and-upstream-protobufjs 35.20% <ø> (-0.09%) ⬇️
plugins-test-and-upstream-rhea 40.90% <ø> (-0.09%) ⬇️
plugins-undici 36.39% <ø> (-0.21%) ⬇️
plugins-url 27.32% <ø> (ø)
plugins-valkey 35.36% <ø> (-0.09%) ⬇️
plugins-vm 27.32% <ø> (ø)
plugins-winston 31.74% <ø> (+0.04%) ⬆️
plugins-ws 38.97% <ø> (-0.09%) ⬇️
profiling-macos 40.43% <ø> (-0.08%) ⬇️
profiling-ubuntu 40.60% <ø> (-0.53%) ⬇️
profiling-windows 40.61% <ø> (-0.08%) ⬇️
serverless-azure-functions-client 25.25% <ø> (ø)
serverless-azure-functions-eventhubs 25.25% <ø> (ø)
serverless-azure-functions-servicebus 25.25% <ø> (ø)
serverless-lambda 33.45% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BridgeAR BridgeAR marked this pull request as ready for review April 28, 2026 23:01
@BridgeAR BridgeAR requested a review from a team as a code owner April 28, 2026 23:01
@BridgeAR BridgeAR requested review from khanayan123 and removed request for a team April 28, 2026 23:01
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Apr 28, 2026

Benchmarks

Benchmark execution time: 2026-04-28 23:03:06

Comparing candidate commit 58a5f8a in PR branch BridgeAR/2026-04-28-safer-config-values with baseline commit 0e63640 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1347 metrics, 97 unstable metrics.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 58a5f8adf0

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread packages/dd-trace/test/config/index.spec.js
@BridgeAR BridgeAR merged commit 2d2ed5b into master Apr 29, 2026
980 of 981 checks passed
@BridgeAR BridgeAR deleted the BridgeAR/2026-04-28-safer-config-values branch April 29, 2026 11:54
dd-octo-sts Bot pushed a commit that referenced this pull request Apr 29, 2026
Unknown configurations now have a test against being added to
prevent unknown telemetry being reported.
@dd-octo-sts dd-octo-sts Bot mentioned this pull request Apr 29, 2026
BridgeAR added a commit that referenced this pull request Apr 30, 2026
Unknown configurations now have a test against being added to
prevent unknown telemetry being reported.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants