chore(benchmark): drop Node 18 from sirun matrix and add Node 26#8423
Merged
Conversation
Node.js 18 hit EOL in April 2025. The sirun benchmark matrix replaces
its six `MAJOR_VERSION=18` groups in `.gitlab/benchmarks.yml` with six
`MAJOR_VERSION=26` groups; bench coverage is now {20, 22, 24, 26}.
This is bench-only; dd-trace's own `engines.node` is unchanged.
The `find-my-way` and `thread-stream` overrides in the startup fixture
were Node-18-only accommodations and are no longer load-bearing; both
resolve naturally on the new matrix floor (`find-my-way@9.6.0`,
`thread-stream@4.1.0`, each declaring `engines.node >=20`). The
`fast-xml-parser` override replaces them to keep the fixture
installable against current security advisories.
Contributor
Overall package sizeSelf size: 5.81 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.0.1 | 82.56 kB | 817.39 kB | | dc-polyfill | 0.1.11 | 25.74 kB | 25.74 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: 381a89e | Docs | Datadog PR Page | Give us feedback! |
BenchmarksBenchmark execution time: 2026-05-11 13:20:22 Comparing candidate commit 381a89e in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 1975 metrics, 129 unstable metrics. |
bengl
approved these changes
May 11, 2026
Merged
rochdev
pushed a commit
that referenced
this pull request
May 13, 2026
Node.js 18 hit EOL in April 2025. The sirun benchmark matrix replaces
its six `MAJOR_VERSION=18` groups in `.gitlab/benchmarks.yml` with six
`MAJOR_VERSION=26` groups; bench coverage is now {20, 22, 24, 26}.
This is bench-only; dd-trace's own `engines.node` is unchanged.
The `find-my-way` and `thread-stream` overrides in the startup fixture
were Node-18-only accommodations and are no longer load-bearing; both
resolve naturally on the new matrix floor (`find-my-way@9.6.0`,
`thread-stream@4.1.0`, each declaring `engines.node >=20`). The
`fast-xml-parser` override replaces them to keep the fixture
installable against current security advisories.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node.js 18 hit EOL in April 2025. The sirun benchmark matrix replaces its six
MAJOR_VERSION=18groups in.gitlab/benchmarks.ymlwith sixMAJOR_VERSION=26groups; bench coverage is now {20, 22, 24, 26}. This is bench-only; dd-trace's ownengines.nodeis unchanged.The
find-my-wayandthread-streamoverrides in the startup fixture were Node-18-only accommodations and are no longer load-bearing; both resolve naturally on the new matrix floor (find-my-way@9.6.0,thread-stream@4.1.0, each declaringengines.node >=20). Thefast-xml-parseroverride replaces them to keep the fixture installable against current security advisories.