chore: readonly not suppose to have default value#2180
Merged
Conversation
bwoebi
reviewed
Jul 31, 2023
| /** | ||
| * @var SpanStack|null The parent stack, or 'null' if there is none | ||
| */ | ||
| public readonly SpanStack|null $parent = null; |
Collaborator
There was a problem hiding this comment.
Is there a reason you removed that readonly here?
Contributor
Author
There was a problem hiding this comment.
Yes. You may notice that like 153 defines whole class as a readonly, so it's invalid to duplicate it to property too.
Collaborator
|
@Ferror We need these stubs in our own repository as the arginfo.h are generated from these. But good finds that they cannot have a default value. |
Collaborator
|
I'll merge it next week, have to also regenerate stubs and test whether it then still works properly. |
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
bwoebi
approved these changes
Aug 17, 2023
bwoebi
left a comment
bwoebi
left a comment
Collaborator
There was a problem hiding this comment.
SpanStack itself is not supposed to be readonly, that was a mistake, removed it there instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to use the stubs, and it seems that not all are defined correctly.
Btw. why not to move them to https://github.com/JetBrains/phpstorm-stubs?