Skip to content

Fix noop tracer issues with Laravel integration#220

Merged
SammyK merged 3 commits into
masterfrom
sammyk/fix-laravel-cli
Jan 7, 2019
Merged

Fix noop tracer issues with Laravel integration#220
SammyK merged 3 commits into
masterfrom
sammyk/fix-laravel-cli

Conversation

@SammyK
Copy link
Copy Markdown
Contributor

@SammyK SammyK commented Jan 7, 2019

Description

This should fix the issue brought up in #216. I also updated the config in the test app for Laravel 5 to keep the deprecated messages from showing up when running the tests. :)

Readiness checklist

@SammyK SammyK requested a review from labbati January 7, 2019 15:46
@SammyK SammyK added this to the 0.9.0 milestone Jan 7, 2019
@SammyK SammyK added 🐛 bug Something isn't working 🎉 new-integration A new integration labels Jan 7, 2019
labbati
labbati previously approved these changes Jan 7, 2019
Copy link
Copy Markdown
Member

@labbati labbati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄 !!!

Copy link
Copy Markdown
Member

@labbati labbati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even better with this last change 😄

@SammyK SammyK merged commit 86bebe8 into master Jan 7, 2019
@SammyK SammyK deleted the sammyk/fix-laravel-cli branch January 7, 2019 16:46
bwoebi added a commit that referenced this pull request Aug 21, 2023
Also fixes that opened named shm handles are always unlinked. Oops.

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working 🎉 new-integration A new integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants