Support parsing partial json in appsec#3680
Conversation
|
✨ Fix all issues with BitsAI or with Cursor
|
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (74.50%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #3680 +/- ##
==========================================
+ Coverage 62.20% 62.39% +0.19%
==========================================
Files 141 142 +1
Lines 13352 13586 +234
Branches 1746 1775 +29
==========================================
+ Hits 8305 8477 +172
- Misses 4256 4304 +48
- Partials 791 805 +14
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Benchmarks [ appsec ]Benchmark execution time: 2026-02-27 17:54:23 Comparing candidate commit 1622f8d in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. |
d6f2e1b to
e4ba0b6
Compare
Also try to find homebrew clang tools or clang-tidy/format with -17 as a suffix.
e4ba0b6 to
1622f8d
Compare
| // This product includes software developed at Datadog | ||
| // (https://www.datadoghq.com/). Copyright 2021 Datadog, Inc. | ||
|
|
||
| #include "json_truncated_parser.h" |
There was a problem hiding this comment.
Why have you decided to go for a CPP implementation on the exension?
There was a problem hiding this comment.
It was dictated by the choice of library (rapidjson). The C libraries with SAX-like, event-driven API have not seen updates in more than a decade.
| @@ -1 +0,0 @@ | |||
| /version.hpp | |||
There was a problem hiding this comment.
3df4e17f08#diff-d7c6e792306074c39c93c98658584807ea65a8c68bbce5c3d353e3afc0a87e55L1-L19 changed the location where version.hpp was generated (no more on the source tree), so this ignore is not needed anymore
estringana
left a comment
There was a problem hiding this comment.
Just a few questions but nothing big
Description
Backport partial json parsing from API10 branch.
Reviewer checklist