Skip to content

Expand appsec integrations to Laminas Framework#3716

Merged
estringana merged 42 commits into
masterfrom
estringana/add-laminas-appsec-integration
May 15, 2026
Merged

Expand appsec integrations to Laminas Framework#3716
estringana merged 42 commits into
masterfrom
estringana/add-laminas-appsec-integration

Conversation

@estringana
Copy link
Copy Markdown
Contributor

@estringana estringana commented Mar 20, 2026

Add AAP support to Laminas framework

This PR introduces AAP support to the Laminas framework, enabling improved observability and authentication-related event tracking.

Features added

  • Provide http.route
    Captures and exposes the resolved route for incoming requests.

  • Collect endpoints at startup
    Gathers and registers available endpoints during application bootstrap.

  • Login success event
    Emits an event when a user successfully authenticates.

  • Login failure event
    Emits an event when authentication fails.

  • Authenticated request events
    Tracks requests performed by authenticated users.

  • Collect path parameters
    Extracts and includes route path parameters in the collected data.

Limitations / Missing features

  • Signup events
    Not implemented because Laminas does not provide a built-in signup mechanism. This functionality is application-specific and must be implemented by developers if needed.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@estringana estringana force-pushed the estringana/add-laminas-appsec-integration branch from 820057d to eae5325 Compare March 23, 2026 11:22
@datadog-prod-us1-4
Copy link
Copy Markdown

datadog-prod-us1-4 Bot commented Mar 23, 2026

Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 60.70% (+0.01%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 0f508fe | Docs | Datadog PR Page | Give us feedback!

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.74%. Comparing base (78ecdb0) to head (d2866e8).
⚠️ Report is 16 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3716      +/-   ##
==========================================
- Coverage   68.81%   68.74%   -0.08%     
==========================================
  Files         166      166              
  Lines       19030    19030              
  Branches     1797     1797              
==========================================
- Hits        13096    13082      -14     
- Misses       5121     5135      +14     
  Partials      813      813              
Flag Coverage Δ
helper-rust-integration 78.82% <ø> (-0.03%) ⬇️
helper-rust-unit 49.17% <ø> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78ecdb0...d2866e8. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Mar 23, 2026

Benchmarks [ tracer ]

Benchmark execution time: 2026-04-14 15:46:16

Comparing candidate commit a35cd52 in PR branch estringana/add-laminas-appsec-integration with baseline commit df43587 in branch master.

Found 0 performance improvements and 6 performance regressions! Performance is the same for 188 metrics, 0 unstable metrics.

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

  • 🟥 execution_time [+3.785µs; +5.055µs] or [+3.818%; +5.100%]

scenario:PDOBench/benchPDOOverhead-opcache

  • 🟥 execution_time [+8.038µs; +9.869µs] or [+3.365%; +4.131%]

scenario:PDOBench/benchPDOOverheadWithDBM-opcache

  • 🟥 execution_time [+7.608µs; +9.649µs] or [+3.175%; +4.027%]

scenario:PHPRedisBench/benchRedisOverhead

  • 🟥 execution_time [+33.225µs; +41.437µs] or [+3.496%; +4.360%]

scenario:SamplingRuleMatchingBench/benchRegexMatching1

  • 🟥 execution_time [+31.682ns; +109.118ns] or [+2.139%; +7.366%]

scenario:SamplingRuleMatchingBench/benchRegexMatching3

  • 🟥 execution_time [+44.495ns; +120.705ns] or [+2.997%; +8.131%]

@github-actions
Copy link
Copy Markdown
Contributor

Snapshots difference summary

The following differences have been observed in committed snapshots. It is meant to help the reviewer.
The diff is simplistic, so please check some files anyway while we improve it.

If you need to update snapshots, please refer to CONTRIBUTING.md

@estringana estringana force-pushed the estringana/add-laminas-appsec-integration branch 2 times, most recently from c199b10 to 9b662b3 Compare April 13, 2026 14:28
@estringana estringana marked this pull request as ready for review April 15, 2026 13:24
@estringana estringana requested review from a team as code owners April 15, 2026 13:24
@cataphract
Copy link
Copy Markdown
Contributor

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 140b8c4617

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/DDTrace/Integrations/Laminas/LaminasIntegration.php Outdated
Comment thread src/DDTrace/Integrations/Laminas/LaminasIntegration.php
Comment thread src/DDTrace/Integrations/Laminas/LaminasIntegration.php
Comment thread src/DDTrace/Integrations/Laminas/LaminasIntegration.php Outdated
Comment thread src/DDTrace/Integrations/Laminas/LaminasIntegration.php
Comment thread src/DDTrace/Integrations/Laminas/LaminasIntegration.php
Comment thread src/DDTrace/Integrations/Laminas/LaminasIntegration.php
Comment thread src/DDTrace/Integrations/Laminas/LaminasIntegration.php Outdated
Comment thread src/DDTrace/Integrations/Laminas/LaminasIntegration.php Outdated
@estringana estringana force-pushed the estringana/add-laminas-appsec-integration branch from 979e638 to b6e2fdc Compare May 4, 2026 15:36
Comment thread src/DDTrace/Integrations/Laminas/LaminasIntegration.php Outdated
Comment thread src/DDTrace/Integrations/Laminas/LaminasIntegration.php
Comment thread src/DDTrace/Integrations/Laminas/LaminasIntegration.php
Comment thread src/DDTrace/Integrations/Laminas/LaminasIntegration.php Outdated
Comment thread src/DDTrace/Integrations/Laminas/LaminasIntegration.php Outdated
Comment thread src/DDTrace/Integrations/Laminas/LaminasIntegration.php Outdated
Comment thread src/DDTrace/Integrations/Laminas/LaminasIntegration.php
Comment thread src/DDTrace/Integrations/Laminas/LaminasIntegration.php Outdated
Comment thread src/DDTrace/Integrations/Laminas/LaminasIntegration.php
@estringana estringana force-pushed the estringana/add-laminas-appsec-integration branch from 5e277d4 to fc57b42 Compare May 13, 2026 10:15
Comment thread src/DDTrace/Integrations/Laminas/LaminasIntegration.php Outdated
Comment thread appsec/src/extension/tags.c Outdated
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented May 15, 2026

Benchmarks [ appsec ]

Benchmark execution time: 2026-05-15 19:08:21

Comparing candidate commit 0f508fe in PR branch estringana/add-laminas-appsec-integration with baseline commit 09d8943 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

@estringana estringana merged commit 9fa5e9e into master May 15, 2026
2112 of 2123 checks passed
@estringana estringana deleted the estringana/add-laminas-appsec-integration branch May 15, 2026 19:41
@github-actions github-actions Bot added this to the 1.20.0 milestone May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants