Skip to content

fix: CA root should not be required#3734

Closed
morrisonlevi wants to merge 1 commit intomasterfrom
levi/fix_certificate_issue
Closed

fix: CA root should not be required#3734
morrisonlevi wants to merge 1 commit intomasterfrom
levi/fix_certificate_issue

Conversation

@morrisonlevi
Copy link
Copy Markdown
Collaborator

@morrisonlevi morrisonlevi commented Mar 26, 2026

Description

In a recent libdatadog change, we unintentionally required that a CA root store be found even for non-HTTPS connections to the agent e.g. http:// and unix:// endpoints.

This PR points to a libdatadog branch which has a fix which requires it only when the endpoint is https://.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@datadog-datadog-prod-us1-2
Copy link
Copy Markdown

datadog-datadog-prod-us1-2 bot commented Mar 26, 2026

⚠️ Tests

Fix all issues with BitsAI or with Cursor

⚠️ Warnings

🧪 1056 Tests failed

testSearchPhpBinaries from integration.DDTrace\Tests\Integration\PHPInstallerTest   View in Datadog   (Fix with Cursor)
Risky Test
phpvfscomposer://tests/vendor/phpunit/phpunit/phpunit:97
testSimplePushAndProcess from laravel-58-test.DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest   View in Datadog   (Fix with Cursor)
DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest::testSimplePushAndProcess
Test code or tested code printed unexpected output: spanLinksTraceId: 69c533db00000000ded94ca18bd95145
tid: 69c533db00000000
hexProcessTraceId: ded94ca18bd95145
hexProcessSpanId: 4daad7e0406203f3
processTraceId: 16057950203085934917
processSpanId: 5596522845114074099

phpvfscomposer://tests/vendor/phpunit/phpunit/phpunit:106
testSimplePushAndProcess from laravel-8x-test.DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest   View in Datadog   (Fix with Cursor)
DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest::testSimplePushAndProcess
Test code or tested code printed unexpected output: spanLinksTraceId: 69c5347d000000004825bcf96473aeb1
tid: 69c5347d00000000
hexProcessTraceId: 4825bcf96473aeb1
hexProcessSpanId: 11dcf4823c6575d7
processTraceId: 5198769124187287217
processSpanId: 1287172433717327319
View all

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 60.68% (-0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: d6116d9 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.84%. Comparing base (0bdca89) to head (d6116d9).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3734      +/-   ##
==========================================
- Coverage   68.85%   68.84%   -0.01%     
==========================================
  Files         166      166              
  Lines       19015    19015              
  Branches     1792     1792              
==========================================
- Hits        13092    13091       -1     
- Misses       5112     5114       +2     
+ Partials      811      810       -1     
Flag Coverage Δ
helper-rust-integration 78.82% <ø> (+0.02%) ⬆️
helper-rust-unit 49.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bdca89...d6116d9. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link
Copy Markdown

pr-commenter bot commented Mar 26, 2026

Benchmarks [ profiler ]

Benchmark execution time: 2026-03-26 13:33:57

Comparing candidate commit d6116d9 in PR branch levi/fix_certificate_issue with baseline commit 0bdca89 in branch master.

Found 3 performance improvements and 1 performance regressions! Performance is the same for 25 metrics, 7 unstable metrics.

scenario:php-profiler-timeline-memory-with-profiler-and-timeline

  • 🟩 cpu_usage_percentage [-7.851%; -6.917%]
  • 🟩 cpu_user_time [-270.144ms; -202.322ms] or [-17.311%; -12.965%]
  • 🟩 execution_time [-105.048ms; -80.920ms] or [-7.872%; -6.064%]

scenario:walk_stack/1

  • 🟥 wall_time [+298.658ns; +302.210ns] or [+2.401%; +2.430%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants