ci: skip openssl bug79145.phpt on < 8.1#3743
Merged
morrisonlevi merged 1 commit intolevi/fix-resources-php-language-testsfrom Mar 26, 2026
Merged
ci: skip openssl bug79145.phpt on < 8.1#3743morrisonlevi merged 1 commit intolevi/fix-resources-php-language-testsfrom
morrisonlevi merged 1 commit intolevi/fix-resources-php-language-testsfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## levi/fix-resources-php-language-tests #3743 +/- ##
=========================================================================
+ Coverage 68.81% 68.85% +0.03%
=========================================================================
Files 166 166
Lines 19015 19015
Branches 1792 1792
=========================================================================
+ Hits 13086 13092 +6
+ Misses 5117 5113 -4
+ Partials 812 810 -2
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
🎯 Code Coverage (details) 🔗 Commit SHA: a5ff3ff | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
d148395 to
874005e
Compare
This test loops many times and it's too slow sometimes causing the CI to be flaky. It was rewritten upstream in PHP 8.1.
41c25e0 to
a5ff3ff
Compare
bwoebi
approved these changes
Mar 26, 2026
919acf0
into
levi/fix-resources-php-language-tests
2084 of 2100 checks passed
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This test loops many times and it's too slow sometimes causing the CI to be flaky. It was rewritten upstream in PHP 8.1 so we don't need to skip it on 8.1+.
Reviewer checklist