Skip to content

ci: skip openssl bug79145.phpt on < 8.1#3743

Merged
morrisonlevi merged 1 commit intolevi/fix-resources-php-language-testsfrom
levi/openssl-bug79145
Mar 26, 2026
Merged

ci: skip openssl bug79145.phpt on < 8.1#3743
morrisonlevi merged 1 commit intolevi/fix-resources-php-language-testsfrom
levi/openssl-bug79145

Conversation

@morrisonlevi
Copy link
Copy Markdown
Collaborator

Description

This test loops many times and it's too slow sometimes causing the CI to be flaky. It was rewritten upstream in PHP 8.1 so we don't need to skip it on 8.1+.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.85%. Comparing base (e3f3a06) to head (a5ff3ff).
⚠️ Report is 8 commits behind head on levi/fix-resources-php-language-tests.

Additional details and impacted files

Impacted file tree graph

@@                            Coverage Diff                            @@
##           levi/fix-resources-php-language-tests    #3743      +/-   ##
=========================================================================
+ Coverage                                  68.81%   68.85%   +0.03%     
=========================================================================
  Files                                        166      166              
  Lines                                      19015    19015              
  Branches                                    1792     1792              
=========================================================================
+ Hits                                       13086    13092       +6     
+ Misses                                      5117     5113       -4     
+ Partials                                     812      810       -2     
Flag Coverage Δ
helper-rust-integration 78.85% <ø> (+0.02%) ⬆️
helper-rust-unit 49.36% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3f3a06...a5ff3ff. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-prod-us1-3
Copy link
Copy Markdown

datadog-prod-us1-3 bot commented Mar 26, 2026

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 60.68% (-0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: a5ff3ff | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@morrisonlevi morrisonlevi force-pushed the levi/fix-resources-php-language-tests branch from d148395 to 874005e Compare March 26, 2026 17:26
This test loops many times and it's too slow sometimes causing the
CI to be flaky. It was rewritten upstream in PHP 8.1.
@morrisonlevi morrisonlevi force-pushed the levi/openssl-bug79145 branch from 41c25e0 to a5ff3ff Compare March 26, 2026 17:26
@morrisonlevi morrisonlevi marked this pull request as ready for review March 26, 2026 17:27
@morrisonlevi morrisonlevi requested a review from a team as a code owner March 26, 2026 17:27
@morrisonlevi morrisonlevi merged commit 919acf0 into levi/fix-resources-php-language-tests Mar 26, 2026
2084 of 2100 checks passed
@morrisonlevi morrisonlevi deleted the levi/openssl-bug79145 branch March 26, 2026 18:02
@morrisonlevi morrisonlevi restored the levi/openssl-bug79145 branch March 26, 2026 18:02
@morrisonlevi morrisonlevi deleted the levi/openssl-bug79145 branch March 26, 2026 18:02
@morrisonlevi morrisonlevi restored the levi/openssl-bug79145 branch March 26, 2026 18:03
@morrisonlevi morrisonlevi deleted the levi/openssl-bug79145 branch March 26, 2026 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants