Skip to content

ci: xfail sni_server tests due to expired certificates#3777

Merged
morrisonlevi merged 2 commits intomasterfrom
worktree-xfail-sni-server-expired-certs
Apr 7, 2026
Merged

ci: xfail sni_server tests due to expired certificates#3777
morrisonlevi merged 2 commits intomasterfrom
worktree-xfail-sni-server-expired-certs

Conversation

@morrisonlevi
Copy link
Copy Markdown
Collaborator

@morrisonlevi morrisonlevi commented Apr 7, 2026

Description

The bundled sni_server_*.pem certificates expired on 2026-04-02, causing stream_socket_client() to return false and the tests to fail across all PHP versions.

This sort of conflicts with #3772, but it's not ready for merge.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

The bundled sni_server_*.pem certificates expired on 2026-04-02,
causing stream_socket_client() to return false and the tests to fail
across all PHP versions.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@datadog-datadog-prod-us1-2
Copy link
Copy Markdown

datadog-datadog-prod-us1-2 bot commented Apr 7, 2026

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 60.64% (-0.06%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 7f31357 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@morrisonlevi morrisonlevi marked this pull request as ready for review April 7, 2026 00:58
@morrisonlevi morrisonlevi requested a review from a team as a code owner April 7, 2026 00:58
Copy link
Copy Markdown
Collaborator

@bwoebi bwoebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing ext/openssl/tests/bug74796.phpt to PHP 8.3-8.5

Add bug74796.phpt to 8.3-8.5 xfail lists (same expired cert root cause
as sni_server tests). Also update README to include it and drop
inaccurate wording.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@morrisonlevi morrisonlevi merged commit 14dabf8 into master Apr 7, 2026
2088 of 2099 checks passed
@morrisonlevi morrisonlevi deleted the worktree-xfail-sni-server-expired-certs branch April 7, 2026 03:06
@github-actions github-actions bot added this to the 1.18.0 milestone Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants