Skip to content

Propagate session_id via env#3838

Merged
bwoebi merged 2 commits intomasterfrom
bob/session_id_propagation
Apr 28, 2026
Merged

Propagate session_id via env#3838
bwoebi merged 2 commits intomasterfrom
bob/session_id_propagation

Conversation

@bwoebi
Copy link
Copy Markdown
Collaborator

@bwoebi bwoebi commented Apr 27, 2026

Fix sending reference args to non-by-ref args and actually run exec integration in CI.

@bwoebi bwoebi requested review from a team as code owners April 27, 2026 18:43
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bd9ad22312

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread ext/integrations/exec_integration.c Outdated
Comment thread components-rs/lib.rs
@datadog-official
Copy link
Copy Markdown

datadog-official Bot commented Apr 27, 2026

Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 60.64% (-0.06%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 6d71144 | Docs | Datadog PR Page | Give us feedback!

Fix sending reference args to non-by-ref args and actually run exec integration in CI.
@bwoebi bwoebi force-pushed the bob/session_id_propagation branch from bd9ad22 to 0e82b18 Compare April 27, 2026 19:36
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Apr 27, 2026

Benchmarks [ tracer ]

Benchmark execution time: 2026-04-28 12:42:31

Comparing candidate commit 6d71144 in PR branch bob/session_id_propagation with baseline commit 919c36a in branch master.

Found 1 performance improvements and 1 performance regressions! Performance is the same for 192 metrics, 0 unstable metrics.

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

  • 🟩 execution_time [-8.199µs; -6.521µs] or [-7.295%; -5.801%]

scenario:SamplingRuleMatchingBench/benchRegexMatching3-opcache

  • 🟥 execution_time [+244.536ns; +448.864ns] or [+2.108%; +3.870%]

@bwoebi bwoebi force-pushed the bob/session_id_propagation branch 2 times, most recently from a35618a to 12dc9f2 Compare April 28, 2026 10:59
@bwoebi bwoebi force-pushed the bob/session_id_propagation branch from 12dc9f2 to 6d71144 Compare April 28, 2026 11:23
@bwoebi bwoebi merged commit c4172b8 into master Apr 28, 2026
2108 of 2115 checks passed
@bwoebi bwoebi deleted the bob/session_id_propagation branch April 28, 2026 14:47
@github-actions github-actions Bot added this to the 1.19.0 milestone Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants