Skip to content

Enable helper-rust by default also on PHP 8.4#3842

Merged
bwoebi merged 1 commit intomasterfrom
glopes/helper-rust-8.4
Apr 28, 2026
Merged

Enable helper-rust by default also on PHP 8.4#3842
bwoebi merged 1 commit intomasterfrom
glopes/helper-rust-8.4

Conversation

@cataphract
Copy link
Copy Markdown
Contributor

@cataphract cataphract commented Apr 28, 2026

Summary

  • Lowers the threshold for enabling the Rust helper by default from PHP 8.5 to PHP 8.4 (DD_APPSEC_HELPER_RUST_REDIRECTION_DEFAULT)
  • Updates integration test build logic to treat PHP 8.4 the same as 8.5 (build helper-rust dependency automatically)
  • Removes test8.4-release-zts from the helper-rust disabled CI matrix, since it's now enabled by default on 8.4
  • Updates comments throughout to say "PHP 8.4+" instead of "PHP 8.5+"

Test plan

  • CI passes for PHP 8.4 with helper-rust enabled by default
  • Existing PHP <8.4 tests continue using the C helper by default

@cataphract cataphract requested review from a team as code owners April 28, 2026 15:05
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 01e5adbcfd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread appsec/src/extension/configuration.h
@datadog-prod-us1-3
Copy link
Copy Markdown

datadog-prod-us1-3 Bot commented Apr 28, 2026

Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 60.64% (-0.05%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 87adbc2 | Docs | Datadog PR Page | Give us feedback!

@cataphract cataphract force-pushed the glopes/helper-rust-8.4 branch from bec10ac to 87adbc2 Compare April 28, 2026 15:32
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Apr 28, 2026

Benchmarks [ appsec ]

Benchmark execution time: 2026-04-28 16:14:02

Comparing candidate commit 87adbc2 in PR branch glopes/helper-rust-8.4 with baseline commit 557740f in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Apr 28, 2026

Benchmarks [ tracer ]

Benchmark execution time: 2026-04-28 16:53:31

Comparing candidate commit 87adbc2 in PR branch glopes/helper-rust-8.4 with baseline commit 557740f in branch master.

Found 1 performance improvements and 6 performance regressions! Performance is the same for 187 metrics, 0 unstable metrics.

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

  • 🟩 execution_time [-6.945µs; -5.375µs] or [-6.395%; -4.948%]

scenario:SamplingRuleMatchingBench/benchRegexMatching1

  • 🟥 execution_time [+37.736ns; +115.064ns] or [+2.531%; +7.717%]

scenario:SamplingRuleMatchingBench/benchRegexMatching2

  • 🟥 execution_time [+54.249ns; +132.351ns] or [+3.662%; +8.934%]

scenario:SamplingRuleMatchingBench/benchRegexMatching3

  • 🟥 execution_time [+31.748ns; +135.452ns] or [+2.138%; +9.123%]

scenario:SamplingRuleMatchingBench/benchRegexMatching4

  • 🟥 execution_time [+49.784ns; +114.816ns] or [+3.373%; +7.779%]

scenario:SamplingRuleMatchingBench/benchRegexMatching4-opcache

  • 🟥 execution_time [+235.421ns; +422.179ns] or [+2.008%; +3.602%]

scenario:SpanBench/benchOpenTelemetryAPI

  • 🟥 execution_time [+15.745µs; +30.981µs] or [+2.193%; +4.314%]

@bwoebi bwoebi merged commit 6b02d23 into master Apr 28, 2026
2102 of 2106 checks passed
@bwoebi bwoebi deleted the glopes/helper-rust-8.4 branch April 28, 2026 21:04
@github-actions github-actions Bot added this to the 1.19.0 milestone Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants