Enable helper-rust by default also on PHP 8.4#3842
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 01e5adbcfd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: 87adbc2 | Docs | Datadog PR Page | Give us feedback! |
bec10ac to
87adbc2
Compare
Benchmarks [ appsec ]Benchmark execution time: 2026-04-28 16:14:02 Comparing candidate commit 87adbc2 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. |
Benchmarks [ tracer ]Benchmark execution time: 2026-04-28 16:53:31 Comparing candidate commit 87adbc2 in PR branch Found 1 performance improvements and 6 performance regressions! Performance is the same for 187 metrics, 0 unstable metrics. scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache
scenario:SamplingRuleMatchingBench/benchRegexMatching1
scenario:SamplingRuleMatchingBench/benchRegexMatching2
scenario:SamplingRuleMatchingBench/benchRegexMatching3
scenario:SamplingRuleMatchingBench/benchRegexMatching4
scenario:SamplingRuleMatchingBench/benchRegexMatching4-opcache
scenario:SpanBench/benchOpenTelemetryAPI
|
Summary
DD_APPSEC_HELPER_RUST_REDIRECTION_DEFAULT)helper-rustdependency automatically)test8.4-release-ztsfrom thehelper-rust disabledCI matrix, since it's now enabled by default on 8.4Test plan