fix(tracing): parentId refcount underflow#3851
Open
morrisonlevi wants to merge 2 commits intomasterfrom
Open
Conversation
34b1194 to
7868412
Compare
🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: a51ed01 | Docs | Datadog PR Page | Give us feedback! |
$parent refcount underflow
Benchmarks [ tracer ]Benchmark execution time: 2026-05-01 02:59:42 Comparing candidate commit a51ed01 in PR branch Found 3 performance improvements and 4 performance regressions! Performance is the same for 187 metrics, 0 unstable metrics. scenario:EmptyFileBench/benchEmptyFileDdprof-opcache
scenario:PDOBench/benchPDOOverhead
scenario:PDOBench/benchPDOOverhead-opcache
scenario:PDOBench/benchPDOOverheadWithDBM
scenario:PDOBench/benchPDOOverheadWithDBM-opcache
scenario:PHPRedisBench/benchRedisOverhead
scenario:PHPRedisBench/benchRedisOverhead-opcache
|
$parent refcount underflowparent_id refcount underflow
parent_id refcount underflowparentId refcount underflow
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I was looking at customer crashes and codex was able to symbolize a crash that our crash tracker wasn't, and it looks like a corrupted
$parentand crashed when inheriting the service from it.I'm not sure this test is precisely the same issue, but nonetheless, it crashes.
Reviewer checklist