Skip to content

fix(tracing): parentId refcount underflow#3851

Open
morrisonlevi wants to merge 2 commits intomasterfrom
levi/parent-refcount
Open

fix(tracing): parentId refcount underflow#3851
morrisonlevi wants to merge 2 commits intomasterfrom
levi/parent-refcount

Conversation

@morrisonlevi
Copy link
Copy Markdown
Collaborator

Description

I was looking at customer crashes and codex was able to symbolize a crash that our crash tracker wasn't, and it looks like a corrupted $parent and crashed when inheriting the service from it.

I'm not sure this test is precisely the same issue, but nonetheless, it crashes.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@morrisonlevi morrisonlevi force-pushed the levi/parent-refcount branch from 34b1194 to 7868412 Compare May 1, 2026 01:03
@datadog-datadog-prod-us1-2
Copy link
Copy Markdown

datadog-datadog-prod-us1-2 Bot commented May 1, 2026

Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 60.68% (-0.01%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: a51ed01 | Docs | Datadog PR Page | Give us feedback!

@morrisonlevi morrisonlevi changed the title test(tracing): parent refcount underflow fix(tracing): $parent refcount underflow May 1, 2026
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented May 1, 2026

Benchmarks [ tracer ]

Benchmark execution time: 2026-05-01 02:59:42

Comparing candidate commit a51ed01 in PR branch levi/parent-refcount with baseline commit 82abdf3 in branch master.

Found 3 performance improvements and 4 performance regressions! Performance is the same for 187 metrics, 0 unstable metrics.

scenario:EmptyFileBench/benchEmptyFileDdprof-opcache

  • 🟥 execution_time [+101.842µs; +306.038µs] or [+2.794%; +8.395%]

scenario:PDOBench/benchPDOOverhead

  • 🟥 execution_time [+7.965µs; +9.772µs] or [+3.302%; +4.051%]

scenario:PDOBench/benchPDOOverhead-opcache

  • 🟩 execution_time [-9.987µs; -8.420µs] or [-4.015%; -3.385%]

scenario:PDOBench/benchPDOOverheadWithDBM

  • 🟥 execution_time [+7.378µs; +10.072µs] or [+3.062%; +4.180%]

scenario:PDOBench/benchPDOOverheadWithDBM-opcache

  • 🟩 execution_time [-9.172µs; -7.808µs] or [-3.695%; -3.145%]

scenario:PHPRedisBench/benchRedisOverhead

  • 🟥 execution_time [+28.512µs; +68.767µs] or [+3.143%; +7.582%]

scenario:PHPRedisBench/benchRedisOverhead-opcache

  • 🟩 execution_time [-48.743µs; -37.960µs] or [-4.748%; -3.698%]

@morrisonlevi morrisonlevi changed the title fix(tracing): $parent refcount underflow fix(tracing): parent_id refcount underflow May 1, 2026
@morrisonlevi morrisonlevi marked this pull request as ready for review May 1, 2026 15:07
@morrisonlevi morrisonlevi requested a review from a team as a code owner May 1, 2026 15:07
@morrisonlevi morrisonlevi changed the title fix(tracing): parent_id refcount underflow fix(tracing): parentId refcount underflow May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant