Skip to content

Properly reset SSI loader global state on shutdown to cleanly support reloading#3881

Merged
bwoebi merged 1 commit into
masterfrom
bob/ssi_reload
May 15, 2026
Merged

Properly reset SSI loader global state on shutdown to cleanly support reloading#3881
bwoebi merged 1 commit into
masterfrom
bob/ssi_reload

Conversation

@bwoebi
Copy link
Copy Markdown
Collaborator

@bwoebi bwoebi commented May 13, 2026

Otherwise loader module registration gets skipped, leading to skipped ddtrace MINIT.

@bwoebi bwoebi requested a review from a team as a code owner May 13, 2026 16:15
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 926eccf5c2

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread loader/dd_library_loader.c Outdated
… reloading

Otherwise loader module registration gets skipped, leading to skipped ddtrace MINIT.

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@datadog-datadog-prod-us1
Copy link
Copy Markdown

datadog-datadog-prod-us1 Bot commented May 13, 2026

Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 60.68% (-0.03%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 1519d05 | Docs | Datadog PR Page | Give us feedback!

@bwoebi bwoebi merged commit 90914b3 into master May 15, 2026
2115 of 2122 checks passed
@bwoebi bwoebi deleted the bob/ssi_reload branch May 15, 2026 11:54
@github-actions github-actions Bot added this to the 1.20.0 milestone May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants