[FEATURE]: dd-trace-py support granian

[diecgia]

Package Name

granian

Package Version(s)

No response

Describe the goal of the feature

Hi,
We want to add dd-trace-py on granian, is it possible to configure dd-trace-py in granian? How could it be integrated with granian? Is it currently possible to integrate it?

Thanks in advance!

Is your feature request related to a problem?

No response

Describe alternatives you've considered

No response

Additional context

No response

[P403n1x87]

@diecgia thanks for your feature request. We have not tested our library with granian, but in theory it should already work OOTB in either of two ways:

1. (preferred) wrap the command with ddtrace-run e.g. ddtrace-run granian --interface rgsi ...
2. import ddtrace.auto as the very first think in the main application module

I just did a quick test and method 1 seems to work fine. If you're willing to give these a try, please let us know if you encounter any issues.

[mabdinur]

@P403n1x87 suggestion will work if you're using granain with a web framework supported by ddtrace (flask, django, sanic, fastapi, etc.).

If not, we recommend using our wsgi or asgi trace middlewares to manually instrument your application: https://ddtrace.readthedocs.io/en/stable/integrations.html?highlight=asgi#module-ddtrace.contrib.asgi.

[matjam]

@P403n1x87 @mabdinur

Have either of you really tested this? Because while tracing works, profiling does not.

starting with ddtrace-run with

CMD ["ddtrace-run", "granian", "--host=0.0.0.0", "--port=10006", "--interface=wsgi", "--factory", "my_app.app"]

will give you

Yes, on the face of it, it "works" but you only get the trace of the granian process, not the workers.

Trying to instrument in the flask app factory also does not work, I've not gotten any useful output from that either.

[P403n1x87]

@matjam thanks for chiming in. Indeed we have done some testing to ensure that the tracer works (what you have shared above is a screenshot of the profiler). Here is a sample trace

This was generated with this very simple application

from ddtrace import tracer


async def app(scope, proto):
    with tracer.trace("test"):
        assert scope.proto == "http"

        proto.response_str(
            status=200, headers=[("content-type", "text/plain")], body="Hello, world!"
        )

and with this launch command

DD_SERVICE=granian-test ddtrace-run granian --interface rsgi app:app

Please do let us know if you're finding any issues with particular settings/frameworks and we would be happy to look into them for you.

[matjam]

@P403n1x87 Isn't profiling a part of the tracing library? I thought I was clear, tracing works, but I can't get any profiles so it sounds like something is broken there.

We're using WSGI if that makes any difference, its a Flask app.