Skip to content

Conversation

@avara1986
Copy link
Member

Backport 170e126 from #12740 to 3.2.

Removed environment variables from Python commands in envs.[scenario].scripts and moved them to [envs.[scenario].env-vars]. This improves command readability. Additionally, the internal variable _DD_IAST_PATCH_MODULES has been included to prevent potential conflicts observed in other refactors, such as #12639.

This PR is a cherry-pick of one of the commits of this PR #12639

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Removed environment variables from Python commands in
`envs.[scenario].scripts` and moved them to
`[envs.[scenario].env-vars]`. This improves command readability.
Additionally, the internal variable `_DD_IAST_PATCH_MODULES` has been
included to prevent potential conflicts observed in other refactors,
such as #12639.

This PR is a cherry-pick of one of the commits of this PR
#12639
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit 170e126)
@avara1986 avara1986 added changelog/no-changelog A changelog entry is not required for this PR. ASM Application Security Monitoring labels Mar 15, 2025
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Mar 15, 2025

Datadog Report

Branch report: backport-12740-to-3.1
Commit report: 2160929
Test service: dd-trace-py

✅ 0 Failed, 43 Passed, 460 Skipped, 1m 2.64s Total duration (3m 33.71s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Mar 15, 2025

Benchmarks

Benchmark execution time: 2025-03-18 14:41:58

Comparing candidate commit 2160929 in PR branch backport-12740-to-3.1 with baseline commit 5629b34 in branch 3.1.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 418 metrics, 2 unstable metrics.

@github-actions
Copy link
Contributor

CODEOWNERS have been resolved as:

hatch.toml                                                              @DataDog/python-guild

@avara1986 avara1986 marked this pull request as ready for review March 18, 2025 14:41
@avara1986 avara1986 requested a review from a team as a code owner March 18, 2025 14:41
@avara1986 avara1986 merged commit fd28ded into 3.1 Mar 24, 2025
791 of 800 checks passed
@avara1986 avara1986 deleted the backport-12740-to-3.1 branch March 24, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ASM Application Security Monitoring changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants