Skip to content

Conversation

@vitor-de-araujo
Copy link
Contributor

@vitor-de-araujo vitor-de-araujo commented Mar 17, 2025

For attempt-to-fix v2, we have to send the commit message as an argument to the test management endpoint.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@vitor-de-araujo vitor-de-araujo requested a review from a team as a code owner March 17, 2025 15:06
@github-actions
Copy link
Contributor

github-actions bot commented Mar 17, 2025

CODEOWNERS have been resolved as:

ddtrace/contrib/internal/pytest/_plugin_v2.py                           @DataDog/ci-app-libraries
ddtrace/internal/ci_visibility/_api_client.py                           @DataDog/ci-app-libraries
ddtrace/internal/ci_visibility/git_data.py                              @DataDog/ci-app-libraries
tests/ci_visibility/api_client/_util.py                                 @DataDog/ci-app-libraries
tests/ci_visibility/api_client/test_ci_visibility_api_client.py         @DataDog/ci-app-libraries

@vitor-de-araujo vitor-de-araujo added the changelog/no-changelog A changelog entry is not required for this PR. label Mar 17, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 17, 2025

Bootstrap import analysis

Comparison of import times between this PR and main.

Summary

The average import time in this PR is: 242 ± 3 ms.

The average import time in main is: 250 ± 5 ms.

The import time difference between this PR and main is: -7.5 ± 0.2 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 3.030 ms (1.25%)
ddtrace.bootstrap.sitecustomize 2.048 ms (0.85%)
ddtrace.bootstrap.preload 1.870 ms (0.77%)
ddtrace.internal.products 1.613 ms (0.67%)
ddtrace.internal.remoteconfig.client 0.745 ms (0.31%)
ddtrace.internal.symbol_db.remoteconfig 0.046 ms (0.02%)
ddtrace.internal.remoteconfig._connectors 0.046 ms (0.02%)
ctypes 0.046 ms (0.02%)
_ctypes 0.046 ms (0.02%)
ddtrace.settings.profiling 0.257 ms (0.11%)
ddtrace.vendor.psutil 0.200 ms (0.08%)
pwd 0.147 ms (0.06%)
ddtrace.internal.datadog.profiling.ddup 0.057 ms (0.02%)
ddtrace.internal.datadog.profiling.ddup._ddup 0.057 ms (0.02%)
ddtrace._trace.trace_handlers 0.178 ms (0.07%)
ddtrace._trace.utils_botocore.span_tags 0.137 ms (0.06%)
ddtrace._trace.utils_botocore.aws_payload_tagging 0.137 ms (0.06%)
ddtrace.vendor.jsonpath_ng 0.137 ms (0.06%)
ddtrace.vendor.jsonpath_ng.parser 0.137 ms (0.06%)
ddtrace.vendor.ply.yacc 0.137 ms (0.06%)
ddtrace 0.982 ms (0.41%)
ddtrace._logger 0.141 ms (0.06%)
ddtrace.settings._core 0.141 ms (0.06%)
ddtrace.settings 0.141 ms (0.06%)
ddtrace.settings._config 0.141 ms (0.06%)
ddtrace.internal.schema 0.141 ms (0.06%)
ddtrace.internal.schema.span_attribute_schema 0.141 ms (0.06%)
ddtrace.internal.module 0.085 ms (0.04%)
pathlib 0.085 ms (0.04%)
urllib.parse 0.085 ms (0.04%)
ipaddress 0.085 ms (0.04%)
ddtrace._monkey 0.036 ms (0.01%)
ddtrace.settings.asm 0.036 ms (0.01%)

@pr-commenter
Copy link

pr-commenter bot commented Mar 17, 2025

Benchmarks

Benchmark execution time: 2025-03-17 16:08:22

Comparing candidate commit b377ca4 in PR branch vitor-de-araujo/SDTEST-1632/attempt-to-fix-v2 with baseline commit a0e062b in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 488 metrics, 2 unstable metrics.

@vitor-de-araujo vitor-de-araujo merged commit 23def5c into main Mar 21, 2025
326 of 328 checks passed
@vitor-de-araujo vitor-de-araujo deleted the vitor-de-araujo/SDTEST-1632/attempt-to-fix-v2 branch March 21, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants