Skip to content

Conversation

@mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Mar 19, 2025

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@mabdinur mabdinur requested review from a team as code owners March 19, 2025 14:39
@mabdinur mabdinur added the changelog/no-changelog A changelog entry is not required for this PR. label Mar 19, 2025
@github-actions
Copy link
Contributor

CODEOWNERS have been resolved as:

ddtrace/internal/runtime/runtime_metrics.py                             @DataDog/apm-sdk-api-python
ddtrace/settings/_config.py                                             @DataDog/apm-core-python

@github-actions
Copy link
Contributor

github-actions bot commented Mar 19, 2025

Bootstrap import analysis

Comparison of import times between this PR and main.

Summary

The average import time in this PR is: 239 ± 3 ms.

The average import time in main is: 241 ± 3 ms.

The import time difference between this PR and main is: -1.8 ± 0.1 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 1.911 ms (0.80%)
ddtrace.bootstrap.sitecustomize 1.254 ms (0.52%)
ddtrace.bootstrap.preload 1.254 ms (0.52%)
ddtrace.internal.products 1.254 ms (0.52%)
ddtrace.internal.remoteconfig.client 0.628 ms (0.26%)
ddtrace 0.657 ms (0.27%)

@pr-commenter
Copy link

pr-commenter bot commented Mar 19, 2025

Benchmarks

Benchmark execution time: 2025-03-25 01:25:40

Comparing candidate commit 0a9e0a8 in PR branch munir/fix-runtimeid-typo with baseline commit 47d5913 in branch main.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 465 metrics, 2 unstable metrics.

scenario:iast_aspects-ospathdirname_aspect

  • 🟩 execution_time [-376.979ns; -317.700ns] or [-9.116%; -7.682%]

@mabdinur mabdinur enabled auto-merge (squash) March 19, 2025 16:39
@mabdinur mabdinur force-pushed the munir/fix-runtimeid-typo branch from 8781ab6 to a839989 Compare March 19, 2025 16:39
@mabdinur mabdinur merged commit 03a5ea0 into main Mar 25, 2025
822 of 824 checks passed
@mabdinur mabdinur deleted the munir/fix-runtimeid-typo branch March 25, 2025 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants