Skip to content

Conversation

@erikayasuda
Copy link
Collaborator

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@github-actions
Copy link
Contributor

CODEOWNERS have been resolved as:

ddtrace/_trace/utils_botocore/span_pointers/dynamodb.py                 @DataDog/apm-sdk-api-python
tests/tracer/utils_botocore/test_span_pointers.py                       @DataDog/apm-sdk-api-python

@github-actions
Copy link
Contributor

Bootstrap import analysis

Comparison of import times between this PR and main.

Summary

The average import time in this PR is: 242 ± 4 ms.

The average import time in main is: 244 ± 3 ms.

The import time difference between this PR and main is: -1.2 ± 0.1 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 1.955 ms (0.81%)
ddtrace.bootstrap.sitecustomize 1.302 ms (0.54%)
ddtrace.bootstrap.preload 1.302 ms (0.54%)
ddtrace.internal.products 1.302 ms (0.54%)
ddtrace.internal.remoteconfig.client 0.629 ms (0.26%)
ddtrace 0.653 ms (0.27%)

@pr-commenter
Copy link

pr-commenter bot commented Mar 19, 2025

Benchmarks

Benchmark execution time: 2025-03-19 15:58:54

Comparing candidate commit 9354610 in PR branch erikayasuda/test-no-main with baseline commit a0e062b in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 488 metrics, 2 unstable metrics.

@erikayasuda erikayasuda deleted the erikayasuda/test-no-main branch March 21, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants