Skip to content

Conversation

@jorgetomtz
Copy link
Contributor

@jorgetomtz jorgetomtz commented Mar 20, 2025

Problem

We are looking into modifying the default template used for VPA.

Solution

Set the annotation globally

Testing Done

https://app.datadoghq.com/s/yB5yjZ/xr8-36s-ip6

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@github-actions
Copy link
Contributor

CODEOWNERS have been resolved as:

.gitlab-ci.yml                                                          @DataDog/apm-core-python

@github-actions
Copy link
Contributor

github-actions bot commented Mar 20, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 275 ± 2 ms.

The average import time from base is: 276 ± 4 ms.

The import time difference between this PR and base is: -0.4 ± 0.1 ms.

The difference is not statistically significant (z = -2.45).

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 1.835 ms (0.67%)
ddtrace.bootstrap.sitecustomize 1.161 ms (0.42%)
ddtrace.bootstrap.preload 1.161 ms (0.42%)
ddtrace.internal.remoteconfig.client 0.607 ms (0.22%)
ddtrace 0.675 ms (0.25%)
ddtrace.internal._unpatched 0.031 ms (0.01%)
json 0.031 ms (0.01%)
json.decoder 0.031 ms (0.01%)
re 0.031 ms (0.01%)
enum 0.031 ms (0.01%)
types 0.031 ms (0.01%)

@pr-commenter
Copy link

pr-commenter bot commented Mar 20, 2025

Benchmarks

Benchmark execution time: 2025-06-12 15:35:27

Comparing candidate commit 998993b in PR branch jorgetomtz/test-vpa-template-config with baseline commit fd2bcdf in branch main.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 564 metrics, 7 unstable metrics.

scenario:telemetryaddmetric-1-gauge-metric-1-times

  • 🟥 execution_time [+170.040ns; +229.353ns] or [+7.846%; +10.582%]

@jorgetomtz jorgetomtz changed the title Add vpa template configuraion Add vpa template configuration Mar 21, 2025
jorgetomtz added a commit that referenced this pull request Mar 21, 2025
@jorgetomtz jorgetomtz force-pushed the jorgetomtz/test-vpa-template-config branch from 8e1afec to 6ac4044 Compare March 21, 2025 14:23
jorgetomtz added a commit that referenced this pull request Mar 21, 2025
@jorgetomtz jorgetomtz force-pushed the jorgetomtz/test-vpa-template-config branch from 6ac4044 to 35ab719 Compare March 21, 2025 19:55
jorgetomtz added a commit that referenced this pull request Mar 24, 2025
@jorgetomtz jorgetomtz force-pushed the jorgetomtz/test-vpa-template-config branch from 35ab719 to 9646268 Compare March 24, 2025 14:20
jorgetomtz added a commit that referenced this pull request Mar 27, 2025
@jorgetomtz jorgetomtz force-pushed the jorgetomtz/test-vpa-template-config branch from 9646268 to 0b32546 Compare March 27, 2025 16:43
jorgetomtz added a commit that referenced this pull request Mar 27, 2025
@jorgetomtz jorgetomtz force-pushed the jorgetomtz/test-vpa-template-config branch from 0b32546 to bdac44d Compare March 27, 2025 16:44
@jorgetomtz jorgetomtz marked this pull request as ready for review March 27, 2025 16:47
@jorgetomtz jorgetomtz requested a review from a team as a code owner March 27, 2025 16:47
@jorgetomtz jorgetomtz requested a review from juanjux March 27, 2025 16:47
@brettlangdon brettlangdon changed the title Add vpa template configuration ci: add vpa template configuration Mar 28, 2025
@brettlangdon brettlangdon added the changelog/no-changelog A changelog entry is not required for this PR. label Mar 28, 2025
jorgetomtz added a commit that referenced this pull request Apr 1, 2025
@jorgetomtz jorgetomtz force-pushed the jorgetomtz/test-vpa-template-config branch from ca9d041 to ce8a799 Compare April 1, 2025 15:57
@erikayasuda erikayasuda enabled auto-merge (squash) April 3, 2025 17:18
jorgetomtz added a commit that referenced this pull request Apr 22, 2025
@jorgetomtz jorgetomtz force-pushed the jorgetomtz/test-vpa-template-config branch from 6cf5c43 to ba79173 Compare April 22, 2025 16:38
jorgetomtz added a commit that referenced this pull request May 7, 2025
@jorgetomtz jorgetomtz force-pushed the jorgetomtz/test-vpa-template-config branch from ba79173 to 3eb4ce0 Compare May 7, 2025 14:21
@jorgetomtz jorgetomtz disabled auto-merge May 8, 2025 20:33
@jorgetomtz
Copy link
Contributor Author

Something is up with the new template as this level of failures is unexpected. Gotta investigate so putting it back in draft for now

@jorgetomtz jorgetomtz marked this pull request as draft May 8, 2025 20:33
jorgetomtz added a commit that referenced this pull request Jun 4, 2025
@jorgetomtz jorgetomtz force-pushed the jorgetomtz/test-vpa-template-config branch from 3eb4ce0 to 1bfe952 Compare June 4, 2025 08:54
jorgetomtz added a commit that referenced this pull request Jun 4, 2025
@jorgetomtz jorgetomtz force-pushed the jorgetomtz/test-vpa-template-config branch from 1bfe952 to a7cfaa2 Compare June 4, 2025 08:55
jorgetomtz added a commit that referenced this pull request Jun 4, 2025
@jorgetomtz jorgetomtz force-pushed the jorgetomtz/test-vpa-template-config branch from a7cfaa2 to 1142e5e Compare June 4, 2025 09:09
jorgetomtz added a commit that referenced this pull request Jun 5, 2025
@jorgetomtz jorgetomtz force-pushed the jorgetomtz/test-vpa-template-config branch from 1142e5e to 2073112 Compare June 5, 2025 13:58
jorgetomtz added a commit that referenced this pull request Jun 5, 2025
@jorgetomtz jorgetomtz force-pushed the jorgetomtz/test-vpa-template-config branch from 2073112 to 2dba2d8 Compare June 5, 2025 14:03
jorgetomtz added a commit that referenced this pull request Jun 10, 2025
@jorgetomtz jorgetomtz force-pushed the jorgetomtz/test-vpa-template-config branch from 2dba2d8 to 2f25a9d Compare June 10, 2025 19:43
jorgetomtz added a commit that referenced this pull request Jun 12, 2025
@jorgetomtz jorgetomtz force-pushed the jorgetomtz/test-vpa-template-config branch from 2f25a9d to 998993b Compare June 12, 2025 14:32
@jorgetomtz
Copy link
Contributor Author

/trigger-ci

@dd-devflow
Copy link

dd-devflow bot commented Jun 12, 2025

View all feedbacks in Devflow UI.

2025-06-12 14:55:41 UTC ℹ️ Start processing command /trigger-ci


2025-06-12 14:55:58 UTC ℹ️ Branch synced on Gitlab

Branch jorgetomtz/test-vpa-template-config was out-of-sync on Gitlab - it has been resynced


2025-06-12 14:56:02 UTC ℹ️ Gitlab pipeline started

Started pipeline #67550689

@jorgetomtz jorgetomtz force-pushed the jorgetomtz/test-vpa-template-config branch from 998993b to 9597b39 Compare June 13, 2025 13:28
@jorgetomtz
Copy link
Contributor Author

/trigger-ci

@dd-devflow
Copy link

dd-devflow bot commented Jun 13, 2025

View all feedbacks in Devflow UI.

2025-06-13 17:30:25 UTC ℹ️ Start processing command /trigger-ci


2025-06-13 17:30:30 UTC ℹ️ Gitlab pipeline started

Started pipeline #67712642

@jorgetomtz
Copy link
Contributor Author

/trigger-ci

@dd-devflow
Copy link

dd-devflow bot commented Jun 13, 2025

View all feedbacks in Devflow UI.

2025-06-13 18:35:25 UTC ℹ️ Start processing command /trigger-ci


2025-06-13 18:35:32 UTC ℹ️ Gitlab pipeline started

Started pipeline #67723830

@jorgetomtz jorgetomtz closed this Jun 13, 2025
@jorgetomtz
Copy link
Contributor Author

Going for a fresh start to capture impact of new template separately

@jorgetomtz jorgetomtz deleted the jorgetomtz/test-vpa-template-config branch June 13, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants