Skip to content

chore(llmobs): fix root span tag for telemetry metrics #12828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Yun-Kim merged 2 commits into from
Mar 21, 2025
Merged

chore(llmobs): fix root span tag for telemetry metrics #12828

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
424014a
Fix root span tag
Yun-Kim Mar 20, 2025
bdfc241
Merge branch 'main' into yunkim/llmobs-root-span-telemetry
Yun-Kim Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ddtrace/llmobs/_telemetry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ def record_span_started():


def record_span_created(span: Span):
is_root_span = span._get_ctx_item(PARENT_ID_KEY) != ROOT_PARENT_ID
is_root_span = span._get_ctx_item(PARENT_ID_KEY) == ROOT_PARENT_ID
has_session_id = span._get_ctx_item(SESSION_ID) is not None
integration = span._get_ctx_item(INTEGRATION)
autoinstrumented = integration is not None
Expand Down Expand Up @@ -149,7 +149,7 @@ def record_llmobs_annotate(span: Optional[Span], error: Optional[str]):
is_root_span = "0"
if span and isinstance(span, Span):
span_kind = span._get_ctx_item(SPAN_KIND) or "N/A"
is_root_span = str(int(span._get_ctx_item(PARENT_ID_KEY) != ROOT_PARENT_ID))
is_root_span = str(int(span._get_ctx_item(PARENT_ID_KEY) == ROOT_PARENT_ID))
tags.extend([("span_kind", span_kind), ("is_root_span", is_root_span)])
telemetry_writer.add_count_metric(
namespace=TELEMETRY_NAMESPACE.MLOBS, name=LLMObsTelemetryMetrics.ANNOTATIONS, value=1, tags=tuple(tags)
Expand All @@ -172,7 +172,7 @@ def record_span_exported(span: Optional[Span], error: Optional[str]):
is_root_span = "0"
if span and isinstance(span, Span):
span_kind = span._get_ctx_item(SPAN_KIND) or "N/A"
is_root_span = str(int(span._get_ctx_item(PARENT_ID_KEY) != ROOT_PARENT_ID))
is_root_span = str(int(span._get_ctx_item(PARENT_ID_KEY) == ROOT_PARENT_ID))
tags.extend([("span_kind", span_kind), ("is_root_span", is_root_span)])
telemetry_writer.add_count_metric(
namespace=TELEMETRY_NAMESPACE.MLOBS, name=LLMObsTelemetryMetrics.SPANS_EXPORTED, value=1, tags=tuple(tags)
Expand Down
Loading