Skip to content

Conversation

@taegyunkim
Copy link
Contributor

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@taegyunkim taegyunkim requested a review from a team as a code owner March 24, 2025 15:09
@taegyunkim taegyunkim requested a review from sanchda March 24, 2025 15:09
@github-actions
Copy link
Contributor

CODEOWNERS have been resolved as:

setup.py                                                                @DataDog/python-guild

@github-actions
Copy link
Contributor

Bootstrap import analysis

Comparison of import times between this PR and main.

Summary

The average import time in this PR is: 241 ± 3 ms.

The average import time in main is: 242 ± 3 ms.

The import time difference between this PR and main is: -1.2 ± 0.1 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 1.903 ms (0.79%)
ddtrace.bootstrap.sitecustomize 1.282 ms (0.53%)
ddtrace.bootstrap.preload 1.282 ms (0.53%)
ddtrace.internal.products 1.282 ms (0.53%)
ddtrace.internal.remoteconfig.client 0.626 ms (0.26%)
ddtrace 0.621 ms (0.26%)

@pr-commenter
Copy link

pr-commenter bot commented Mar 24, 2025

Benchmarks

Benchmark execution time: 2025-03-24 15:50:48

Comparing candidate commit c30bd30 in PR branch taegyunkim/gitlab-broken with baseline commit 9159b81 in branch main.

Found 2 performance improvements and 4 performance regressions! Performance is the same for 492 metrics, 2 unstable metrics.

scenario:iast_aspects-format_map_aspect

  • 🟥 execution_time [+492.518ns; +560.076ns] or [+9.653%; +10.978%]

scenario:iast_aspects-ospathbasename_aspect

  • 🟥 execution_time [+268.148ns; +323.439ns] or [+8.057%; +9.719%]

scenario:iast_aspects-ospathdirname_aspect

  • 🟥 execution_time [+324.523ns; +390.418ns] or [+8.581%; +10.323%]

scenario:iast_aspects-ospathjoin_aspect

  • 🟥 execution_time [+388.317ns; +458.312ns] or [+7.701%; +9.090%]

scenario:iast_aspects-ospathsplitdrive_aspect

  • 🟩 execution_time [-290.171ns; -248.817ns] or [-9.532%; -8.174%]

scenario:iast_aspects-ospathsplitext_aspect

  • 🟩 execution_time [-596.020ns; -525.384ns] or [-14.040%; -12.376%]

@emmettbutler emmettbutler marked this pull request as draft March 24, 2025 16:15
@taegyunkim taegyunkim closed this Mar 25, 2025
@taegyunkim taegyunkim deleted the taegyunkim/gitlab-broken branch March 25, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants