-
Notifications
You must be signed in to change notification settings - Fork 477
fix(profiling): sample types are refreshed on fork #12865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 232 ± 3 ms. The average import time from base is: 241 ± 7 ms. The import time difference between this PR and base is: -8.5 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
BenchmarksBenchmark execution time: 2025-04-17 18:50:22 Comparing candidate commit 51400ad in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 440 metrics, 8 unstable metrics. |
38fbc7f to
0589d5e
Compare
|
@taegyunkim cleaning up old PRs, notice that this one is still hanging. Not sure what your plan is, but didn't want to risk leaving it ignored if it was wanted. 🥂 |
I still don't know how it happens, but customers are reporting that with the introduction of stack v2 as the default stack collector(and hence, the libdatadog-based collection and export) a lot of log spam related to profiler not having the right sample types (these logs originate from within libdatadog and show an uninitialized Profiling object).
My best guess is that this is related to early forking, so this PR mostly tries to address that by re-initializing even more things on fork.
Checklist
Reviewer Checklist