Skip to content

Conversation

@mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Mar 24, 2025

Drops support for OpenTracing API. The OpenTelemetry API should be used instead.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2025

CODEOWNERS have been resolved as:

releasenotes/notes/deprecate-opentracing-6d3e10a0581717a6.yaml          @DataDog/apm-python
ddtrace/opentracer/__init__.py                                          @DataDog/apm-sdk-api-python
docs/advanced_usage.rst                                                 @DataDog/python-guild
docs/installation_quickstart.rst                                        @DataDog/python-guild

@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 229 ± 3 ms.

The average import time from base is: 232 ± 4 ms.

The import time difference between this PR and base is: -3.0 ± 0.1 ms.

Import time breakdown

The following import paths have grown:

ddtrace.auto 0.324 ms (0.14%)
ddtrace.bootstrap.sitecustomize 0.324 ms (0.14%)
ddtrace.bootstrap.preload 0.324 ms (0.14%)
ddtrace.internal.products 0.158 ms (0.07%)
ddtrace.internal.symbol_db.remoteconfig 0.081 ms (0.04%)
ddtrace.internal.symbol_db.symbols 0.081 ms (0.04%)
ddtrace.settings.symbol_db 0.081 ms (0.04%)
ddtrace.internal.remoteconfig.worker 0.078 ms (0.03%)
ddtrace.internal.runtime.runtime_metrics 0.094 ms (0.04%)
ddtrace.settings.profiling 0.072 ms (0.03%)
ddtrace.internal.datadog.profiling.stack_v2 0.072 ms (0.03%)
ddtrace.internal.datadog.profiling.stack_v2._stack_v2 0.072 ms (0.03%)

The following import paths have shrunk:

ddtrace.auto 2.408 ms (1.05%)
ddtrace.bootstrap.sitecustomize 1.739 ms (0.76%)
ddtrace.bootstrap.preload 1.739 ms (0.76%)
ddtrace.internal.products 1.556 ms (0.68%)
ddtrace.internal.remoteconfig.client 0.663 ms (0.29%)
ddtrace.internal.symbol_db.remoteconfig 0.172 ms (0.08%)
ddtrace.internal.symbol_db.symbols 0.172 ms (0.08%)
ddtrace.settings.dynamic_instrumentation 0.080 ms (0.03%)
ddtrace.settings.crashtracker 0.098 ms (0.04%)
ddtrace.settings.profiling 0.085 ms (0.04%)
ddtrace 0.669 ms (0.29%)

@pr-commenter
Copy link

pr-commenter bot commented Mar 24, 2025

Benchmarks

Benchmark execution time: 2025-04-03 19:52:23

Comparing candidate commit 10f73cf in PR branch munir/deprecate-ot with baseline commit 55aaf72 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 498 metrics, 2 unstable metrics.

@mabdinur mabdinur force-pushed the munir/deprecate-ot branch from 4d8d72f to 1105d8e Compare March 25, 2025 16:21
@mabdinur mabdinur marked this pull request as ready for review March 25, 2025 16:22
@mabdinur mabdinur requested review from a team as code owners March 25, 2025 16:22
@mabdinur mabdinur requested a review from a team as a code owner March 25, 2025 16:22
@mabdinur mabdinur enabled auto-merge (squash) March 25, 2025 16:22
@mabdinur mabdinur changed the title chore(opentracing): deprecate opentracing chore(opentracing): deprecate opentracing Mar 25, 2025
@mabdinur mabdinur merged commit 38a2571 into main Apr 3, 2025
271 checks passed
@mabdinur mabdinur deleted the munir/deprecate-ot branch April 3, 2025 21:04
chojomok pushed a commit that referenced this pull request Apr 7, 2025
Drops support for OpenTracing API. The OpenTelemetry API should be used
instead.


## Checklist
- [ ] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [ ] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants