Skip to content

Conversation

@P403n1x87
Copy link
Contributor

@P403n1x87 P403n1x87 commented Mar 26, 2025

We make changes to the SymbolDB RC adapter to support the recent RC refactor.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

We make changes to the SymbolDB RC adapter to support the recent RC
refactor.
@P403n1x87 P403n1x87 added the changelog/no-changelog A changelog entry is not required for this PR. label Mar 26, 2025
@P403n1x87 P403n1x87 requested a review from a team as a code owner March 26, 2025 09:21
@github-actions
Copy link
Contributor

github-actions bot commented Mar 26, 2025

CODEOWNERS have been resolved as:

.github/workflows/system-tests.yml                                      @DataDog/python-guild @DataDog/apm-core-python
ddtrace/internal/symbol_db/remoteconfig.py                              @DataDog/debugger-python

@github-actions
Copy link
Contributor

github-actions bot commented Mar 26, 2025

Bootstrap import analysis

Comparison of import times between this PR and main.

Summary

The average import time in this PR is: 229 ± 3 ms.

The average import time in main is: 231 ± 2 ms.

The import time difference between this PR and main is: -1.6 ± 0.1 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 1.926 ms (0.84%)
ddtrace.bootstrap.sitecustomize 1.294 ms (0.56%)
ddtrace.bootstrap.preload 1.294 ms (0.56%)
ddtrace.internal.products 1.294 ms (0.56%)
ddtrace.internal.remoteconfig.client 0.653 ms (0.28%)
ddtrace 0.632 ms (0.28%)

@pr-commenter
Copy link

pr-commenter bot commented Mar 26, 2025

Benchmarks

Benchmark execution time: 2025-03-26 10:08:01

Comparing candidate commit 77b2008 in PR branch chore/symdb-rc-refactor with baseline commit 8ea5176 in branch main.

Found 0 performance improvements and 4 performance regressions! Performance is the same for 494 metrics, 2 unstable metrics.

scenario:iast_aspects-ospathbasename_aspect

  • 🟥 execution_time [+513.473ns; +566.193ns] or [+15.469%; +17.057%]

scenario:iast_aspects-ospathjoin_aspect

  • 🟥 execution_time [+381.883ns; +451.179ns] or [+7.579%; +8.954%]

scenario:iast_aspects-ospathsplit_aspect

  • 🟥 execution_time [+547.213ns; +612.672ns] or [+14.022%; +15.699%]

scenario:iast_aspects-split_aspect

  • 🟥 execution_time [+199.414ns; +225.786ns] or [+11.988%; +13.573%]

@P403n1x87 P403n1x87 merged commit efa4325 into main Mar 26, 2025
286 of 287 checks passed
@P403n1x87 P403n1x87 deleted the chore/symdb-rc-refactor branch March 26, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants