Skip to content

Conversation

@P403n1x87
Copy link
Contributor

@P403n1x87 P403n1x87 commented Mar 26, 2025

We add support to Dynamic Instrumentation for the Decimal type from the standard library. With this change, values of this type will have a more explicit representation in dynamic logs, and can be used, after a convertion to float, in metrics and other expressions.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

We add support to Dynamic Instrumentation for the Decimal type from the
standard library. With this change, values of this type will have a more
explicit representation in dynamic logs, and can be used, after a
convertion to float, in metrics and other expressions.
@P403n1x87 P403n1x87 added changelog/no-changelog A changelog entry is not required for this PR. Dynamic Instrumentation Dynamic Instrumentation/Live Debugger labels Mar 26, 2025
@P403n1x87 P403n1x87 requested a review from a team as a code owner March 26, 2025 19:52
@github-actions
Copy link
Contributor

github-actions bot commented Mar 26, 2025

CODEOWNERS have been resolved as:

releasenotes/notes/chore-di-support-decimal-e75525e282c50a2f.yaml       @DataDog/apm-python
ddtrace/debugging/_expressions.py                                       @DataDog/debugger-python
ddtrace/debugging/_signal/utils.py                                      @DataDog/debugger-python
tests/debugging/test_debugger.py                                        @DataDog/debugger-python

@github-actions
Copy link
Contributor

github-actions bot commented Mar 26, 2025

Bootstrap import analysis

Comparison of import times between this PR and main.

Summary

The average import time in this PR is: 228 ± 3 ms.

The average import time in main is: 230 ± 3 ms.

The import time difference between this PR and main is: -2.1 ± 0.1 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 1.986 ms (0.87%)
ddtrace.bootstrap.sitecustomize 1.342 ms (0.59%)
ddtrace.bootstrap.preload 1.342 ms (0.59%)
ddtrace.internal.products 1.342 ms (0.59%)
ddtrace.internal.remoteconfig.client 0.699 ms (0.31%)
ddtrace 0.644 ms (0.28%)

@pr-commenter
Copy link

pr-commenter bot commented Mar 26, 2025

Benchmarks

Benchmark execution time: 2025-03-26 22:18:53

Comparing candidate commit 06d4b60 in PR branch chore/di-support-decimal with baseline commit 269b3d8 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 498 metrics, 2 unstable metrics.

@P403n1x87 P403n1x87 changed the title chore(debugging): add support for Decimal feat(debugging): add support for Decimal Mar 26, 2025
@P403n1x87 P403n1x87 removed the changelog/no-changelog A changelog entry is not required for this PR. label Mar 26, 2025
@P403n1x87 P403n1x87 requested a review from a team as a code owner March 26, 2025 21:35
@P403n1x87 P403n1x87 enabled auto-merge (squash) March 26, 2025 22:11
@P403n1x87 P403n1x87 merged commit 15351ae into main Mar 28, 2025
279 of 283 checks passed
@P403n1x87 P403n1x87 deleted the chore/di-support-decimal branch March 28, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dynamic Instrumentation Dynamic Instrumentation/Live Debugger

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants