Skip to content

Conversation

@gnufede
Copy link
Member

@gnufede gnufede commented Mar 27, 2025

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@github-actions
Copy link
Contributor

github-actions bot commented Mar 27, 2025

CODEOWNERS have been resolved as:

ddtrace/internal/ci_visibility/_api_client.py                           @DataDog/ci-app-libraries
ddtrace/internal/ci_visibility/api/_base.py                             @DataDog/ci-app-libraries
ddtrace/internal/ci_visibility/api/_test.py                             @DataDog/ci-app-libraries
ddtrace/internal/ci_visibility/recorder.py                              @DataDog/ci-app-libraries
ddtrace/internal/ci_visibility/telemetry/git.py                         @DataDog/ci-app-libraries
tests/ci_visibility/api_client/_util.py                                 @DataDog/ci-app-libraries
tests/ci_visibility/api_client/test_ci_visibility_api_client.py         @DataDog/ci-app-libraries
tests/ci_visibility/api_client/test_ci_visibility_api_client_unique_tests_responses.py  @DataDog/ci-app-libraries
tests/ci_visibility/util.py                                             @DataDog/ci-app-libraries
tests/contrib/pytest/test_pytest_efd.py                                 @DataDog/ci-app-libraries

@github-actions
Copy link
Contributor

github-actions bot commented Mar 27, 2025

Bootstrap import analysis

Comparison of import times between this PR and main.

Summary

The average import time in this PR is: 230 ± 3 ms.

The average import time in main is: 232 ± 3 ms.

The import time difference between this PR and main is: -2.2 ± 0.1 ms.

Import time breakdown

The following import paths have appeared:

ddtrace.auto 9.624 ms (4.19%)
ddtrace.bootstrap.sitecustomize 9.624 ms (4.19%)
ddtrace.bootstrap.preload 9.624 ms (4.19%)
ddtrace.internal.products 9.624 ms (4.19%)
ddtrace.internal.symbol_db.remoteconfig 6.244 ms (2.72%)
multiprocessing 4.408 ms (1.92%)
multiprocessing.context 4.084 ms (1.78%)
multiprocessing.reduction 2.232 ms (0.97%)
pickle 1.803 ms (0.78%)
_compat_pickle 0.435 ms (0.19%)
_pickle 0.397 ms (0.17%)
multiprocessing.process 1.232 ms (0.54%)
multiprocessing.sharedctypes 1.835 ms (0.80%)
multiprocessing.heap 1.173 ms (0.51%)
multiprocessing.util 0.415 ms (0.18%)
mmap 0.396 ms (0.17%)
ddtrace.internal.remoteconfig.client 3.380 ms (1.47%)
ddtrace.internal.remoteconfig._pubsub 3.380 ms (1.47%)
ddtrace.internal.remoteconfig._subscribers 2.749 ms (1.20%)
ddtrace.internal.remoteconfig._connectors 2.421 ms (1.05%)
ctypes 1.980 ms (0.86%)
_ctypes 0.548 ms (0.24%)
ctypes._endian 0.440 ms (0.19%)
ddtrace.internal.remoteconfig._publishers 0.324 ms (0.14%)

The following import paths have disappeared:

ddtrace.auto 9.581 ms (4.17%)
ddtrace.bootstrap.sitecustomize 9.581 ms (4.17%)
ddtrace.bootstrap.preload 9.581 ms (4.17%)
ddtrace.internal.products 9.581 ms (4.17%)
multiprocessing 3.729 ms (1.62%)
multiprocessing.context 3.400 ms (1.48%)
multiprocessing.reduction 2.251 ms (0.98%)
pickle 1.828 ms (0.79%)
_compat_pickle 0.450 ms (0.20%)
_pickle 0.401 ms (0.17%)
multiprocessing.process 0.446 ms (0.19%)
multiprocessing.sharedctypes 2.532 ms (1.10%)
multiprocessing.heap 1.859 ms (0.81%)
mmap 1.089 ms (0.47%)
multiprocessing.util 0.408 ms (0.18%)
ddtrace.internal.remoteconfig._connectors 2.357 ms (1.03%)
ctypes 1.998 ms (0.87%)
_ctypes 0.627 ms (0.27%)
ctypes._endian 0.427 ms (0.19%)
ddtrace.internal.remoteconfig._pubsub 0.631 ms (0.27%)
ddtrace.internal.remoteconfig._subscribers 0.332 ms (0.14%)
ddtrace.internal.remoteconfig._publishers 0.331 ms (0.14%)

The following import paths have grown:

ddtrace.auto 2.896 ms (1.26%)
ddtrace.bootstrap.sitecustomize 2.161 ms (0.94%)
ddtrace.bootstrap.preload 1.947 ms (0.85%)
ddtrace.settings.profiling 0.822 ms (0.36%)
ddtrace.vendor.psutil 0.718 ms (0.31%)
ddtrace.vendor.psutil._pslinux 0.718 ms (0.31%)
glob 0.718 ms (0.31%)
ddtrace.internal.datadog.profiling.ddup 0.103 ms (0.04%)
ddtrace.internal.datadog.profiling.ddup._ddup 0.103 ms (0.04%)
ddtrace.internal.products 0.177 ms (0.08%)
ddtrace.internal.symbol_db.remoteconfig 0.177 ms (0.08%)
ddtrace.internal.symbol_db.symbols 0.088 ms (0.04%)
ddtrace.internal.utils.inspection 0.088 ms (0.04%)
ddtrace.settings.crashtracker 0.102 ms (0.04%)
ddtrace.internal.flare._subscribers 0.016 ms (0.01%)
ddtrace._trace.trace_handlers 0.124 ms (0.05%)
ddtrace.contrib.trace_utils 0.077 ms (0.03%)
ddtrace.contrib.internal.redis_utils 0.077 ms (0.03%)
ddtrace.contrib.internal 0.077 ms (0.03%)
ddtrace._trace._inferred_proxy 0.047 ms (0.02%)
ddtrace.propagation.http 0.047 ms (0.02%)
ddtrace.propagation 0.047 ms (0.02%)
ddtrace.contrib.internal.subprocess.constants 0.091 ms (0.04%)
ddtrace 0.734 ms (0.32%)
ddtrace.settings._config 0.381 ms (0.17%)
ddtrace._trace.pin 0.107 ms (0.05%)
ddtrace.settings.endpoint_config 0.087 ms (0.04%)
ddtrace.internal.utils.retry 0.087 ms (0.04%)
ddtrace.internal.gitmetadata 0.075 ms (0.03%)
ddtrace.ext.ci 0.075 ms (0.03%)
ddtrace.ext.git 0.075 ms (0.03%)
subprocess 0.075 ms (0.03%)
fcntl 0.075 ms (0.03%)
ddtrace.trace 0.268 ms (0.12%)
ddtrace._trace.filters 0.192 ms (0.08%)
ddtrace._trace.processor 0.192 ms (0.08%)
ddtrace._trace.sampler 0.091 ms (0.04%)
ddtrace._trace.span 0.091 ms (0.04%)
ddtrace.internal.sampling 0.091 ms (0.04%)
ddtrace._trace.sampling_rule 0.091 ms (0.04%)
ddtrace._trace.tracer 0.075 ms (0.03%)
ddtrace.internal.schema.processor 0.075 ms (0.03%)
ddtrace._monkey 0.086 ms (0.04%)
ddtrace.appsec 0.086 ms (0.04%)
ddtrace.internal.core 0.086 ms (0.04%)
ddtrace.internal.core.event_hub 0.086 ms (0.04%)

The following import paths have shrunk:

ddtrace.auto 4.995 ms (2.17%)
ddtrace.bootstrap.sitecustomize 3.738 ms (1.63%)
ddtrace.bootstrap.preload 3.592 ms (1.56%)
ddtrace.internal.products 2.679 ms (1.16%)
ddtrace.internal.remoteconfig.client 0.628 ms (0.27%)
ddtrace.internal.symbol_db.remoteconfig 0.193 ms (0.08%)
ddtrace.internal.symbol_db.symbols 0.193 ms (0.08%)
ddtrace.settings.profiling 0.830 ms (0.36%)
ddtrace.vendor.psutil 0.725 ms (0.32%)
ddtrace.vendor.psutil._pslinux 0.725 ms (0.32%)
ddtrace.vendor.psutil._psposix 0.725 ms (0.32%)
ddtrace.internal.datadog.profiling.stack_v2 0.105 ms (0.05%)
ddtrace.internal.datadog.profiling.stack_v2._stack_v2 0.105 ms (0.05%)
ddtrace.appsec._remoteconfiguration 0.084 ms (0.04%)
ddtrace._trace.trace_handlers 0.146 ms (0.06%)
ddtrace.contrib.trace_utils 0.077 ms (0.03%)
ddtrace.contrib.internal.trace_utils 0.077 ms (0.03%)
ddtrace.ext.user 0.077 ms (0.03%)
ddtrace._trace._inferred_proxy 0.068 ms (0.03%)
ddtrace.propagation.http 0.068 ms (0.03%)
ddtrace 1.257 ms (0.55%)
ddtrace.trace 0.282 ms (0.12%)
ddtrace._trace.filters 0.196 ms (0.09%)
ddtrace._trace.processor 0.196 ms (0.09%)
ddtrace._trace.sampler 0.196 ms (0.09%)
ddtrace._trace.span 0.092 ms (0.04%)
ddtrace.internal.sampling 0.092 ms (0.04%)
ddtrace._trace.sampling_rule 0.092 ms (0.04%)
ddtrace.internal.glob_matching 0.092 ms (0.04%)
ddtrace._trace.tracer 0.085 ms (0.04%)
ddtrace.settings.peer_service 0.085 ms (0.04%)
ddtrace.settings._config 0.207 ms (0.09%)
ddtrace.internal.gitmetadata 0.207 ms (0.09%)
ddtrace.ext.ci 0.103 ms (0.04%)
ddtrace.ext.git 0.103 ms (0.04%)
subprocess 0.103 ms (0.04%)
ddtrace._monkey 0.099 ms (0.04%)
ddtrace.appsec 0.099 ms (0.04%)
ddtrace.internal.core 0.099 ms (0.04%)

@pr-commenter
Copy link

pr-commenter bot commented Mar 27, 2025

Benchmarks

Benchmark execution time: 2025-03-27 12:28:22

Comparing candidate commit ba4d01d in PR branch gnufede/SDTEST-1273 with baseline commit 46f1323 in branch main.

Found 3 performance improvements and 0 performance regressions! Performance is the same for 495 metrics, 2 unstable metrics.

scenario:iast_aspects-ospathsplit_aspect

  • 🟩 execution_time [-440.322ns; -375.645ns] or [-10.252%; -8.746%]

scenario:iast_aspects-ospathsplitext_aspect

  • 🟩 execution_time [-586.444ns; -529.866ns] or [-14.060%; -12.704%]

scenario:iast_aspects-split_aspect

  • 🟩 execution_time [-150.684ns; -126.890ns] or [-8.398%; -7.072%]

is_quarantined: bool = False,
is_disabled: bool = False,
is_attempt_to_fix: bool = False,
is_known_test_enabled: bool = False,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need this, we can access through session_settings

@github-actions github-actions bot added the stale label May 1, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2025

This pull request has been automatically closed after a period of inactivity.
After this much time, it will likely be easier to open a new pull request with the
same changes than to update this one from the base branch. Please comment or reopen
if you think this pull request was closed in error.

@github-actions github-actions bot closed this May 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants