-
Notifications
You must be signed in to change notification settings - Fork 474
fix(llmobs): swap error type/message in openai agents sdk #13461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 231 ± 2 ms. The average import time from base is: 233 ± 2 ms. The import time difference between this PR and base is: -2.33 ± 0.1 ms. Import time breakdownThe following import paths have shrunk:
|
BenchmarksBenchmark execution time: 2025-05-29 15:47:11 Comparing candidate commit 1b2813a in PR branch Found 0 performance improvements and 3 performance regressions! Performance is the same for 504 metrics, 9 unstable metrics. scenario:iastaspects-lstrip_aspect
scenario:iastaspects-strip_aspect
scenario:iastaspectsospath-ospathsplit_aspect
|
Co-authored-by: Yun Kim <35776586+Yun-Kim@users.noreply.github.com>
Swap error message & type for the openai agents sdk
The error data returned by openai is currently being set to the error type on the llm obs span. Since its verbose, this has caused some UX issues since error types are expected to be short.
The error "message" from oai agents tracing is actually more fit to be our error type, since its a concise message
Checklist
Reviewer Checklist