Skip to content

Conversation

@juanjux
Copy link
Collaborator

@juanjux juanjux commented May 22, 2025

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
@juanjux juanjux self-assigned this May 22, 2025
@juanjux juanjux requested review from a team as code owners May 22, 2025 13:55
@juanjux juanjux added the CI label May 22, 2025
@github-actions
Copy link
Contributor

CODEOWNERS have been resolved as:

.riot/requirements/175a6ba.txt                                          @DataDog/apm-python
.riot/requirements/18da66a.txt                                          @DataDog/apm-python
.riot/requirements/6dcdfb3.txt                                          @DataDog/apm-python
.riot/requirements/ae7e800.txt                                          @DataDog/apm-python
.riot/requirements/f7e8645.txt                                          @DataDog/apm-python
hatch.toml                                                              @DataDog/python-guild
riotfile.py                                                             @DataDog/apm-python
tests/ci_visibility/suitespec.yml                                       @DataDog/ci-app-libraries

@github-actions
Copy link
Contributor

github-actions bot commented May 22, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 234 ± 3 ms.

The average import time from base is: 234 ± 4 ms.

The import time difference between this PR and base is: -0.2 ± 0.2 ms.

The difference is not statistically significant (z = -1.06).

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 1.816 ms (0.77%)
ddtrace.bootstrap.sitecustomize 1.145 ms (0.49%)
ddtrace.bootstrap.preload 1.145 ms (0.49%)
ddtrace.internal.remoteconfig.client 0.602 ms (0.26%)
ddtrace 0.671 ms (0.29%)
ddtrace.internal._unpatched 0.023 ms (0.01%)

juanjux added 2 commits May 22, 2025 16:29
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
@juanjux juanjux added the changelog/no-changelog A changelog entry is not required for this PR. label May 22, 2025
@pr-commenter
Copy link

pr-commenter bot commented May 22, 2025

Benchmarks

Benchmark execution time: 2025-05-30 11:21:52

Comparing candidate commit 12e19a8 in PR branch juanjux/dd_coverage_to_riot with baseline commit 8ac0c91 in branch main.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 506 metrics, 9 unstable metrics.

scenario:iastaspectsospath-ospathsplitdrive_aspect

  • 🟥 execution_time [+412.087ns; +501.115ns] or [+11.553%; +14.048%]

@brettlangdon brettlangdon enabled auto-merge (squash) May 29, 2025 12:53
@brettlangdon brettlangdon requested a review from gnufede May 29, 2025 13:36
@brettlangdon brettlangdon merged commit 8616f23 into main May 30, 2025
738 of 739 checks passed
@brettlangdon brettlangdon deleted the juanjux/dd_coverage_to_riot branch May 30, 2025 12:50
@github-actions
Copy link
Contributor

The backport to 2.21 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.21 2.21
# Navigate to the new working tree
cd .worktrees/backport-2.21
# Create a new branch
git switch --create backport-13487-to-2.21
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8616f2381417caf3bc1b4497329440f10566ae65
# Push it to GitHub
git push --set-upstream origin backport-13487-to-2.21
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.21

Then, create a pull request where the base branch is 2.21 and the compare/head branch is backport-13487-to-2.21.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 2.21 changelog/no-changelog A changelog entry is not required for this PR. CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants